1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-11 14:04:03 +00:00

more consistency fixes

This commit is contained in:
Vicki League
2025-06-26 13:20:19 -04:00
parent 79c7f1b1e6
commit 8866cd53f6
5 changed files with 11 additions and 11 deletions

View File

@@ -11,11 +11,11 @@ import { QueryParamsHandling } from "@angular/router";
export class BreadcrumbComponent {
readonly icon = input<string>();
readonly route = input<string | any[]>(undefined);
readonly route = input<string | any[]>();
readonly queryParams = input<Record<string, string>>({});
readonly queryParamsHandling = input<QueryParamsHandling>(undefined);
readonly queryParamsHandling = input<QueryParamsHandling>();
@Output()
click = new EventEmitter();

View File

@@ -17,7 +17,7 @@ export class BitIconComponent {
readonly icon = input<Icon>();
readonly ariaLabel = input<string | undefined>(undefined);
readonly ariaLabel = input<string>();
constructor(private domSanitizer: DomSanitizer) {
effect(() => {

View File

@@ -72,7 +72,7 @@ export class BitInputDirective implements BitFormFieldControl {
spellcheck = model<boolean>();
// TODO: Skipped for migration because:
// TODO: Skipped for signal migration because:
// Accessor inputs cannot be migrated as they are too complex.
@HostBinding()
@Input()

View File

@@ -78,11 +78,11 @@ export class SelectComponent<T> implements BitFormFieldControl, ControlValueAcce
return;
}
this.items.set(
value.toArray().map((c) => ({
icon: c.icon(),
value: c.value(),
label: c.label(),
disabled: c.disabled(),
value.toArray().map((option) => ({
icon: option.icon(),
value: option.value(),
label: option.label(),
disabled: option.disabled(),
})),
);
}
@@ -165,7 +165,7 @@ export class SelectComponent<T> implements BitFormFieldControl, ControlValueAcce
readonly id = input(`bit-multi-select-${nextId++}`);
/**Implemented as part of BitFormFieldControl */
// TODO: Skipped for migration because:
// TODO: Skipped for signal migration because:
// Accessor inputs cannot be migrated as they are too complex.
@HostBinding("attr.required")
@Input()

View File

@@ -32,7 +32,7 @@ const margins: Record<TypographyType, string[]> = {
selector: "[bitTypography]",
})
export class TypographyDirective {
readonly bitTypography = input<TypographyType>(undefined);
readonly bitTypography = input<TypographyType>();
readonly noMargin = input(false, { transform: booleanAttribute });