bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-13 15:03:26 +00:00
Code Issues Releases Wiki Activity

fix scroll positon after delete

Browse Source
This commit is contained in:
jaasen-livefront
2026-02-03 17:15:53 -08:00
parent e59a72eeed
commit 905127462c
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/browser/src/vault/popup/components/vault-v2/view-v2/view-v2.component.spec.ts
View File

@@ -66,7 +66,6 @@ describe("ViewV2Component", () => {
const back = jest.fn().mockResolvedValue(null);
const openSimpleDialog = jest.fn().mockResolvedValue(true);
const stop = jest.fn();
const forceTopOnNextVaultStart = jest.fn();
const showToast = jest.fn();
const showPasswordPrompt = jest.fn().mockResolvedValue(true);
const getFeatureFlag$ = jest.fn().mockReturnValue(of(true));
@@ -115,7 +114,6 @@ describe("ViewV2Component", () => {
doAutofill.mockClear();
copy.mockClear();
stop.mockClear();
forceTopOnNextVaultStart.mockClear();
openSimpleDialog.mockClear();
back.mockClear();
showToast.mockClear();
@@ -136,7 +134,7 @@ describe("ViewV2Component", () => {
{ provide: PopupRouterCacheService, useValue: mock<PopupRouterCacheService>({ back }) },
{ provide: ActivatedRoute, useValue: { queryParams: params$ } },
{ provide: EventCollectionService, useValue: { collect } },
{ provide: VaultPopupScrollPositionService, useValue: { stop, forceTopOnNextVaultStart } },
{ provide: VaultPopupScrollPositionService, useValue: { stop } },
{ provide: VaultPopupAutofillService, useValue: mockVaultPopupAutofillService },
{ provide: ToastService, useValue: { showToast } },
{ provide: ConfigService, useValue: { getFeatureFlag$ } },

2
apps/browser/src/vault/popup/services/vault-popup-scroll-position.service.ts
View File

@@ -34,7 +34,7 @@ export class VaultPopupScrollPositionService {
if (this.hasScrollPosition()) {
// Use `setTimeout` to scroll after rendering is complete
setTimeout(() => {
scrollElement.scrollTo({ top: this.scrollPosition, behavior: "instant" });
scrollElement.scrollTo({ top: this.scrollPosition!, behavior: "instant" });
});
}