bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-27 01:53:23 +00:00
Code Issues Releases Wiki Activity

Remove unnecessary type logic to use returned enum

Browse Source
This commit is contained in:
Nik Gilmore
2026-01-28 15:59:51 -08:00
parent 11509c9bc0
commit 9116345b02
1 changed files with 1 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
libs/common/src/vault/models/view/cipher.view.ts
View File

@@ -286,27 +286,7 @@ export class CipherView implements View, InitializerMetadata {
cipherView.folderId = uuidAsString(obj.folderId);
cipherView.name = obj.name;
cipherView.notes = obj.notes;
// SDK returns type as a discriminated union object, extract the actual CipherType
const sdkType: CipherViewType | CipherType = (obj.type as any) ?? CipherType.Login;
// Handle both discriminated union format and numeric CipherType
if (typeof sdkType === "number") {
cipherView.type = sdkType;
} else if (typeof sdkType === "object" && sdkType !== null) {
if ("login" in sdkType) {
cipherView.type = CipherType.Login;
} else if ("card" in sdkType) {
cipherView.type = CipherType.Card;
} else if ("identity" in sdkType) {
cipherView.type = CipherType.Identity;
} else if ("secureNote" in sdkType) {
cipherView.type = CipherType.SecureNote;
} else if ("sshKey" in sdkType) {
cipherView.type = CipherType.SshKey;
}
}
cipherView.type = obj.type ?? CipherType.Login;
cipherView.favorite = obj.favorite;
cipherView.organizationUseTotp = obj.organizationUseTotp;
cipherView.permissions = obj.permissions