Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows

apps/browser/src/autofill/content/content-message-handler.ts

@@ -5,6 +5,21 @@ import {
   ContentMessageWindowEventHandlers,
 } from "./abstractions/content-message-handler";
 
+/**
+ * Handlers for window messages from the content script.
+ * NOTE: These handlers should be above the event listener to ensure they are defined before being used.
+ */
+const windowMessageHandlers: ContentMessageWindowEventHandlers = {
+  authResult: ({ data, referrer }: { data: any; referrer: string }) =>
+    handleAuthResultMessage(data, referrer),
+  webAuthnResult: ({ data, referrer }: { data: any; referrer: string }) =>
+    handleWebAuthnResultMessage(data, referrer),
+  [VaultMessages.checkBwInstalled]: () => handleExtensionInstallCheck(),
+  duoResult: ({ data, referrer }: { data: any; referrer: string }) =>
+    handleDuoResultMessage(data, referrer),
+  [VaultMessages.OpenPopup]: () => handleOpenPopupMessage(),
+};
+
 /**
  * IMPORTANT: Safari seems to have a bug where it doesn't properly handle
  * window message events from content scripts when the listener these events
@@ -18,20 +33,6 @@ setupExtensionDisconnectAction(() => {
   chrome.runtime.onMessage.removeListener(handleExtensionMessage);
 });
 
-/**
- * Handlers for window messages from the content script.
- */
-const windowMessageHandlers: ContentMessageWindowEventHandlers = {
-  authResult: ({ data, referrer }: { data: any; referrer: string }) =>
-    handleAuthResultMessage(data, referrer),
-  webAuthnResult: ({ data, referrer }: { data: any; referrer: string }) =>
-    handleWebAuthnResultMessage(data, referrer),
-  [VaultMessages.checkBwInstalled]: () => handleExtensionInstallCheck(),
-  duoResult: ({ data, referrer }: { data: any; referrer: string }) =>
-    handleDuoResultMessage(data, referrer),
-  [VaultMessages.OpenPopup]: () => handleOpenPopupMessage(),
-};
-
 /**
  * Handles the post to the web vault showing the extension has been installed
  */

apps/web/src/app/vault/components/browser-extension-prompt/browser-extension-prompt-install.component.html

@@ -1,4 +1,6 @@
 <div class="tw-text-center" *ngIf="shouldShow$ | async">
   <p class="tw-mb-0">{{ "doNotHaveExtension" | i18n }}</p>
-  <a bitLink [href]="webStoreUrl">{{ "installExtension" | i18n }}</a>
+  <a bitLink [href]="webStoreUrl" target="_blank" rel="noreferrer">
+    {{ "installExtension" | i18n }}
+  </a>
 </div>