1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-29 14:43:31 +00:00

[PM-29896] specify noun or verb for Import / Export terms (#18012)

* [PM-29896] specify noun or verb for Import / Export terms

* [PM-29896] adjust verb to noun
This commit is contained in:
Alex Dragovich
2025-12-17 11:24:44 -08:00
committed by GitHub
parent 8087a972d5
commit 930cb9ab96
23 changed files with 74 additions and 44 deletions

View File

@@ -1322,11 +1322,21 @@
"exportFrom": {
"message": "Export from"
},
"export": {
"message": "Export"
"exportVerb": {
"message": "Export",
"description": "The verb form of the word Export"
},
"import": {
"message": "Import"
"exportNoun": {
"message": "Export",
"description": "The noun form of the word Export"
},
"importNoun": {
"message": "Import",
"description": "The noun form of the word Import"
},
"importVerb": {
"message": "Import",
"description": "The verb form of the word Import"
},
"fileFormat": {
"message": "File format"

View File

@@ -1,5 +1,5 @@
<popup-page>
<popup-header slot="header" [pageTitle]="'export' | i18n" showBackButton>
<popup-header slot="header" [pageTitle]="'exportNoun' | i18n" showBackButton>
<ng-container slot="end">
<app-pop-out></app-pop-out>
</ng-container>
@@ -21,7 +21,7 @@
bitFormButton
buttonType="primary"
>
{{ "export" | i18n }}
{{ "exportVerb" | i18n }}
</button>
<button bitButton type="button" buttonType="secondary" [popupBackAction]>
{{ "cancel" | i18n }}

View File

@@ -1,5 +1,5 @@
<popup-page>
<popup-header slot="header" [pageTitle]="'import' | i18n" showBackButton>
<popup-header slot="header" [pageTitle]="'importNoun' | i18n" showBackButton>
<ng-container slot="end">
<app-pop-out></app-pop-out>
</ng-container>
@@ -22,7 +22,7 @@
bitFormButton
buttonType="primary"
>
{{ "import" | i18n }}
{{ "importVerb" | i18n }}
</button>
</popup-footer>
</popup-page>

View File

@@ -15,7 +15,7 @@
<bit-item>
<button type="button" bit-item-content (click)="import()">
<div class="tw-flex tw-items-center tw-justify-center tw-gap-2">
<p>{{ "import" | i18n }}</p>
<p>{{ "importNoun" | i18n }}</p>
<span
*ngIf="emptyVaultImportBadge$ | async"
bitBadge
@@ -30,7 +30,7 @@
</bit-item>
<bit-item>
<a bit-item-content routerLink="/export">
{{ "export" | i18n }}
{{ "exportNoun" | i18n }}
<i slot="end" class="bwi bwi-angle-right" aria-hidden="true"></i>
</a>
</bit-item>

View File

@@ -1,5 +1,5 @@
<bit-dialog #dialog dialogSize="large">
<span bitDialogTitle>{{ "export" | i18n }}</span>
<span bitDialogTitle>{{ "exportNoun" | i18n }}</span>
<ng-container bitDialogContent>
<tools-export
(formLoading)="this.loading = $event"
@@ -17,7 +17,7 @@
bitFormButton
buttonType="primary"
>
{{ "export" | i18n }}
{{ "exportVerb" | i18n }}
</button>
<button type="button" bitButton bitFormButton buttonType="secondary" bitDialogClose>
{{ "cancel" | i18n }}

View File

@@ -1,5 +1,5 @@
<bit-dialog #dialog dialogSize="large" background="alt">
<span bitDialogTitle>{{ "import" | i18n }}</span>
<span bitDialogTitle>{{ "importNoun" | i18n }}</span>
<ng-container bitDialogContent>
<div class="tw-relative">
<tools-import
@@ -27,7 +27,7 @@
bitFormButton
buttonType="primary"
>
{{ "import" | i18n }}
{{ "importVerb" | i18n }}
</button>
<button type="button" bitButton bitFormButton buttonType="secondary" bitDialogClose>
{{ "cancel" | i18n }}

View File

@@ -1775,11 +1775,21 @@
"exportFrom": {
"message": "Export from"
},
"export": {
"message": "Export"
"exportNoun": {
"message": "Export",
"description": "The noun form of the word Export"
},
"import": {
"message": "Import"
"exportVerb": {
"message": "Export",
"description": "The verb form of the word Export"
},
"importNoun": {
"message": "Import",
"description": "The noun form of the word Import"
},
"importVerb": {
"message": "Import",
"description": "The verb form of the word Import"
},
"fileFormat": {
"message": "File format"

View File

@@ -156,7 +156,7 @@ export class FileMenu extends FirstMenu implements IMenubarMenu {
private get importVault(): MenuItemConstructorOptions {
return {
id: "import",
label: this.localize("import"),
label: this.localize("importNoun"),
click: () => this.sendMessage("importVault"),
enabled: !this._isLocked,
};
@@ -165,7 +165,7 @@ export class FileMenu extends FirstMenu implements IMenubarMenu {
private get exportVault(): MenuItemConstructorOptions {
return {
id: "export",
label: this.localize("export"),
label: this.localize("exportNoun"),
click: () => this.sendMessage("exportVault"),
enabled: !this._isLocked,
};

View File

@@ -104,12 +104,12 @@
*ngIf="organization.use2fa && organization.isOwner"
></bit-nav-item>
<bit-nav-item
[text]="'import' | i18n"
[text]="'importNoun' | i18n"
route="settings/tools/import"
*ngIf="organization.canAccessImport"
></bit-nav-item>
<bit-nav-item
[text]="'export' | i18n"
[text]="'exportNoun' | i18n"
route="settings/tools/export"
*ngIf="canAccessExport$ | async"
></bit-nav-item>

View File

@@ -57,7 +57,7 @@ const routes: Routes = [
),
canActivate: [organizationPermissionsGuard((org) => org.canAccessImport)],
data: {
titleId: "import",
titleId: "importNoun",
},
},
{
@@ -68,7 +68,7 @@ const routes: Routes = [
),
canActivate: [organizationPermissionsGuard((org) => org.canAccessExport)],
data: {
titleId: "export",
titleId: "exportNoun",
},
},
],

View File

@@ -6,8 +6,8 @@
<bit-nav-item icon="bwi-send" [text]="'send' | i18n" route="sends"></bit-nav-item>
<bit-nav-group icon="bwi-wrench" [text]="'tools' | i18n" route="tools">
<bit-nav-item [text]="'generator' | i18n" route="tools/generator"></bit-nav-item>
<bit-nav-item [text]="'import' | i18n" route="tools/import"></bit-nav-item>
<bit-nav-item [text]="'export' | i18n" route="tools/export"></bit-nav-item>
<bit-nav-item [text]="'importNoun' | i18n" route="tools/import"></bit-nav-item>
<bit-nav-item [text]="'exportNoun' | i18n" route="tools/export"></bit-nav-item>
</bit-nav-group>
<bit-nav-item icon="bwi-sliders" [text]="'reports' | i18n" route="reports"></bit-nav-item>
<bit-nav-group icon="bwi-cog" [text]="'settings' | i18n" route="settings">

View File

@@ -748,7 +748,7 @@ const routes: Routes = [
loadComponent: () =>
import("./tools/import/import-web.component").then((mod) => mod.ImportWebComponent),
data: {
titleId: "import",
titleId: "importNoun",
} satisfies RouteDataProperties,
},
{
@@ -758,7 +758,7 @@ const routes: Routes = [
(mod) => mod.ExportWebComponent,
),
data: {
titleId: "export",
titleId: "exportNoun",
} satisfies RouteDataProperties,
},
{

View File

@@ -15,6 +15,6 @@
bitFormButton
buttonType="primary"
>
{{ "import" | i18n }}
{{ "importVerb" | i18n }}
</button>
</bit-container>

View File

@@ -16,6 +16,6 @@
bitFormButton
buttonType="primary"
>
{{ "import" | i18n }}
{{ "importVerb" | i18n }}
</button>
</bit-container>

View File

@@ -15,6 +15,6 @@
bitFormButton
buttonType="primary"
>
{{ "export" | i18n }}
{{ "exportVerb" | i18n }}
</button>
</bit-container>

View File

@@ -16,6 +16,6 @@
bitFormButton
buttonType="primary"
>
{{ "export" | i18n }}
{{ "exportVerb" | i18n }}
</button>
</bit-container>

View File

@@ -1969,8 +1969,13 @@
"encExportAccountWarningDesc": {
"message": "Account encryption keys are unique to each Bitwarden user account, so you can't import an encrypted export into a different account."
},
"export": {
"message": "Export"
"exportNoun": {
"message": "Export",
"description": "The noun form of the word Export"
},
"exportVerb": {
"message": "Export",
"description": "The verb form of the word Export"
},
"exportFrom": {
"message": "Export from"
@@ -2297,8 +2302,13 @@
"tools": {
"message": "Tools"
},
"import": {
"message": "Import"
"importNoun": {
"message": "Import",
"description": "The noun form of the word Import"
},
"importVerb": {
"message": "Import",
"description": "The verb form of the word Import"
},
"importData": {
"message": "Import data"

View File

@@ -52,12 +52,12 @@
[relativeTo]="route.parent"
>
<bit-nav-item
[text]="'import' | i18n"
[text]="'importNoun' | i18n"
route="settings/import"
[relativeTo]="route.parent"
></bit-nav-item>
<bit-nav-item
[text]="'export' | i18n"
[text]="'exportNoun' | i18n"
route="settings/export"
[relativeTo]="route.parent"
></bit-nav-item>

View File

@@ -17,6 +17,6 @@
</bit-form-field>
<button bitButton bitFormButton type="submit" buttonType="primary">
{{ "export" | i18n }}
{{ "exportVerb" | i18n }}
</button>
</form>

View File

@@ -124,7 +124,7 @@ export class SecretsManagerExportComponent implements OnInit, OnDestroy {
const ref = openUserVerificationPrompt(this.dialogService, {
data: {
confirmDescription: "exportSecretsWarningDesc",
confirmButtonText: "export",
confirmButtonText: "exportVerb",
modalTitle: "confirmSecretsExport",
},
});

View File

@@ -36,6 +36,6 @@
<bit-hint>{{ "acceptedFormats" | i18n }} Bitwarden (json)</bit-hint>
</bit-form-field>
<button bitButton bitFormButton type="submit" buttonType="primary">
{{ "import" | i18n }}
{{ "importVerb" | i18n }}
</button>
</form>

View File

@@ -12,7 +12,7 @@ const routes: Routes = [
component: SecretsManagerImportComponent,
canActivate: [organizationPermissionsGuard((org) => org.isAdmin)],
data: {
titleId: "import",
titleId: "importNoun",
},
},
{
@@ -20,7 +20,7 @@ const routes: Routes = [
component: SecretsManagerExportComponent,
canActivate: [organizationPermissionsGuard((org) => org.isAdmin)],
data: {
titleId: "export",
titleId: "exportNoun",
},
},
];

View File

@@ -21,7 +21,7 @@
<ng-container bitDialogFooter>
<button bitButton buttonType="primary" type="submit">
<span>{{ "import" | i18n }}</span>
<span>{{ "importVerb" | i18n }}</span>
</button>
<button bitButton bitDialogClose buttonType="secondary" type="button">
<span>{{ "cancel" | i18n }}</span>