bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 06:43:35 +00:00
Code Issues Releases Wiki Activity

PM-11429 Users with Except PW permissions will not get Copy Password Option Vault V2 (#10831)

Browse Source
This commit is contained in:
Jason Ng
2024-08-30 15:38:37 -04:00
committed by GitHub
parent 95d04f264f
commit 963e339e4f
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/browser/src/vault/popup/components/vault-v2/item-copy-action/item-copy-actions.component.html
View File

@@ -13,7 +13,13 @@
<button type="button" bitMenuItem appCopyField="username" [cipher]="cipher"> <button type="button" bitMenuItem appCopyField="username" [cipher]="cipher">
{{ "copyUsername" | i18n }} {{ "copyUsername" | i18n }}
</button> </button>
<button type="button" bitMenuItem appCopyField="password" [cipher]="cipher"> <button
*ngIf="cipher.viewPassword"
type="button"
bitMenuItem
appCopyField="password"
[cipher]="cipher"
>
{{ "copyPassword" | i18n }} {{ "copyPassword" | i18n }}
</button> </button>
<button type="button" bitMenuItem appCopyField="totp" [cipher]="cipher"> <button type="button" bitMenuItem appCopyField="totp" [cipher]="cipher">

6
libs/vault/src/services/copy-cipher-field.service.spec.ts
View File

@@ -62,12 +62,6 @@ describe("CopyCipherFieldService", () => {
expect(platformUtilsService.copyToClipboard).not.toHaveBeenCalled(); expect(platformUtilsService.copyToClipboard).not.toHaveBeenCalled();
}); });
it("should return early when cipher.viewPassword is false", async () => {
cipher.viewPassword = false;
await service.copy(valueToCopy, actionType, cipher, skipReprompt);
expect(platformUtilsService.copyToClipboard).not.toHaveBeenCalled();
});
it("should copy value to clipboard", async () => { it("should copy value to clipboard", async () => {
await service.copy(valueToCopy, actionType, cipher, skipReprompt); await service.copy(valueToCopy, actionType, cipher, skipReprompt);
expect(platformUtilsService.copyToClipboard).toHaveBeenCalledWith(valueToCopy); expect(platformUtilsService.copyToClipboard).toHaveBeenCalledWith(valueToCopy);

2
libs/vault/src/services/copy-cipher-field.service.ts
View File

@@ -106,7 +106,7 @@ export class CopyCipherFieldService {
return; return;
} }
if (valueToCopy == null || !cipher.viewPassword) { if (valueToCopy == null) {
return; return;
} }