bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-06 19:53:59 +00:00
Code Issues Releases Wiki Activity

PM-26675 implemented PR comments from Claude

Browse Source
This commit is contained in:
voommen-livefront
2025-10-28 15:07:30 -05:00
parent 6396830953
commit 9b311bcce8
3 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bitwarden_license/bit-common/src/dirt/reports/risk-insights/models/drawer-models.types.ts
View File

@@ -13,7 +13,7 @@ export type DrawerDetails = {
open: boolean;
invokerId: string;
activeDrawerType: DrawerType;
atRiskMemberDetails?: AtRiskMemberDetail[];
atRiskMemberDetails?: AtRiskMemberDetail[] | null;
appAtRiskMembers?: AppAtRiskMembersDialogParams | null;
atRiskAppDetails?: AtRiskApplicationDetail[] | null;
};

2
bitwarden_license/bit-web/src/app/dirt/access-intelligence/risk-insights.component.ts
View File

@@ -109,7 +109,7 @@ export class RiskInsightsComponent implements OnInit, OnDestroy {
.subscribe((details) => {
if (details.activeDrawerType !== DrawerType.None) {
this.dialogService.openDrawer(RiskInsightsDrawerDialogComponent, {
data: { ...details },
data: details,
});
} else {
this.dialogService.closeAll();

10
bitwarden_license/bit-web/src/app/dirt/access-intelligence/shared/risk-insights-drawer-dialog.component.html
View File

@@ -1,11 +1,11 @@
@if (isActiveDrawerType(drawerTypes.OrgAtRiskMembers)) {
<bit-dialog dialogSize="large" disablePadding="false">
<ng-container bitDialogTitle>
<span>{{ "atRiskMembersWithCount" | i18n: drawerDetails.atRiskMemberDetails.length }}</span>
<span>{{ "atRiskMembersWithCount" | i18n: drawerDetails.atRiskMemberDetails?.length }}</span>
</ng-container>
<ng-container bitDialogContent>
<span bitTypography="body1" class="tw-text-muted tw-text-sm">{{
(drawerDetails.atRiskMemberDetails.length > 0
(drawerDetails.atRiskMemberDetails?.length > 0
? "atRiskMembersDescription"
: "atRiskMembersDescriptionNone"
) | i18n
@@ -62,11 +62,13 @@
@if (isActiveDrawerType(drawerTypes.OrgAtRiskApps)) {
<bit-dialog dialogSize="large" disablePadding="false">
<ng-container bitDialogTitle>
<span>{{ "atRiskApplicationsWithCount" | i18n: drawerDetails.atRiskAppDetails.length }}</span>
<span>{{
"atRiskApplicationsWithCount" | i18n: drawerDetails.atRiskAppDetails?.length
}}</span>
</ng-container>
<ng-container bitDialogContent>
<span bitTypography="body1" class="tw-text-muted tw-text-sm">{{
(drawerDetails.atRiskAppDetails.length > 0
(drawerDetails.atRiskAppDetails?.length > 0
? "atRiskApplicationsDescription"
: "atRiskApplicationsDescriptionNone"
) | i18n