bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

[PM-10247] Browser Refresh - Fix save credential banner (#10520)

Browse Source 
* [PM-10247] Prioritize initialValues when initiating the CipherForm child forms

* [PM-10247] Fetch the addEditCipherInfo when opening the cipher form in Browser and override any initialValues if present

* [PM-10247] Fix item details section tests

* [PM-10247] Add login details section test

* [PM-10247] Add autofill options tests

* [PM-10247] Undo webpack config change

* [PM-10247] Fix failing tests

* [PM-10247] Add additional tests for addEditCipherInfo
This commit is contained in:
Shane Melton
2024-08-26 12:03:47 -07:00
committed by GitHub
parent c18a7cb3e8
commit 9e093f88af
10 changed files with 306 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
libs/vault/src/cipher-form/components/item-details/item-details-section.component.ts
View File

@@ -190,9 +190,9 @@ export class ItemDetailsSectionComponent implements OnInit {
private async initFromExistingCipher() {
this.itemDetailsForm.setValue({
name: this.originalCipherView.name,
organizationId: this.originalCipherView.organizationId,
folderId: this.originalCipherView.folderId,
name: this.initialValues?.name ?? this.originalCipherView.name,
organizationId: this.originalCipherView.organizationId, // We do not allow changing ownership of an existing cipher.
folderId: this.initialValues?.folderId ?? this.originalCipherView.folderId,
collectionIds: [],
favorite: this.originalCipherView.favorite,
});
@@ -208,7 +208,10 @@ export class ItemDetailsSectionComponent implements OnInit {
}
}
await this.updateCollectionOptions(this.originalCipherView.collectionIds as CollectionId[]);
await this.updateCollectionOptions(
this.initialValues?.collectionIds ??
(this.originalCipherView.collectionIds as CollectionId[]),
);
if (this.partialEdit) {
this.itemDetailsForm.disable();