bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 15:53:27 +00:00
Code Issues Releases Wiki Activity

[PM-10247] Browser Refresh - Fix save credential banner (#10520)

Browse Source 
* [PM-10247] Prioritize initialValues when initiating the CipherForm child forms

* [PM-10247] Fetch the addEditCipherInfo when opening the cipher form in Browser and override any initialValues if present

* [PM-10247] Fix item details section tests

* [PM-10247] Add login details section test

* [PM-10247] Add autofill options tests

* [PM-10247] Undo webpack config change

* [PM-10247] Fix failing tests

* [PM-10247] Add additional tests for addEditCipherInfo
This commit is contained in:
Shane Melton
2024-08-26 12:03:47 -07:00
committed by GitHub
parent c18a7cb3e8
commit 9e093f88af
10 changed files with 306 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
libs/vault/src/cipher-form/components/login-details-section/login-details-section.component.ts
View File

@@ -95,6 +95,10 @@ export class LoginDetailsSectionComponent implements OnInit {
return true;
}
get initialValues() {
return this.cipherFormContainer.config.initialValues;
}
constructor(
private cipherFormContainer: CipherFormContainer,
private formBuilder: FormBuilder,
@@ -139,8 +143,8 @@ export class LoginDetailsSectionComponent implements OnInit {
private initFromExistingCipher(existingLogin: LoginView) {
this.loginDetailsForm.patchValue({
username: existingLogin.username,
password: existingLogin.password,
username: this.initialValues?.username ?? existingLogin.username,
password: this.initialValues?.password ?? existingLogin.password,
totp: existingLogin.totp,
});
@@ -154,8 +158,8 @@ export class LoginDetailsSectionComponent implements OnInit {
private async initNewCipher() {
this.loginDetailsForm.patchValue({
username: this.cipherFormContainer.config.initialValues?.username || "",
password: "",
username: this.initialValues?.username || "",
password: this.initialValues?.password || "",
});
}