bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-07 04:03:29 +00:00
Code Issues Releases Wiki Activity

fix(desktop): add CSC_NAME for MAS signing with pnpm

Browse Source 
electron-builder 26.3.6 fixed auto-discovery for Developer ID certificates
but not for "3rd Party Mac Developer Application" certificates used in
MAS builds.

The after-pack.js script successfully finds and uses the MAS certificate
for signing the proxy binary, but electron-builder's own signing mechanism
fails to auto-discover it, falling back to ad-hoc signing.

Add explicit CSC_NAME env var to the MAS build step in the workflow to
tell electron-builder exactly which certificate to use.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Anders Åberg
2026-01-06 22:06:16 +01:00
parent 50232d1b5f
commit aaeb1f1f7f
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.github/workflows/build-desktop.yml vendored
View File

@@ -1763,6 +1763,7 @@ jobs:
APP_STORE_CONNECT_AUTH_KEY: 6TV9MKN3GP
APP_STORE_CONNECT_AUTH_KEY_PATH: ~/private_keys/AuthKey_6TV9MKN3GP.p8
CSC_FOR_PULL_REQUEST: true
CSC_NAME: "Bitwarden Inc"
run: pnpm run pack:mac:mas
- name: Create MacOS App Store build number artifact