PM-29919 resolved pr comments

apps/browser/src/_locales/en/messages.json

@@ -2048,6 +2048,9 @@
   "email": {
     "message": "Email"
   },
+  "emails": {
+    "message": "Emails"
+  },
   "phone": {
     "message": "Phone"
   },

libs/tools/send/send-ui/src/send-form/components/send-details/send-details.component.html

@@ -59,12 +59,12 @@
           </bit-option>
         }
       </bit-select>
-      @if (sendDetailsForm.get("authType").value === "email") {
+      @if (sendDetailsForm.get("authType").value === AuthType.Email) {
         <bit-hint class="tw-mt-2">{{ "emailVerificationDesc" | i18n }}</bit-hint>
       }
     </bit-form-field>
 
-    @if (sendDetailsForm.get("authType").value === "password") {
+    @if (sendDetailsForm.get("authType").value === AuthType.Password) {
       <bit-form-field disableMargin>
         <bit-label>{{ (passwordRemoved ? "newPassword" : "password") | i18n }}</bit-label>
         <input bitInput type="password" formControlName="password" />
@@ -113,7 +113,7 @@
       </bit-form-field>
     }
 
-    @if (sendDetailsForm.get("authType").value === "email") {
+    @if (sendDetailsForm.get("authType").value === AuthType.Email) {
       <bit-form-field disableMargin>
         <bit-label>{{ "emails" | i18n }}</bit-label>
         <textarea

libs/tools/send/send-ui/src/send-form/components/send-details/send-details.component.spec.ts

@@ -11,6 +11,7 @@ import { ConfigService } from "@bitwarden/common/platform/abstractions/config/co
 import { EnvironmentService } from "@bitwarden/common/platform/abstractions/environment.service";
 import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
 import { SendApiService } from "@bitwarden/common/tools/send/services/send-api.service.abstraction";
+import { AuthType } from "@bitwarden/common/tools/send/types/auth-type";
 import { SendType } from "@bitwarden/common/tools/send/types/send-type";
 import { DialogService, ToastService } from "@bitwarden/components";
 import { CredentialGeneratorService } from "@bitwarden/generator-core";
@@ -100,7 +101,7 @@ describe("SendDetailsComponent", () => {
   });
 
   it("should initialize authType to null if no password or emails", () => {
-    expect(component.sendDetailsForm.value.authType).toBeNull();
+    expect(component.sendDetailsForm.value.authType).toBe(AuthType.None);
   });
 
   it("should toggle validation based on authType", () => {
@@ -112,17 +113,17 @@ describe("SendDetailsComponent", () => {
     expect(passwordControl?.validator).toBeNull();
 
     // Select Email
-    component.sendDetailsForm.patchValue({ authType: "email" });
+    component.sendDetailsForm.patchValue({ authType: AuthType.Email });
     expect(emailsControl?.validator).not.toBeNull();
     expect(passwordControl?.validator).toBeNull();
 
     // Select Password
-    component.sendDetailsForm.patchValue({ authType: "password" });
+    component.sendDetailsForm.patchValue({ authType: AuthType.Password });
     expect(passwordControl?.validator).not.toBeNull();
     expect(emailsControl?.validator).toBeNull();
 
     // Select None
-    component.sendDetailsForm.patchValue({ authType: null });
+    component.sendDetailsForm.patchValue({ authType: AuthType.None });
     expect(emailsControl?.validator).toBeNull();
     expect(passwordControl?.validator).toBeNull();
   });

libs/tools/send/send-ui/src/send-form/components/send-details/send-details.component.ts

@@ -24,6 +24,7 @@ import { Utils } from "@bitwarden/common/platform/misc/utils";
 import { pin } from "@bitwarden/common/tools/rx";
 import { SendView } from "@bitwarden/common/tools/send/models/view/send.view";
 import { SendApiService } from "@bitwarden/common/tools/send/services/send-api.service.abstraction";
+import { AuthType } from "@bitwarden/common/tools/send/types/auth-type";
 import { SendType } from "@bitwarden/common/tools/send/types/send-type";
 import {
   SectionComponent,
@@ -128,6 +129,7 @@ export class SendDetailsComponent implements OnInit {
 
   FileSendType = SendType.File;
   TextSendType = SendType.Text;
+  readonly AuthType = AuthType;
   sendLink: string | null = null;
   customDeletionDateOption: DatePresetSelectOption | null = null;
   datePresetOptions: DatePresetSelectOption[] = [];
@@ -140,19 +142,19 @@ export class SendDetailsComponent implements OnInit {
     ),
   );
 
-  authTypes: { name: string; value: string | null; disabled?: boolean }[] = [
-    { name: this.i18nService.t("noAuth"), value: null },
-    { name: this.i18nService.t("password"), value: "password" },
-    { name: this.i18nService.t("specificPeople"), value: "email" },
+  authTypes: { name: string; value: AuthType; disabled?: boolean }[] = [
+    { name: this.i18nService.t("noAuth"), value: AuthType.None },
+    { name: this.i18nService.t("password"), value: AuthType.Password },
+    { name: this.i18nService.t("specificPeople"), value: AuthType.Email },
   ];
 
   availableAuthTypes$ = combineLatest([this.emailVerificationFeatureFlag$, this.hasPremium$]).pipe(
     map(([enabled, hasPremium]) => {
       if (!enabled) {
-        return this.authTypes.filter((t) => t.value !== "email");
+        return this.authTypes.filter((t) => t.value !== AuthType.Email);
       }
       return this.authTypes.map((t) => {
-        if (t.value === "email" && !hasPremium) {
+        if (t.value === AuthType.Email && !hasPremium) {
           return { ...t, disabled: true };
         }
         return t;
@@ -163,13 +165,13 @@ export class SendDetailsComponent implements OnInit {
   sendDetailsForm = this.formBuilder.group({
     name: new FormControl("", Validators.required),
     selectedDeletionDatePreset: new FormControl(DatePreset.SevenDays || "", Validators.required),
-    authType: [null as string],
+    authType: [AuthType.None as AuthType],
     password: [null as string],
     emails: [null as string],
   });
 
   get hasPassword(): boolean {
-    return this.originalSendView && this.originalSendView.password !== null;
+    return this.originalSendView?.password !== null;
   }
 
   constructor(
@@ -219,11 +221,11 @@ export class SendDetailsComponent implements OnInit {
         const emailsControl = this.sendDetailsForm.get("emails");
         const passwordControl = this.sendDetailsForm.get("password");
 
-        if (type === "password") {
+        if (type === AuthType.Password) {
           emailsControl.setValue(null);
           emailsControl.clearValidators();
           passwordControl.setValidators([Validators.required]);
-        } else if (type === "email") {
+        } else if (type === AuthType.Email) {
           passwordControl.setValue(null);
           passwordControl.clearValidators();
           emailsControl.setValidators([Validators.required, this.emailListValidator()]);
@@ -249,10 +251,10 @@ export class SendDetailsComponent implements OnInit {
         selectedDeletionDatePreset: this.originalSendView.deletionDate.toString(),
         password: this.hasPassword ? "************" : null,
         authType: this.hasPassword
-          ? "password"
+          ? AuthType.Password
           : this.originalSendView.emails?.length > 0
-            ? "email"
-            : null,
+            ? AuthType.Email
+            : AuthType.None,
         emails: this.originalSendView.emails?.join(", "),
       });
 
@@ -338,7 +340,7 @@ export class SendDetailsComponent implements OnInit {
   };
 
   removePassword = async () => {
-    if (!this.originalSendView || !this.originalSendView.password) {
+    if (!this.originalSendView?.password) {
       return;
     }
     const confirmed = await this.dialogService.openSimpleDialog({