bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-20 03:13:55 +00:00
Code Issues Releases Wiki Activity

Update collectionIds handling in DefaultCipherFormService to preserve new values during cipher updates (#18650)

Browse Source
This commit is contained in:
Jared
2026-02-04 10:53:05 -05:00
committed by GitHub
parent febb64605a
commit b0cfe37e02
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libs/vault/src/cipher-form/services/default-cipher-form.service.ts
View File

@@ -76,6 +76,9 @@ export class DefaultCipherFormService implements CipherFormService {
.then((res) => res.cipher);
} else {
// Updating a cipher with collection changes is not supported with a single request currently
// Save the new collectionIds before overwriting
const newCollectionIdsToSave = cipher.collectionIds;
// First update the cipher with the original collectionIds
cipher.collectionIds = config.originalCipher.collectionIds;
const newCipher = await this.cipherService.updateWithServer(
@@ -86,7 +89,7 @@ export class DefaultCipherFormService implements CipherFormService {
);
// Then save the new collection changes separately
newCipher.collectionIds = cipher.collectionIds;
newCipher.collectionIds = newCollectionIdsToSave;
// TODO: Remove after migrating all SDK ops
const { cipher: encryptedCipher } = await this.cipherService.encrypt(newCipher, activeUserId);