bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-21 11:53:34 +00:00
Code Issues Releases Wiki Activity

make abortController optional to match the handler (#18143)

Browse Source
This commit is contained in:
Daniel Riera
2026-01-07 11:04:04 -05:00
committed by GitHub
parent 15efacaae9
commit ba89a3dd70
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/browser/src/autofill/fido2/content/fido2-content-script.ts
View File

@@ -1,5 +1,3 @@
// FIXME: Update this file to be type safe and remove this and next line
// @ts-strict-ignore
import {
AssertCredentialParams,
CreateCredentialParams,
@@ -41,12 +39,12 @@ import { MessageWithMetadata, Messenger } from "./messaging/messenger";
*/
async function handleFido2Message(
message: MessageWithMetadata,
abortController: AbortController,
abortController?: AbortController,
) {
const requestId = Date.now().toString();
const abortHandler = () =>
sendExtensionMessage("fido2AbortRequest", { abortedRequestId: requestId });
abortController.signal.addEventListener("abort", abortHandler);
abortController?.signal.addEventListener("abort", abortHandler);
try {
if (message.type === MessageTypes.CredentialCreationRequest) {
@@ -67,7 +65,7 @@ import { MessageWithMetadata, Messenger } from "./messaging/messenger";
return sendExtensionMessage("fido2AbortRequest", { abortedRequestId: requestId });
}
} finally {
abortController.signal.removeEventListener("abort", abortHandler);
abortController?.signal.removeEventListener("abort", abortHandler);
}
}