1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-06 19:53:59 +00:00

Remove unnecessary logs, no magic numbers, revert cipherId?

This commit is contained in:
Jeffrey Holland
2025-09-05 11:51:59 +02:00
parent 67f909e560
commit bcfca57089
3 changed files with 2 additions and 6 deletions

View File

@@ -37,9 +37,6 @@ export class NativeAutofillMain {
if (this.listenerReady && this.windowMain.win?.webContents) {
this.windowMain.win.webContents.send(channel, data);
} else {
this.logService.info(
`Buffering message to ${channel} until server is ready. Call .listenerReady() to flush.`,
);
this.messageBuffer.push({ channel, data });
}
}

View File

@@ -39,13 +39,12 @@ function positionWindow(window: BrowserWindow, position?: Position) {
const centeredY = position.y - popupHeight / 2;
window.setPosition(centeredX, centeredY);
} else {
this.logService.warning("No position provided, centering window");
window.center();
}
}
export function applyMainWindowStyles(window: BrowserWindow, existingWindowState: WindowState) {
window.setMinimumSize(600, 500);
window.setMinimumSize(popupWidth, popupHeight);
// need to guard against null/undefined values

View File

@@ -95,7 +95,7 @@ export abstract class Fido2UserInterfaceSession {
*/
abstract confirmNewCredential(
params: NewCredentialParams,
): Promise<{ cipherId: string; userVerified: boolean }>;
): Promise<{ cipherId?: string; userVerified: boolean }>;
/**
* Make sure that the vault is unlocked.