bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-19 10:54:00 +00:00
Code Issues Releases Wiki Activity

[PM-31354] Fix Reports page loading (#18631)

Browse Source 
* fix reports page loading

* update to signals, leave OnPush detection strategy
This commit is contained in:
Brad
2026-01-28 14:20:17 -08:00
committed by jaasen-livefront
parent a2487059ab
commit bf87041881
4 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/web/src/app/dirt/reports/pages/reports-home.component.html
View File

@@ -3,5 +3,5 @@
<bit-container>
<p>{{ "reportsDesc" | i18n }}</p>
<app-report-list [reports]="reports"></app-report-list>
<app-report-list [reports]="reports()"></app-report-list>
</bit-container>

8
apps/web/src/app/dirt/reports/pages/reports-home.component.ts
View File

@@ -1,6 +1,6 @@
// FIXME: Update this file to be type safe and remove this and next line
// @ts-strict-ignore
import { ChangeDetectionStrategy, Component, OnInit } from "@angular/core";
import { ChangeDetectionStrategy, Component, OnInit, signal } from "@angular/core";
import { firstValueFrom } from "rxjs";
import { AccountService } from "@bitwarden/common/auth/abstractions/account.service";
@@ -16,7 +16,7 @@ import { ReportEntry, ReportVariant } from "../shared";
standalone: false,
})
export class ReportsHomeComponent implements OnInit {
reports: ReportEntry[];
readonly reports = signal<ReportEntry[]>([]);
constructor(
private billingAccountProfileStateService: BillingAccountProfileStateService,
@@ -32,7 +32,7 @@ export class ReportsHomeComponent implements OnInit {
? ReportVariant.Enabled
: ReportVariant.RequiresPremium;
this.reports = [
this.reports.set([
{
...reports[ReportType.ExposedPasswords],
variant: reportRequiresPremium,
@@ -57,6 +57,6 @@ export class ReportsHomeComponent implements OnInit {
...reports[ReportType.DataBreach],
variant: ReportVariant.Enabled,
},
];
]);
}
}

2
apps/web/src/app/dirt/reports/shared/report-list/report-list.component.html
View File

@@ -1,7 +1,7 @@
<div
class="tw-inline-grid tw-place-items-stretch tw-place-content-center tw-grid-cols-1 @xl:tw-grid-cols-2 @4xl:tw-grid-cols-3 tw-gap-4 [&_a]:tw-max-w-none @5xl:[&_a]:tw-max-w-72"
>
@for (report of reports; track report) {
@for (report of reports(); track report) {
<div>
<app-report-card
[title]="report.title | i18n"

11
apps/web/src/app/dirt/reports/shared/report-list/report-list.component.ts
View File

@@ -1,18 +1,13 @@
// FIXME: Update this file to be type safe and remove this and next line
// @ts-strict-ignore
import { Component, Input } from "@angular/core";
import { ChangeDetectionStrategy, Component, input } from "@angular/core";
import { ReportEntry } from "../models/report-entry";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
changeDetection: ChangeDetectionStrategy.OnPush,
selector: "app-report-list",
templateUrl: "report-list.component.html",
standalone: false,
})
export class ReportListComponent {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() reports: ReportEntry[];
readonly reports = input<ReportEntry[]>([]);
}