bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-21 20:04:02 +00:00
Code Issues Releases Wiki Activity

Remove extra allocation when copying to ComBuffer from &[u8]

Browse Source
This commit is contained in:
Isaiah Inuwa
2026-02-20 08:18:27 -06:00
parent 7bfa9a05fe
commit ca9ba5ca35
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apps/desktop/desktop_native/win_webauthn/src/plugin/com.rs
View File

@@ -440,19 +440,15 @@ impl ComBufferExt for &[u16] {
impl<T: AsRef<[u8]>> From<T> for ComBuffer {
fn from(value: T) -> Self {
let buffer: Vec<u8> = value
.as_ref()
.iter()
.flat_map(|x| x.to_le_bytes())
.collect();
let len = buffer.len();
let slice = value.as_ref();
let len = slice.len();
let com_buffer = Self::alloc(len, true);
// SAFETY: `ptr` points to a valid allocation that `len` matches, and we made sure
// the bytes were initialized. Additionally, bytes have no alignment requirements.
unsafe {
NonNull::slice_from_raw_parts(com_buffer.0.cast::<u8>(), len)
.as_mut()
.copy_from_slice(&buffer);
.copy_from_slice(slice);
}
com_buffer
}