1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-11 05:53:42 +00:00

[PM-17735] - remove v2 suffix from browser vault components (#18108)

* remove v2 suffix

* fix test

* fix path

* fix test

* Fix missed -v2 import path

* fix test

---------

Co-authored-by: Shane <smelton@bitwarden.com>
This commit is contained in:
Jordan Aasen
2026-02-10 13:39:53 -08:00
committed by GitHub
parent 4fe29c71ce
commit cc03df4950
68 changed files with 176 additions and 177 deletions

View File

@@ -78,13 +78,13 @@ import { ExportBrowserV2Component } from "../tools/popup/settings/export/export-
import { ImportBrowserV2Component } from "../tools/popup/settings/import/import-browser-v2.component";
import { SettingsV2Component } from "../tools/popup/settings/settings-v2.component";
import { AtRiskPasswordsComponent } from "../vault/popup/components/at-risk-passwords/at-risk-passwords.component";
import { AddEditV2Component } from "../vault/popup/components/vault-v2/add-edit/add-edit-v2.component";
import { AssignCollections } from "../vault/popup/components/vault-v2/assign-collections/assign-collections.component";
import { AttachmentsV2Component } from "../vault/popup/components/vault-v2/attachments/attachments-v2.component";
import { IntroCarouselComponent } from "../vault/popup/components/vault-v2/intro-carousel/intro-carousel.component";
import { PasswordHistoryV2Component } from "../vault/popup/components/vault-v2/vault-password-history-v2/vault-password-history-v2.component";
import { VaultV2Component } from "../vault/popup/components/vault-v2/vault-v2.component";
import { ViewV2Component } from "../vault/popup/components/vault-v2/view-v2/view-v2.component";
import { AddEditComponent } from "../vault/popup/components/vault/add-edit/add-edit.component";
import { AssignCollections } from "../vault/popup/components/vault/assign-collections/assign-collections.component";
import { AttachmentsComponent } from "../vault/popup/components/vault/attachments/attachments.component";
import { IntroCarouselComponent } from "../vault/popup/components/vault/intro-carousel/intro-carousel.component";
import { PasswordHistoryComponent } from "../vault/popup/components/vault/vault-password-history/vault-password-history.component";
import { VaultComponent } from "../vault/popup/components/vault/vault.component";
import { ViewComponent } from "../vault/popup/components/vault/view/view.component";
import {
atRiskPasswordAuthGuard,
canAccessAtRiskPasswords,
@@ -93,13 +93,13 @@ import {
import { clearVaultStateGuard } from "../vault/popup/guards/clear-vault-state.guard";
import { IntroCarouselGuard } from "../vault/popup/guards/intro-carousel.guard";
import { AdminSettingsComponent } from "../vault/popup/settings/admin-settings.component";
import { AppearanceV2Component } from "../vault/popup/settings/appearance-v2.component";
import { AppearanceComponent } from "../vault/popup/settings/appearance.component";
import { ArchiveComponent } from "../vault/popup/settings/archive.component";
import { DownloadBitwardenComponent } from "../vault/popup/settings/download-bitwarden.component";
import { FoldersV2Component } from "../vault/popup/settings/folders-v2.component";
import { MoreFromBitwardenPageV2Component } from "../vault/popup/settings/more-from-bitwarden-page-v2.component";
import { FoldersComponent } from "../vault/popup/settings/folders.component";
import { MoreFromBitwardenPageComponent } from "../vault/popup/settings/more-from-bitwarden-page.component";
import { TrashComponent } from "../vault/popup/settings/trash.component";
import { VaultSettingsV2Component } from "../vault/popup/settings/vault-settings-v2.component";
import { VaultSettingsComponent } from "../vault/popup/settings/vault-settings.component";
import { RouteElevation } from "./app-routing.animations";
import {
@@ -214,7 +214,7 @@ const routes: Routes = [
},
{
path: "view-cipher",
component: ViewV2Component,
component: ViewComponent,
canActivate: [authGuard],
data: {
// Above "trash"
@@ -223,20 +223,20 @@ const routes: Routes = [
},
{
path: "cipher-password-history",
component: PasswordHistoryV2Component,
component: PasswordHistoryComponent,
canActivate: [authGuard],
data: { elevation: 4 } satisfies RouteDataProperties,
},
{
path: "add-cipher",
component: AddEditV2Component,
component: AddEditComponent,
canActivate: [authGuard, debounceNavigationGuard()],
data: { elevation: 1, resetRouterCacheOnTabChange: true } satisfies RouteDataProperties,
runGuardsAndResolvers: "always",
},
{
path: "edit-cipher",
component: AddEditV2Component,
component: AddEditComponent,
canActivate: [authGuard, debounceNavigationGuard()],
data: {
// Above "trash"
@@ -247,7 +247,7 @@ const routes: Routes = [
},
{
path: "attachments",
component: AttachmentsV2Component,
component: AttachmentsComponent,
canActivate: [authGuard, filePickerPopoutGuard()],
data: { elevation: 4 } satisfies RouteDataProperties,
},
@@ -301,13 +301,13 @@ const routes: Routes = [
},
{
path: "vault-settings",
component: VaultSettingsV2Component,
component: VaultSettingsComponent,
canActivate: [authGuard],
data: { elevation: 1 } satisfies RouteDataProperties,
},
{
path: "folders",
component: FoldersV2Component,
component: FoldersComponent,
canActivate: [authGuard],
data: { elevation: 2 } satisfies RouteDataProperties,
},
@@ -331,7 +331,7 @@ const routes: Routes = [
},
{
path: "appearance",
component: AppearanceV2Component,
component: AppearanceComponent,
canActivate: [authGuard],
data: { elevation: 1 } satisfies RouteDataProperties,
},
@@ -343,7 +343,7 @@ const routes: Routes = [
},
{
path: "clone-cipher",
component: AddEditV2Component,
component: AddEditComponent,
canActivate: [authGuard],
data: { elevation: 1 } satisfies RouteDataProperties,
},
@@ -635,7 +635,7 @@ const routes: Routes = [
},
{
path: "more-from-bitwarden",
component: MoreFromBitwardenPageV2Component,
component: MoreFromBitwardenPageComponent,
canActivate: [authGuard],
data: { elevation: 2 } satisfies RouteDataProperties,
},
@@ -696,7 +696,7 @@ const routes: Routes = [
},
{
path: "vault",
component: VaultV2Component,
component: VaultComponent,
canActivate: [authGuard],
canDeactivate: [clearVaultStateGuard],
data: { elevation: 0 } satisfies RouteDataProperties,

View File

@@ -40,16 +40,16 @@ import BrowserPopupUtils from "../../../../../platform/browser/browser-popup-uti
import { PopupRouterCacheService } from "../../../../../platform/popup/view-cache/popup-router-cache.service";
import { PopupCloseWarningService } from "../../../../../popup/services/popup-close-warning.service";
import { AddEditV2Component } from "./add-edit-v2.component";
import { AddEditComponent } from "./add-edit.component";
// 'qrcode-parser' is used by `BrowserTotpCaptureService` but is an es6 module that jest can't compile.
// Mock the entire module here to prevent jest from throwing an error. I wasn't able to find a way to mock the
// `BrowserTotpCaptureService` where jest would not load the file in the first place.
jest.mock("qrcode-parser", () => {});
describe("AddEditV2Component", () => {
let component: AddEditV2Component;
let fixture: ComponentFixture<AddEditV2Component>;
describe("AddEditComponent", () => {
let component: AddEditComponent;
let fixture: ComponentFixture<AddEditComponent>;
let addEditCipherInfo$: BehaviorSubject<AddEditCipherInfo | null>;
let cipherServiceMock: MockProxy<CipherService>;
@@ -85,7 +85,7 @@ describe("AddEditV2Component", () => {
});
await TestBed.configureTestingModule({
imports: [AddEditV2Component],
imports: [AddEditComponent],
providers: [
provideNoopAnimations(),
{ provide: PlatformUtilsService, useValue: mock<PlatformUtilsService>() },
@@ -143,7 +143,7 @@ describe("AddEditV2Component", () => {
})
.compileComponents();
fixture = TestBed.createComponent(AddEditV2Component);
fixture = TestBed.createComponent(AddEditComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});

View File

@@ -157,8 +157,8 @@ export type AddEditQueryParams = Partial<Record<keyof QueryParams, string>>;
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-add-edit-v2",
templateUrl: "add-edit-v2.component.html",
selector: "app-add-edit",
templateUrl: "add-edit.component.html",
providers: [
{ provide: CipherFormConfigService, useClass: DefaultCipherFormConfigService },
{ provide: TotpCaptureService, useClass: BrowserTotpCaptureService },
@@ -182,7 +182,7 @@ export type AddEditQueryParams = Partial<Record<keyof QueryParams, string>>;
BadgeModule,
],
})
export class AddEditV2Component implements OnInit, OnDestroy {
export class AddEditComponent implements OnInit, OnDestroy {
readonly cipherFormComponent = viewChild(CipherFormComponent);
headerText: string;
config: CipherFormConfig;

View File

@@ -23,7 +23,7 @@ import { PopupFooterComponent } from "../../../../../platform/popup/layout/popup
import { PopupHeaderComponent } from "../../../../../platform/popup/layout/popup-header.component";
import { PopupRouterCacheService } from "../../../../../platform/popup/view-cache/popup-router-cache.service";
import { AttachmentsV2Component } from "./attachments-v2.component";
import { AttachmentsComponent } from "./attachments.component";
@Component({
selector: "popup-header",
@@ -44,9 +44,9 @@ class MockPopupFooterComponent {
readonly pageTitle = input<string>();
}
describe("AttachmentsV2Component", () => {
let component: AttachmentsV2Component;
let fixture: ComponentFixture<AttachmentsV2Component>;
describe("AttachmentsComponent", () => {
let component: AttachmentsComponent;
let fixture: ComponentFixture<AttachmentsComponent>;
const queryParams = new BehaviorSubject<{ cipherId: string }>({ cipherId: "5555-444-3333" });
let cipherAttachment: CipherAttachmentsComponent;
const navigate = jest.fn();
@@ -60,7 +60,7 @@ describe("AttachmentsV2Component", () => {
navigate.mockClear();
await TestBed.configureTestingModule({
imports: [AttachmentsV2Component],
imports: [AttachmentsComponent],
providers: [
{ provide: LogService, useValue: mock<LogService>() },
{ provide: ConfigService, useValue: mock<ConfigService>() },
@@ -83,7 +83,7 @@ describe("AttachmentsV2Component", () => {
{ provide: OrganizationService, useValue: mock<OrganizationService>() },
],
})
.overrideComponent(AttachmentsV2Component, {
.overrideComponent(AttachmentsComponent, {
remove: {
imports: [PopupHeaderComponent, PopupFooterComponent],
},
@@ -95,7 +95,7 @@ describe("AttachmentsV2Component", () => {
});
beforeEach(() => {
fixture = TestBed.createComponent(AttachmentsV2Component);
fixture = TestBed.createComponent(AttachmentsComponent);
component = fixture.componentInstance;
fixture.detectChanges();

View File

@@ -20,8 +20,8 @@ import { PopupRouterCacheService } from "../../../../../platform/popup/view-cach
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-attachments-v2",
templateUrl: "./attachments-v2.component.html",
selector: "app-attachments",
templateUrl: "./attachments.component.html",
imports: [
CommonModule,
ButtonModule,
@@ -33,7 +33,7 @@ import { PopupRouterCacheService } from "../../../../../platform/popup/view-cach
PopOutComponent,
],
})
export class AttachmentsV2Component {
export class AttachmentsComponent {
/** The `id` tied to the underlying HTMLFormElement */
attachmentFormId = CipherAttachmentsComponent.attachmentFormID;

View File

@@ -35,7 +35,7 @@ import { PasswordRepromptService } from "@bitwarden/vault";
import { BrowserPremiumUpgradePromptService } from "../../../services/browser-premium-upgrade-prompt.service";
import { VaultPopupAutofillService } from "../../../services/vault-popup-autofill.service";
import { AddEditQueryParams } from "../add-edit/add-edit-v2.component";
import { AddEditQueryParams } from "../add-edit/add-edit.component";
import {
AutofillConfirmationDialogComponent,
AutofillConfirmationDialogResult,

View File

@@ -21,13 +21,13 @@ import { ButtonModule, DialogService, MenuModule, NoItemsModule } from "@bitward
import { BrowserApi } from "../../../../../platform/browser/browser-api";
import BrowserPopupUtils from "../../../../../platform/browser/browser-popup-utils";
import { NewItemDropdownV2Component, NewItemInitialValues } from "./new-item-dropdown-v2.component";
import { NewItemDropdownComponent, NewItemInitialValues } from "./new-item-dropdown.component";
describe("NewItemDropdownV2Component", () => {
let component: NewItemDropdownV2Component;
let fixture: ComponentFixture<NewItemDropdownV2Component>;
describe("NewItemDropdownComponent", () => {
let component: NewItemDropdownComponent;
let fixture: ComponentFixture<NewItemDropdownComponent>;
let dialogServiceMock: jest.Mocked<DialogService>;
let browserApiMock: jest.Mocked<typeof BrowserApi>;
const browserApiMock: jest.Mocked<typeof BrowserApi> = mock<typeof BrowserApi>();
let restrictedItemTypesServiceMock: jest.Mocked<RestrictedItemTypesService>;
const mockTab = { url: "https://example.com" };
@@ -62,7 +62,7 @@ describe("NewItemDropdownV2Component", () => {
ButtonModule,
MenuModule,
NoItemsModule,
NewItemDropdownV2Component,
NewItemDropdownComponent,
],
providers: [
{ provide: I18nService, useValue: { t: (key: string) => key } },
@@ -80,7 +80,7 @@ describe("NewItemDropdownV2Component", () => {
});
beforeEach(() => {
fixture = TestBed.createComponent(NewItemDropdownV2Component);
fixture = TestBed.createComponent(NewItemDropdownComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});

View File

@@ -15,7 +15,7 @@ import { AddEditFolderDialogComponent } from "@bitwarden/vault";
import { BrowserApi } from "../../../../../platform/browser/browser-api";
import BrowserPopupUtils from "../../../../../platform/browser/browser-popup-utils";
import { AddEditQueryParams } from "../add-edit/add-edit-v2.component";
import { AddEditQueryParams } from "../add-edit/add-edit.component";
export interface NewItemInitialValues {
folderId?: string;
@@ -27,10 +27,10 @@ export interface NewItemInitialValues {
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-new-item-dropdown",
templateUrl: "new-item-dropdown-v2.component.html",
templateUrl: "new-item-dropdown.component.html",
imports: [NoItemsModule, JslibModule, CommonModule, ButtonModule, RouterLink, MenuModule],
})
export class NewItemDropdownV2Component implements OnInit {
export class NewItemDropdownComponent implements OnInit {
cipherType = CipherType;
private tab?: chrome.tabs.Tab;
/**

View File

@@ -1,6 +1,6 @@
<div class="tw-flex tw-gap-1 tw-items-center">
<div class="tw-flex-1">
<app-vault-v2-search></app-vault-v2-search>
<app-vault-search></app-vault-search>
</div>
<div class="tw-relative">
<button

View File

@@ -24,18 +24,18 @@ import { VaultSettingsService } from "@bitwarden/common/vault/abstractions/vault
import { PasswordRepromptService } from "@bitwarden/vault";
import { AutofillService } from "../../../../../autofill/services/abstractions/autofill.service";
import { VaultPopupItemsService } from "../../../../../vault/popup/services/vault-popup-items.service";
import { VaultPopupItemsService } from "../../../services/vault-popup-items.service";
import {
PopupListFilter,
VaultPopupListFiltersService,
} from "../../../../../vault/popup/services/vault-popup-list-filters.service";
} from "../../../services/vault-popup-list-filters.service";
import { VaultPopupLoadingService } from "../../../services/vault-popup-loading.service";
import { VaultHeaderV2Component } from "./vault-header-v2.component";
import { VaultHeaderComponent } from "./vault-header.component";
describe("VaultHeaderV2Component", () => {
let component: VaultHeaderV2Component;
let fixture: ComponentFixture<VaultHeaderV2Component>;
describe("VaultHeaderComponent", () => {
let component: VaultHeaderComponent;
let fixture: ComponentFixture<VaultHeaderComponent>;
const emptyForm: PopupListFilter = {
organization: null,
@@ -57,7 +57,7 @@ describe("VaultHeaderV2Component", () => {
update.mockClear();
await TestBed.configureTestingModule({
imports: [VaultHeaderV2Component, CommonModule],
imports: [VaultHeaderComponent, CommonModule],
providers: [
{
provide: CipherService,
@@ -112,7 +112,7 @@ describe("VaultHeaderV2Component", () => {
],
}).compileComponents();
fixture = TestBed.createComponent(VaultHeaderV2Component);
fixture = TestBed.createComponent(VaultHeaderComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});

View File

@@ -13,17 +13,17 @@ import {
} from "@bitwarden/components";
import { runInsideAngular } from "../../../../../platform/browser/run-inside-angular.operator";
import { VaultPopupListFiltersService } from "../../../../../vault/popup/services/vault-popup-list-filters.service";
import { VaultPopupListFiltersService } from "../../../services/vault-popup-list-filters.service";
import { VaultListFiltersComponent } from "../vault-list-filters/vault-list-filters.component";
import { VaultV2SearchComponent } from "../vault-search/vault-v2-search.component";
import { VaultSearchComponent } from "../vault-search/vault-search.component";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-vault-header-v2",
templateUrl: "vault-header-v2.component.html",
selector: "app-vault-header",
templateUrl: "vault-header.component.html",
imports: [
VaultV2SearchComponent,
VaultSearchComponent,
VaultListFiltersComponent,
DisclosureComponent,
IconButtonModule,
@@ -32,7 +32,7 @@ import { VaultV2SearchComponent } from "../vault-search/vault-v2-search.componen
JslibModule,
],
})
export class VaultHeaderV2Component {
export class VaultHeaderComponent {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@ViewChild(DisclosureComponent) disclosure: DisclosureComponent;

View File

@@ -16,10 +16,10 @@ import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view";
import { PopupRouterCacheService } from "../../../../../platform/popup/view-cache/popup-router-cache.service";
import { PasswordHistoryV2Component } from "./vault-password-history-v2.component";
import { PasswordHistoryComponent } from "./vault-password-history.component";
describe("PasswordHistoryV2Component", () => {
let fixture: ComponentFixture<PasswordHistoryV2Component>;
describe("PasswordHistoryComponent", () => {
let fixture: ComponentFixture<PasswordHistoryComponent>;
const params$ = new Subject();
const mockUserId = "acct-1" as UserId;
@@ -40,7 +40,7 @@ describe("PasswordHistoryV2Component", () => {
getCipher.mockClear();
await TestBed.configureTestingModule({
imports: [PasswordHistoryV2Component],
imports: [PasswordHistoryComponent],
providers: [
{ provide: WINDOW, useValue: window },
{ provide: PlatformUtilsService, useValue: mock<PlatformUtilsService>() },
@@ -56,7 +56,7 @@ describe("PasswordHistoryV2Component", () => {
],
}).compileComponents();
fixture = TestBed.createComponent(PasswordHistoryV2Component);
fixture = TestBed.createComponent(PasswordHistoryComponent);
fixture.detectChanges();
});

View File

@@ -21,8 +21,8 @@ import { PopupRouterCacheService } from "../../../../../platform/popup/view-cach
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "vault-password-history-v2",
templateUrl: "vault-password-history-v2.component.html",
selector: "vault-password-history",
templateUrl: "vault-password-history.component.html",
imports: [
JslibModule,
PopupPageComponent,
@@ -32,7 +32,7 @@ import { PopupRouterCacheService } from "../../../../../platform/popup/view-cach
NgIf,
],
})
export class PasswordHistoryV2Component implements OnInit {
export class PasswordHistoryComponent implements OnInit {
protected cipher: CipherView;
constructor(

View File

@@ -11,18 +11,18 @@ import { SearchModule } from "@bitwarden/components";
import { VaultPopupItemsService } from "../../../services/vault-popup-items.service";
import { VaultPopupLoadingService } from "../../../services/vault-popup-loading.service";
import { VaultV2SearchComponent } from "./vault-v2-search.component";
import { VaultSearchComponent } from "./vault-search.component";
describe("VaultV2SearchComponent", () => {
let component: VaultV2SearchComponent;
let fixture: ComponentFixture<VaultV2SearchComponent>;
describe("VaultSearchComponent", () => {
let component: VaultSearchComponent;
let fixture: ComponentFixture<VaultSearchComponent>;
const searchText$ = new BehaviorSubject("");
const loading$ = new BehaviorSubject(false);
const applyFilter = jest.fn();
const createComponent = () => {
fixture = TestBed.createComponent(VaultV2SearchComponent);
fixture = TestBed.createComponent(VaultSearchComponent);
component = fixture.componentInstance;
fixture.detectChanges();
};
@@ -31,7 +31,7 @@ describe("VaultV2SearchComponent", () => {
applyFilter.mockClear();
await TestBed.configureTestingModule({
imports: [VaultV2SearchComponent, CommonModule, SearchModule, JslibModule, FormsModule],
imports: [VaultSearchComponent, CommonModule, SearchModule, JslibModule, FormsModule],
providers: [
{
provide: VaultPopupItemsService,

View File

@@ -24,10 +24,10 @@ import { VaultPopupLoadingService } from "../../../services/vault-popup-loading.
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
imports: [CommonModule, SearchModule, JslibModule, FormsModule],
selector: "app-vault-v2-search",
templateUrl: "vault-v2-search.component.html",
selector: "app-vault-search",
templateUrl: "vault-search.component.html",
})
export class VaultV2SearchComponent {
export class VaultSearchComponent {
searchText: string = "";
private searchText$ = new Subject<string>();

View File

@@ -74,7 +74,7 @@
</ul>
</bit-spotlight>
</div>
<app-vault-header-v2></app-vault-header-v2>
<app-vault-header></app-vault-header>
</ng-container>
</ng-container>

View File

@@ -50,10 +50,10 @@ import { AtRiskPasswordCalloutComponent } from "../at-risk-callout/at-risk-passw
import { AutofillVaultListItemsComponent } from "./autofill-vault-list-items/autofill-vault-list-items.component";
import { BlockedInjectionBanner } from "./blocked-injection-banner/blocked-injection-banner.component";
import { NewItemDropdownV2Component } from "./new-item-dropdown/new-item-dropdown-v2.component";
import { VaultHeaderV2Component } from "./vault-header/vault-header-v2.component";
import { NewItemDropdownComponent } from "./new-item-dropdown/new-item-dropdown.component";
import { VaultHeaderComponent } from "./vault-header/vault-header.component";
import { VaultListItemsContainerComponent } from "./vault-list-items-container/vault-list-items-container.component";
import { VaultV2Component } from "./vault-v2.component";
import { VaultComponent, VaultComponent } from "./vault.component";
@Component({
selector: "popup-header",
@@ -66,12 +66,12 @@ export class PopupHeaderStubComponent {
}
@Component({
selector: "app-vault-header-v2",
selector: "app-vault-header",
standalone: true,
template: "",
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class VaultHeaderV2StubComponent {}
export class VaultHeaderStubComponent {}
@Component({
selector: "app-current-account",
@@ -158,8 +158,8 @@ const autoConfirmDialogSpy = jest
jest.spyOn(BrowserApi, "isPopupOpen").mockResolvedValue(false);
jest.spyOn(BrowserPopupUtils, "openCurrentPagePopout").mockResolvedValue();
describe("VaultV2Component", () => {
let component: VaultV2Component;
describe("VaultComponent", () => {
let component: VaultComponent;
interface FakeAccount {
id: string;
@@ -242,7 +242,7 @@ describe("VaultV2Component", () => {
beforeEach(async () => {
jest.clearAllMocks();
await TestBed.configureTestingModule({
imports: [VaultV2Component, RouterTestingModule],
imports: [VaultComponent, RouterTestingModule],
providers: [
provideNoopAnimations(),
{ provide: VaultPopupItemsService, useValue: itemsSvc },
@@ -298,13 +298,13 @@ describe("VaultV2Component", () => {
schemas: [NO_ERRORS_SCHEMA],
}).compileComponents();
TestBed.overrideComponent(VaultV2Component, {
TestBed.overrideComponent(VaultComponent, {
remove: {
imports: [
PopupHeaderComponent,
VaultHeaderV2Component,
VaultHeaderComponent,
CurrentAccountComponent,
NewItemDropdownV2Component,
NewItemDropdownComponent,
PopOutComponent,
BlockedInjectionBanner,
AtRiskPasswordCalloutComponent,
@@ -318,7 +318,7 @@ describe("VaultV2Component", () => {
add: {
imports: [
PopupHeaderStubComponent,
VaultHeaderV2StubComponent,
VaultHeaderStubComponent,
CurrentAccountStubComponent,
NewItemDropdownStubComponent,
PopOutStubComponent,
@@ -331,7 +331,7 @@ describe("VaultV2Component", () => {
},
});
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
component = fixture.componentInstance;
});
@@ -393,7 +393,7 @@ describe("VaultV2Component", () => {
});
it("passes popup-page scroll region element to scroll position service", fakeAsync(() => {
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
const component = fixture.componentInstance;
const readySubject$ = component["readySubject"] as unknown as BehaviorSubject<boolean>;
@@ -491,7 +491,7 @@ describe("VaultV2Component", () => {
of(type === NudgeType.PremiumUpgrade),
);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
const component = fixture.componentInstance;
void component.ngOnInit();
@@ -524,7 +524,7 @@ describe("VaultV2Component", () => {
return of(type === NudgeType.EmptyVaultNudge);
});
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
fixture.detectChanges();
tick();
@@ -541,7 +541,7 @@ describe("VaultV2Component", () => {
return of(type === NudgeType.HasVaultItems);
});
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
fixture.detectChanges();
tick();
@@ -559,7 +559,7 @@ describe("VaultV2Component", () => {
return of(type === NudgeType.PremiumUpgrade);
});
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
fixture.detectChanges();
tick();
@@ -575,7 +575,7 @@ describe("VaultV2Component", () => {
return of(type === NudgeType.PremiumUpgrade);
});
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
fixture.detectChanges();
tick();
@@ -591,7 +591,7 @@ describe("VaultV2Component", () => {
return of(type === NudgeType.PremiumUpgrade);
});
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
fixture.detectChanges();
tick();
@@ -602,7 +602,7 @@ describe("VaultV2Component", () => {
it("does not render app-autofill-vault-list-items or favorites item container when hasSearchText$ is true", () => {
itemsSvc.hasSearchText$.next(true);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
component = fixture.componentInstance;
const readySubject$ = component["readySubject"];
@@ -628,7 +628,7 @@ describe("VaultV2Component", () => {
itemsSvc.hasSearchText$.next(false);
loadingSvc.loading$.next(false);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
component = fixture.componentInstance;
const readySubject$ = component["readySubject"];
@@ -655,7 +655,7 @@ describe("VaultV2Component", () => {
filtersSvc.numberOfAppliedFilters$.next(0);
loadingSvc.loading$.next(false);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
component = fixture.componentInstance;
const readySubject$ = component["readySubject"];
@@ -679,7 +679,7 @@ describe("VaultV2Component", () => {
itemsSvc.hasSearchText$.next(true);
loadingSvc.loading$.next(false);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
component = fixture.componentInstance;
const readySubject$ = component["readySubject"];
@@ -704,7 +704,7 @@ describe("VaultV2Component", () => {
filtersSvc.numberOfAppliedFilters$.next(1);
loadingSvc.loading$.next(false);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
component = fixture.componentInstance;
const readySubject$ = component["readySubject"];
@@ -735,7 +735,7 @@ describe("VaultV2Component", () => {
}),
);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
const component = fixture.componentInstance;
void component.ngOnInit();
@@ -754,7 +754,7 @@ describe("VaultV2Component", () => {
}),
);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
const component = fixture.componentInstance;
void component.ngOnInit();
@@ -773,7 +773,7 @@ describe("VaultV2Component", () => {
}),
);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
const component = fixture.componentInstance;
void component.ngOnInit();
@@ -792,7 +792,7 @@ describe("VaultV2Component", () => {
}),
);
const fixture = TestBed.createComponent(VaultV2Component);
const fixture = TestBed.createComponent(VaultComponent);
const component = fixture.componentInstance;
void component.ngOnInit();

View File

@@ -71,10 +71,10 @@ import { VaultLoadingSkeletonComponent } from "../vault-loading-skeleton/vault-l
import { BlockedInjectionBanner } from "./blocked-injection-banner/blocked-injection-banner.component";
import {
NewItemDropdownV2Component,
NewItemDropdownComponent,
NewItemInitialValues,
} from "./new-item-dropdown/new-item-dropdown-v2.component";
import { VaultHeaderV2Component } from "./vault-header/vault-header-v2.component";
} from "./new-item-dropdown/new-item-dropdown.component";
import { VaultHeaderComponent } from "./vault-header/vault-header.component";
import { AutofillVaultListItemsComponent, VaultListItemsContainerComponent } from ".";
@@ -90,7 +90,7 @@ type VaultState = UnionOfValues<typeof VaultState>;
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-vault",
templateUrl: "vault-v2.component.html",
templateUrl: "vault.component.html",
imports: [
BlockedInjectionBanner,
PopupPageComponent,
@@ -103,9 +103,9 @@ type VaultState = UnionOfValues<typeof VaultState>;
AutofillVaultListItemsComponent,
VaultListItemsContainerComponent,
ButtonModule,
NewItemDropdownV2Component,
NewItemDropdownComponent,
ScrollingModule,
VaultHeaderV2Component,
VaultHeaderComponent,
AtRiskPasswordCalloutComponent,
SpotlightComponent,
RouterModule,
@@ -116,7 +116,7 @@ type VaultState = UnionOfValues<typeof VaultState>;
],
providers: [{ provide: VaultItemsTransferService, useClass: DefaultVaultItemsTransferService }],
})
export class VaultV2Component implements OnInit, OnDestroy {
export class VaultComponent implements OnInit, OnDestroy {
NudgeType = NudgeType;
cipherType = CipherType;
private activeUserId$ = this.accountService.activeAccount$.pipe(getUserId);

View File

@@ -45,19 +45,19 @@ import {
import { BrowserApi } from "../../../../../platform/browser/browser-api";
import BrowserPopupUtils from "../../../../../platform/browser/browser-popup-utils";
import { PopupRouterCacheService } from "../../../../../platform/popup/view-cache/popup-router-cache.service";
import { VaultPopupAutofillService } from "../../../services/vault-popup-autofill.service";
import { VaultPopupScrollPositionService } from "../../../services/vault-popup-scroll-position.service";
import { VaultPopupAutofillService } from "./../../../services/vault-popup-autofill.service";
import { ViewV2Component } from "./view-v2.component";
import { ViewComponent } from "./view.component";
// 'qrcode-parser' is used by `BrowserTotpCaptureService` but is an es6 module that jest can't compile.
// Mock the entire module here to prevent jest from throwing an error. I wasn't able to find a way to mock the
// `BrowserTotpCaptureService` where jest would not load the file in the first place.
jest.mock("qrcode-parser", () => {});
describe("ViewV2Component", () => {
let component: ViewV2Component;
let fixture: ComponentFixture<ViewV2Component>;
describe("ViewComponent", () => {
let component: ViewComponent;
let fixture: ComponentFixture<ViewComponent>;
const params$ = new Subject();
const mockNavigate = jest.fn();
const collect = jest.fn().mockResolvedValue(null);
@@ -124,7 +124,7 @@ describe("ViewV2Component", () => {
cipherArchiveService.unarchiveWithServer.mockResolvedValue({ id: "122-333-444" } as CipherData);
await TestBed.configureTestingModule({
imports: [ViewV2Component],
imports: [ViewComponent],
providers: [
{ provide: Router, useValue: { navigate: mockNavigate } },
{ provide: CipherService, useValue: mockCipherService },
@@ -231,7 +231,7 @@ describe("ViewV2Component", () => {
})
.compileComponents();
fixture = TestBed.createComponent(ViewV2Component);
fixture = TestBed.createComponent(ViewComponent);
component = fixture.componentInstance;
fixture.detectChanges();
(component as any).showFooter$ = of(true);

View File

@@ -56,17 +56,16 @@ import { sendExtensionMessage } from "../../../../../autofill/utils/index";
import { BrowserApi } from "../../../../../platform/browser/browser-api";
import BrowserPopupUtils from "../../../../../platform/browser/browser-popup-utils";
import { PopOutComponent } from "../../../../../platform/popup/components/pop-out.component";
import { PopupFooterComponent } from "../../../../../platform/popup/layout/popup-footer.component";
import { PopupHeaderComponent } from "../../../../../platform/popup/layout/popup-header.component";
import { PopupPageComponent } from "../../../../../platform/popup/layout/popup-page.component";
import { PopupRouterCacheService } from "../../../../../platform/popup/view-cache/popup-router-cache.service";
import { BrowserPremiumUpgradePromptService } from "../../../services/browser-premium-upgrade-prompt.service";
import { BrowserViewPasswordHistoryService } from "../../../services/browser-view-password-history.service";
import { VaultPopupAutofillService } from "../../../services/vault-popup-autofill.service";
import { VaultPopupScrollPositionService } from "../../../services/vault-popup-scroll-position.service";
import { closeViewVaultItemPopout, VaultPopoutType } from "../../../utils/vault-popout-window";
import { ROUTES_AFTER_EDIT_DELETION } from "../add-edit/add-edit-v2.component";
import { PopupFooterComponent } from "./../../../../../platform/popup/layout/popup-footer.component";
import { PopupHeaderComponent } from "./../../../../../platform/popup/layout/popup-header.component";
import { PopupPageComponent } from "./../../../../../platform/popup/layout/popup-page.component";
import { VaultPopupAutofillService } from "./../../../services/vault-popup-autofill.service";
import { ROUTES_AFTER_EDIT_DELETION } from "../add-edit/add-edit.component";
/**
* The types of actions that can be triggered when loading the view vault item popout via the
@@ -83,8 +82,8 @@ type LoadAction =
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-view-v2",
templateUrl: "view-v2.component.html",
selector: "app-view",
templateUrl: "view.component.html",
imports: [
CommonModule,
SearchModule,
@@ -107,7 +106,7 @@ type LoadAction =
{ provide: ChangeLoginPasswordService, useClass: DefaultChangeLoginPasswordService },
],
})
export class ViewV2Component {
export class ViewComponent {
private activeUserId: UserId;
headerText: string;

View File

@@ -1,7 +1,7 @@
import { TestBed } from "@angular/core/testing";
import { RouterStateSnapshot } from "@angular/router";
import { VaultV2Component } from "../components/vault-v2/vault-v2.component";
import { VaultComponent } from "../components/vault/vault.component";
import { VaultPopupItemsService } from "../services/vault-popup-items.service";
import { VaultPopupListFiltersService } from "../services/vault-popup-list-filters.service";
@@ -42,7 +42,7 @@ describe("clearVaultStateGuard", () => {
const nextState = { url } as RouterStateSnapshot;
const result = TestBed.runInInjectionContext(() =>
clearVaultStateGuard({} as VaultV2Component, null, null, nextState),
clearVaultStateGuard({} as VaultComponent, null, null, nextState),
);
expect(result).toBe(true);
@@ -56,7 +56,7 @@ describe("clearVaultStateGuard", () => {
const nextState = { url } as RouterStateSnapshot;
const result = TestBed.runInInjectionContext(() =>
clearVaultStateGuard({} as VaultV2Component, null, null, nextState),
clearVaultStateGuard({} as VaultComponent, null, null, nextState),
);
expect(result).toBe(true);
@@ -67,7 +67,7 @@ describe("clearVaultStateGuard", () => {
it("should not clear vault state when not changing states", () => {
const result = TestBed.runInInjectionContext(() =>
clearVaultStateGuard({} as VaultV2Component, null, null, null),
clearVaultStateGuard({} as VaultComponent, null, null, null),
);
expect(result).toBe(true);

View File

@@ -1,7 +1,7 @@
import { inject } from "@angular/core";
import { CanDeactivateFn } from "@angular/router";
import { VaultV2Component } from "../components/vault-v2/vault-v2.component";
import { VaultComponent } from "../components/vault/vault.component";
import { VaultPopupItemsService } from "../services/vault-popup-items.service";
import { VaultPopupListFiltersService } from "../services/vault-popup-list-filters.service";
@@ -10,8 +10,8 @@ import { VaultPopupListFiltersService } from "../services/vault-popup-list-filte
* This ensures the search and filter state is reset when navigating between different tabs,
* except viewing or editing a cipher.
*/
export const clearVaultStateGuard: CanDeactivateFn<VaultV2Component> = (
component: VaultV2Component,
export const clearVaultStateGuard: CanDeactivateFn<VaultComponent> = (
component: VaultComponent,
currentRoute,
currentState,
nextState,

View File

@@ -7,7 +7,7 @@ import { firstValueFrom } from "rxjs";
import { DialogService } from "@bitwarden/components";
import { CipherFormGenerationService } from "@bitwarden/vault";
import { VaultGeneratorDialogComponent } from "../components/vault-v2/vault-generator-dialog/vault-generator-dialog.component";
import { VaultGeneratorDialogComponent } from "../components/vault/vault-generator-dialog/vault-generator-dialog.component";
@Injectable()
export class BrowserCipherFormGenerationService implements CipherFormGenerationService {

View File

@@ -20,7 +20,7 @@ import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.co
import { PopupSizeService } from "../../../platform/popup/layout/popup-size.service";
import { VaultPopupCopyButtonsService } from "../services/vault-popup-copy-buttons.service";
import { AppearanceV2Component } from "./appearance-v2.component";
import { AppearanceComponent } from "./appearance.component";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@@ -49,9 +49,9 @@ class MockPopupPageComponent {
@Input() loading: boolean;
}
describe("AppearanceV2Component", () => {
let component: AppearanceV2Component;
let fixture: ComponentFixture<AppearanceV2Component>;
describe("AppearanceComponent", () => {
let component: AppearanceComponent;
let fixture: ComponentFixture<AppearanceComponent>;
const showFavicons$ = new BehaviorSubject<boolean>(true);
const enableBadgeCounter$ = new BehaviorSubject<boolean>(true);
@@ -80,7 +80,7 @@ describe("AppearanceV2Component", () => {
setEnableRoutingAnimation.mockClear();
await TestBed.configureTestingModule({
imports: [AppearanceV2Component],
imports: [AppearanceComponent],
providers: [
{ provide: ConfigService, useValue: mock<ConfigService>() },
{ provide: PlatformUtilsService, useValue: mock<PlatformUtilsService>() },
@@ -120,7 +120,7 @@ describe("AppearanceV2Component", () => {
},
],
})
.overrideComponent(AppearanceV2Component, {
.overrideComponent(AppearanceComponent, {
remove: {
imports: [PopupHeaderComponent, PopupPageComponent],
},
@@ -130,7 +130,7 @@ describe("AppearanceV2Component", () => {
})
.compileComponents();
fixture = TestBed.createComponent(AppearanceV2Component);
fixture = TestBed.createComponent(AppearanceComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});

View File

@@ -36,7 +36,7 @@ import { VaultPopupCopyButtonsService } from "../services/vault-popup-copy-butto
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "./appearance-v2.component.html",
templateUrl: "./appearance.component.html",
imports: [
CommonModule,
JslibModule,
@@ -52,7 +52,7 @@ import { VaultPopupCopyButtonsService } from "../services/vault-popup-copy-butto
PermitCipherDetailsPopoverComponent,
],
})
export class AppearanceV2Component implements OnInit {
export class AppearanceComponent implements OnInit {
private compactModeService = inject(PopupCompactModeService);
private copyButtonsService = inject(VaultPopupCopyButtonsService);
private popupSizeService = inject(PopupSizeService);

View File

@@ -42,7 +42,7 @@ import {
import { PopOutComponent } from "../../../platform/popup/components/pop-out.component";
import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-header.component";
import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
import { ROUTES_AFTER_EDIT_DELETION } from "../components/vault-v2/add-edit/add-edit-v2.component";
import { ROUTES_AFTER_EDIT_DELETION } from "../components/vault/add-edit/add-edit.component";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection

View File

@@ -19,7 +19,7 @@ import { AddEditFolderDialogComponent } from "@bitwarden/vault";
import { PopupFooterComponent } from "../../../platform/popup/layout/popup-footer.component";
import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-header.component";
import { FoldersV2Component } from "./folders-v2.component";
import { FoldersComponent } from "./folders.component";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@@ -48,9 +48,9 @@ class MockPopupFooterComponent {
@Input() pageTitle: string = "";
}
describe("FoldersV2Component", () => {
let component: FoldersV2Component;
let fixture: ComponentFixture<FoldersV2Component>;
describe("FoldersComponent", () => {
let component: FoldersComponent;
let fixture: ComponentFixture<FoldersComponent>;
const folderViews$ = new BehaviorSubject<FolderView[]>([]);
const open = jest.spyOn(AddEditFolderDialogComponent, "open");
const mockDialogService = { open: jest.fn() };
@@ -59,7 +59,7 @@ describe("FoldersV2Component", () => {
open.mockClear();
await TestBed.configureTestingModule({
imports: [FoldersV2Component],
imports: [FoldersComponent],
providers: [
{ provide: PlatformUtilsService, useValue: mock<PlatformUtilsService>() },
{ provide: ConfigService, useValue: mock<ConfigService>() },
@@ -69,7 +69,7 @@ describe("FoldersV2Component", () => {
{ provide: AccountService, useValue: mockAccountServiceWith("UserId" as UserId) },
],
})
.overrideComponent(FoldersV2Component, {
.overrideComponent(FoldersComponent, {
remove: {
imports: [PopupHeaderComponent, PopupFooterComponent],
},
@@ -80,7 +80,7 @@ describe("FoldersV2Component", () => {
.overrideProvider(DialogService, { useValue: mockDialogService })
.compileComponents();
fixture = TestBed.createComponent(FoldersV2Component);
fixture = TestBed.createComponent(FoldersComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});

View File

@@ -25,7 +25,7 @@ import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.co
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "./folders-v2.component.html",
templateUrl: "./folders.component.html",
imports: [
CommonModule,
JslibModule,
@@ -39,7 +39,7 @@ import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.co
AsyncActionsModule,
],
})
export class FoldersV2Component {
export class FoldersComponent {
folders$: Observable<FolderView[]>;
NoFoldersIcon = NoFolders;

View File

@@ -19,7 +19,7 @@ import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.co
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "more-from-bitwarden-page-v2.component.html",
templateUrl: "more-from-bitwarden-page.component.html",
imports: [
CommonModule,
JslibModule,
@@ -30,7 +30,7 @@ import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.co
ItemModule,
],
})
export class MoreFromBitwardenPageV2Component {
export class MoreFromBitwardenPageComponent {
protected familySponsorshipAvailable$: Observable<boolean>;
protected isFreeFamilyPolicyEnabled$: Observable<boolean>;
protected hasSingleEnterpriseOrg$: Observable<boolean>;

View File

@@ -19,7 +19,7 @@ import { PopOutComponent } from "../../../platform/popup/components/pop-out.comp
import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-header.component";
import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
import { VaultSettingsV2Component } from "./vault-settings-v2.component";
import { VaultSettingsComponent } from "./vault-settings.component";
@Component({
selector: "popup-header",
@@ -47,9 +47,9 @@ class MockPopOutComponent {
readonly show = input(true);
}
describe("VaultSettingsV2Component", () => {
let component: VaultSettingsV2Component;
let fixture: ComponentFixture<VaultSettingsV2Component>;
describe("VaultSettingsComponent", () => {
let component: VaultSettingsComponent;
let fixture: ComponentFixture<VaultSettingsComponent>;
let router: Router;
let mockCipherArchiveService: jest.Mocked<CipherArchiveService>;
@@ -90,11 +90,11 @@ describe("VaultSettingsV2Component", () => {
mockCipherArchiveService.hasArchiveFlagEnabled$ = mockHasArchiveFlagEnabled$.asObservable();
await TestBed.configureTestingModule({
imports: [VaultSettingsV2Component],
imports: [VaultSettingsComponent],
providers: [
provideRouter([
{ path: "archive", component: VaultSettingsV2Component },
{ path: "premium", component: VaultSettingsV2Component },
{ path: "archive", component: VaultSettingsComponent },
{ path: "premium", component: VaultSettingsComponent },
]),
{ provide: SyncService, useValue: mock<SyncService>() },
{ provide: ToastService, useValue: mock<ToastService>() },
@@ -117,7 +117,7 @@ describe("VaultSettingsV2Component", () => {
},
],
})
.overrideComponent(VaultSettingsV2Component, {
.overrideComponent(VaultSettingsComponent, {
remove: {
imports: [PopupHeaderComponent, PopupPageComponent, PopOutComponent],
},
@@ -127,7 +127,7 @@ describe("VaultSettingsV2Component", () => {
})
.compileComponents();
fixture = TestBed.createComponent(VaultSettingsV2Component);
fixture = TestBed.createComponent(VaultSettingsComponent);
component = fixture.componentInstance;
router = TestBed.inject(Router);
jest.spyOn(router, "navigate");

View File

@@ -23,7 +23,7 @@ import { BrowserPremiumUpgradePromptService } from "../services/browser-premium-
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "vault-settings-v2.component.html",
templateUrl: "vault-settings.component.html",
imports: [
CommonModule,
JslibModule,
@@ -39,7 +39,7 @@ import { BrowserPremiumUpgradePromptService } from "../services/browser-premium-
{ provide: PremiumUpgradePromptService, useClass: BrowserPremiumUpgradePromptService },
],
})
export class VaultSettingsV2Component implements OnInit, OnDestroy {
export class VaultSettingsComponent implements OnInit, OnDestroy {
private readonly premiumBadgeComponent = viewChild(PremiumBadgeComponent);
lastSync = "--";