bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-10 13:40:06 +00:00
Code Issues Releases Wiki Activity

Update feature flag name

Browse Source
This commit is contained in:
Alec Rippberger
2025-03-31 14:30:23 -05:00
parent 8563bc8983
commit cf72430ec7
3 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/browser/src/auth/services/extension-two-factor-auth-email-component.service.ts
View File

@@ -24,7 +24,7 @@ export class ExtensionTwoFactorAuthEmailComponentService
async openPopoutIfApprovedForEmail2fa(): Promise<void> {
const isTwoFactorFormPersistenceEnabled = await this.configService.getFeatureFlag(
FeatureFlag.PM9115_TwoFactorFormPersistence,
FeatureFlag.PM9115_TwoFactorExtensionDataPersistence,
);
if (isTwoFactorFormPersistenceEnabled) {

20
apps/browser/src/auth/services/extension-two-factor-form-cache.service.spec.ts
View File

@@ -42,7 +42,7 @@ describe("ExtensionTwoFactorFormCacheService", () => {
describe("feature enabled", () => {
beforeEach(async () => {
getFeatureFlag.mockImplementation((featureFlag: FeatureFlag) => {
if (featureFlag === FeatureFlag.PM9115_TwoFactorFormPersistence) {
if (featureFlag === FeatureFlag.PM9115_TwoFactorExtensionDataPersistence) {
return Promise.resolve(true);
}
return Promise.resolve(false);
@@ -56,7 +56,9 @@ describe("ExtensionTwoFactorFormCacheService", () => {
const result = await firstValueFrom(service.isEnabled$());
expect(result).toBe(true);
expect(getFeatureFlag).toHaveBeenCalledWith(FeatureFlag.PM9115_TwoFactorFormPersistence);
expect(getFeatureFlag).toHaveBeenCalledWith(
FeatureFlag.PM9115_TwoFactorExtensionDataPersistence,
);
});
});
@@ -65,7 +67,9 @@ describe("ExtensionTwoFactorFormCacheService", () => {
const result = await service.isEnabled();
expect(result).toBe(true);
expect(getFeatureFlag).toHaveBeenCalledWith(FeatureFlag.PM9115_TwoFactorFormPersistence);
expect(getFeatureFlag).toHaveBeenCalledWith(
FeatureFlag.PM9115_TwoFactorExtensionDataPersistence,
);
});
});
@@ -136,7 +140,7 @@ describe("ExtensionTwoFactorFormCacheService", () => {
beforeEach(async () => {
formDataSignal.set(mockFormData);
getFeatureFlag.mockImplementation((featureFlag: FeatureFlag) => {
if (featureFlag === FeatureFlag.PM9115_TwoFactorFormPersistence) {
if (featureFlag === FeatureFlag.PM9115_TwoFactorExtensionDataPersistence) {
return Promise.resolve(false);
}
return Promise.resolve(false);
@@ -151,7 +155,9 @@ describe("ExtensionTwoFactorFormCacheService", () => {
const result = await firstValueFrom(service.isEnabled$());
expect(result).toBe(false);
expect(getFeatureFlag).toHaveBeenCalledWith(FeatureFlag.PM9115_TwoFactorFormPersistence);
expect(getFeatureFlag).toHaveBeenCalledWith(
FeatureFlag.PM9115_TwoFactorExtensionDataPersistence,
);
});
});
@@ -160,7 +166,9 @@ describe("ExtensionTwoFactorFormCacheService", () => {
const result = await service.isEnabled();
expect(result).toBe(false);
expect(getFeatureFlag).toHaveBeenCalledWith(FeatureFlag.PM9115_TwoFactorFormPersistence);
expect(getFeatureFlag).toHaveBeenCalledWith(
FeatureFlag.PM9115_TwoFactorExtensionDataPersistence,
);
});
});

4
apps/browser/src/auth/services/extension-two-factor-form-cache.service.ts
View File

@@ -53,7 +53,9 @@ export class ExtensionTwoFactorFormCacheService extends TwoFactorFormCacheServic
* Observable that emits the current enabled state
*/
isEnabled$(): Observable<boolean> {
return from(this.configService.getFeatureFlag(FeatureFlag.PM9115_TwoFactorFormPersistence));
return from(
this.configService.getFeatureFlag(FeatureFlag.PM9115_TwoFactorExtensionDataPersistence),
);
}
/**