bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-11 05:53:42 +00:00
Code Issues Releases Wiki Activity

[PM-31867] Ensure that row content has aria-label (#18872)

Browse Source
This commit is contained in:
Vijay Oommen
2026-02-10 10:14:27 -06:00
committed by GitHub
parent 9853c141f9
commit d1f2a91d58
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
bitwarden_license/bit-web/src/app/dirt/access-intelligence/all-applications/applications.component.html
View File

@@ -50,6 +50,7 @@
[openApplication]="drawerDetails.invokerId || ''"
[checkboxChange]="onCheckboxChange"
[showAppAtRiskMembers]="showAppAtRiskMembers"
class="tw-mb-10"
></app-table-row-scrollable-m11>
@if (emptyTableExplanation()) {

16
bitwarden_license/bit-web/src/app/dirt/access-intelligence/shared/app-table-row-scrollable-m11.component.html
View File

@@ -25,6 +25,7 @@
<td
bitCell
[ngClass]="{ 'tw-bg-primary-100': row.applicationName === openApplication }"
[attr.aria-label]="'select' | i18n"
appStopProp
>
<input
@@ -43,7 +44,7 @@
(keydown.space)="showAppAtRiskMembers()(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
[attr.aria-label]="row.applicationName"
>
@if (row.iconCipher) {
<app-vault-icon [cipher]="row.iconCipher" [size]="24"></app-vault-icon>
@@ -57,12 +58,15 @@
(keydown.space)="showAppAtRiskMembers()(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
[attr.aria-label]="
row.applicationName + ' ' + (row.isMarkedAsCritical ? ('criticalBadge' | i18n) : '')
"
>
<div class="tw-flex tw-items-center tw-gap-2">
<div class="tw-max-w-md tw-truncate" [title]="row.applicationName">
{{ row.applicationName }}
</div>
@if (row.isMarkedAsCritical) {
<span bitBadge [attr.aria-label]="'criticalBadge' | i18n">{{
"criticalBadge" | i18n
@@ -79,7 +83,7 @@
(keydown.space)="showAppAtRiskMembers()(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
[attr.aria-label]="('atRiskPasswords' | i18n) + ' ' + row.atRiskPasswordCount"
>
<span>
{{ row.atRiskPasswordCount }}
@@ -94,7 +98,7 @@
(keydown.space)="showAppAtRiskMembers()(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
[attr.aria-label]="('totalPasswords' | i18n) + ' ' + row.passwordCount"
>
<span>
{{ row.passwordCount }}
@@ -109,7 +113,7 @@
(keydown.space)="showAppAtRiskMembers()(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
[attr.aria-label]="('atRiskMembers' | i18n) + ' ' + row.atRiskMemberCount"
>
<span>
{{ row.atRiskMemberCount }}
@@ -125,7 +129,7 @@
(keydown.space)="showAppAtRiskMembers()(row.applicationName)"
role="button"
tabindex="0"
[attr.aria-label]="'viewItem' | i18n"
[attr.aria-label]="('totalMembers' | i18n) + ' ' + row.memberCount"
>
{{ row.memberCount }}
</td>