bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-03-02 11:31:44 +00:00
Code Issues Releases Wiki Activity

Skipping the error message on the achievement processor but still emitting the metric update

Browse Source
This commit is contained in:
Daniel James Smith
2025-03-21 10:20:05 +01:00
parent ce67df43b3
commit d3175a3b53
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libs/common/src/tools/achievements/achievement-processor.ts
View File

@@ -46,10 +46,12 @@ function achievements(
// prevent duplicate updates
if (distinct.has(key)) {
const msg = `${achievement} failed to set ${key}; value already set by ${distinct.get(key)}`;
throw new Error(msg);
// FIXME Currently skipping this error for demo purposes
// const msg = `${achievement} failed to set ${key}; value already set by ${distinct.get(key)}`;
// throw new Error(msg);
} else {
distinct.set(key, achievement);
}
distinct.set(key, achievement);
metrics.set(measured.achievement.name, measured.achievement.value);
}