bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 01:33:33 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Resolving issues that exist for when a page element is scrolled

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-03-22 15:27:14 -05:00
parent 7c95bd8fb3
commit e5f06adb27
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -600,7 +600,13 @@ class OverlayBackground implements OverlayBackgroundInterface {
sender: chrome.runtime.MessageSender, sender: chrome.runtime.MessageSender,
) { ) {
const display = isOverlayHidden ? "none" : "block"; const display = isOverlayHidden ? "none" : "block";
const styles = setTransparentOverlay ? { display, opacity: 0 } : { display }; let styles: { display: string; opacity?: number } = { display };
if (typeof setTransparentOverlay !== "undefined") {
const opacity = setTransparentOverlay ? 0 : 1;
styles = { ...styles, opacity };
}
const portMessage = { command: "updateOverlayHidden", styles }; const portMessage = { command: "updateOverlayHidden", styles };
void BrowserApi.tabSendMessage( void BrowserApi.tabSendMessage(

2
apps/browser/src/autofill/services/autofill-overlay-content.service.ts
View File

@@ -749,7 +749,7 @@ class AutofillOverlayContentService implements AutofillOverlayContentServiceInte
if ( if (
this.focusedFieldData.focusedFieldRects?.top > 0 && this.focusedFieldData.focusedFieldRects?.top > 0 &&
this.focusedFieldData.focusedFieldRects?.top < window.innerHeight this.focusedFieldData.focusedFieldRects?.top < window.innerHeight + window.scrollY
) { ) {
return; return;
} }