bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-07 04:03:29 +00:00
Code Issues Releases Wiki Activity

Some tweaks

Browse Source
This commit is contained in:
Isaiah Inuwa
2025-11-05 14:17:52 -06:00
parent 40c6b4d909
commit ea3d02d253
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/desktop/desktop_native/windows_plugin_authenticator/src/assert.rs
View File

@@ -148,6 +148,10 @@ fn send_assertion_request(
request.allowed_credentials.len()
));
debug_log(format!(
"Allowed credentials: {:?}",
passkey_request.allowed_credentials
));
match serde_json::to_string(&passkey_request) {
Ok(request_json) => {
debug_log(&format!("Sending assertion request: {}", request_json));
@@ -219,6 +223,7 @@ unsafe fn create_get_assertion_response(
// Encode to CBOR with error handling
let mut cbor_data = Vec::new();
cbor_data.push(0); // CTAP_STATUS_OK
if let Err(e) = ciborium::ser::into_writer(&cbor_value, &mut cbor_data) {
debug_log(&format!(
"ERROR: Failed to encode CBOR assertion response: {:?}",
@@ -426,3 +431,6 @@ pub unsafe fn experimental_plugin_get_assertion(
}
}
}
#[cfg(test)]
mod tests {}

3
apps/desktop/desktop_native/windows_plugin_authenticator/src/webauthn.rs
View File

@@ -73,8 +73,7 @@ impl ExperimentalWebAuthnPluginCredentialDetails {
user_display_name: String,
) -> Self {
// Convert credential_id bytes to hex string, then allocate with COM
let credential_id_string = hex::encode(&credential_id);
let (credential_id_pointer, credential_id_byte_count) = ComBuffer::from_buffer(credential_id_string.as_bytes());
let (credential_id_pointer, credential_id_byte_count) = ComBuffer::from_buffer(credential_id);
// Convert user_id bytes to hex string, then allocate with COM
let user_id_string = hex::encode(&user_id);