bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-11 05:53:42 +00:00
Code Issues Releases Wiki Activity

Clarify not-preferred use

Browse Source
This commit is contained in:
Justin Baur
2025-01-23 11:27:43 -05:00
parent a959b87080
commit ef5d22adee
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/common/src/auth/services/token.service.ts
View File

@@ -472,6 +472,7 @@ export class TokenService implements TokenServiceAbstraction {
const secureStorageSupport = await firstValueFrom(this.secureStorageService.support$);
// Since we are just reading the access token, we can use secure storage even if it's not preferred
if (
secureStorageSupport.type === "supported" ||
secureStorageSupport.type === "not-preferred"
@@ -562,7 +563,7 @@ export class TokenService implements TokenServiceAbstraction {
vaultTimeoutAction,
vaultTimeout,
true,
false, // used to set a real value, not only for reading or clearing
refreshToken == null, // if the refresh token we are about to set is null then we are using this for clearing
);
switch (storageLocation) {
@@ -698,6 +699,9 @@ export class TokenService implements TokenServiceAbstraction {
// but we can simply clear all locations to avoid the need to require those parameters
const secureStorageSupport = await firstValueFrom(this.secureStorageService.support$);
// We can use a not-preferred secure storage service to clear the token
// it's important though that we still clear it from the other locations
// when it's not-preferred though, which we are doing.
if (
secureStorageSupport.type === "supported" ||
secureStorageSupport.type === "not-preferred"