bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-28 15:23:53 +00:00
Code Issues Releases Wiki Activity

Updates test mocks for Observable password generation signature

Browse Source
This commit is contained in:
Miles Blackwood
2026-01-23 12:09:19 -05:00
parent 7f845e4717
commit ef920ab751
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
apps/browser/src/autofill/background/overlay.background.spec.ts
View File

@@ -1,5 +1,7 @@
import { mock, MockProxy, mockReset } from "jest-mock-extended";
import { BehaviorSubject, of } from "rxjs";
import { BehaviorSubject, Observable, of } from "rxjs";
import { map } from "rxjs/operators";
import { PolicyService } from "@bitwarden/common/admin-console/abstractions/policy/policy.service.abstraction";
import { AuthService } from "@bitwarden/common/auth/abstractions/auth.service";
@@ -39,6 +41,7 @@ import { VaultSettingsService } from "@bitwarden/common/vault/abstractions/vault
import { CipherRepromptType, CipherType } from "@bitwarden/common/vault/enums";
import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view";
import { Fido2CredentialView } from "@bitwarden/common/vault/models/view/fido2-credential.view";
import { GeneratedCredential } from "@bitwarden/generator-history";
import { BrowserApi } from "../../platform/browser/browser-api";
import { BrowserPlatformUtilsService } from "../../platform/services/platform-utils/browser-platform-utils.service";
@@ -83,7 +86,11 @@ import { OverlayBackground } from "./overlay.background";
describe("OverlayBackground", () => {
const generatedPassword = "generated-password";
const generatedPasswordCallbackMock = jest.fn().mockResolvedValue(generatedPassword);
const generatedPasswordCallbackMock = jest
.fn()
.mockImplementation(($on: Observable<any>) =>
$on.pipe(map(() => new GeneratedCredential(generatedPassword, "password", new Date()))),
);
const addPasswordCallbackMock = jest.fn();
const mockUserId = Utils.newGuid() as UserId;
const sendResponse = jest.fn();

4
apps/browser/src/background/main.background.spec.ts
View File

@@ -11,3 +11,7 @@ describe("MainBackground sync task scheduling", () => {
expect(bootstrapSource).toContain("this.backgroundSyncService.init();");
});
});
// Note: yieldGeneratedPassword() and generatePasswordToClipboard() are tested
// through integration tests in overlay.background.spec.ts where they are
// exercised via the callback mechanism.