mirror of
https://github.com/bitwarden/browser
synced 2025-12-20 18:23:31 +00:00
[PM-9035] desktop build logic to provide credentials to os on sync (#10181)
* feat: scaffold desktop_objc * feat: rename fido2 to autofill * feat: scaffold electron autofill * feat: auto call hello world on init * feat: scaffold call to basic objc function * feat: simple log that checks if autofill is enabled * feat: adding some availability guards * feat: scaffold services and allow calls from inspector * feat: create custom type for returning strings across rust/objc boundary * chore: clean up comments * feat: enable ARC * feat: add util function `c_string_to_nsstring` * chore: refactor and rename to `run_command` * feat: add try-catch around command execution * feat: properly implement command calling Add static typing. Add proper error handling. * feat: add autoreleasepool to avoid memory leaks * chore: change objc names to camelCase * fix: error returning * feat: extract some helper functions into utils class * feat: scaffold status command * feat: implement status command * feat: implement password credential mapping * wip: implement sync command This crashes because we are not properly handling the fact that `saveCredentialIdentities` uses callbacks, resulting in a race condition where we try to access a variable (result) that has already gotten dealloc'd. * feat: first version of callback * feat: make run_command async * feat: functioning callback returns * chore: refactor to make objc code easier to read and use * feat: refactor everything to use new callback return method * feat: re-implement status command with callback * fix: warning about CommandContext not being FFI-safe * feat: implement sync command using callbacks * feat: implement manual password credential sync * feat: add auto syncing * docs: add todo * feat: add support for passkeys * chore: move desktop autofill service to init service * feat: auto-add all .m files to builder * fix: native build on unix and windows * fix: unused compiler warnings * fix: napi type exports * feat: add corresponding dist command * feat: comment signing profile until we fix signing * fix: build breaking on non-macOS platforms * chore: cargo lock update * chore: revert accidental version change * feat: put sync behind feature flag * chore: put files in autofill folder * fix: obj-c code not recompiling on changes * feat: add `namespace` to commands * fix: linting complaining about flag * feat: add autofill as owner of their objc code * chore: make autofill owner of run_command in core crate * fix: re-add napi annotation * fix: remove dev bypass
This commit is contained in:
39
apps/desktop/desktop_native/objc/src/native/run_command.m
Normal file
39
apps/desktop/desktop_native/objc/src/native/run_command.m
Normal file
@@ -0,0 +1,39 @@
|
||||
#import <Foundation/Foundation.h>
|
||||
#import "autofill/run_autofill_command.h"
|
||||
#import "interop.h"
|
||||
#import "utils.h"
|
||||
|
||||
void pickAndRunCommand(void* context, NSDictionary *input) {
|
||||
NSString *namespace = input[@"namespace"];
|
||||
|
||||
if ([namespace isEqual:@"autofill"]) {
|
||||
return runAutofillCommand(context, input);
|
||||
}
|
||||
|
||||
_return(context, _error([NSString stringWithFormat:@"Unknown namespace: %@", namespace]));
|
||||
}
|
||||
|
||||
/// [Callable from Rust]
|
||||
/// Runs a command with the given input JSON
|
||||
/// This function is called from Rust and is the entry point for running Objective-C code.
|
||||
/// It takes a JSON string as input, deserializes it, runs the command, and serializes the output.
|
||||
/// It also catches any exceptions that occur during the command execution.
|
||||
void runCommand(void *context, char* inputJson) {
|
||||
@autoreleasepool {
|
||||
@try {
|
||||
NSString *inputString = cStringToNSString(inputJson);
|
||||
|
||||
NSError *error = nil;
|
||||
NSDictionary *input = parseJson(inputString, error);
|
||||
if (error) {
|
||||
NSLog(@"Error occured while deserializing input params: %@", error);
|
||||
return _return(context, _error([NSString stringWithFormat:@"Error occured while deserializing input params: %@", error]));
|
||||
}
|
||||
|
||||
pickAndRunCommand(context, input);
|
||||
} @catch (NSException *e) {
|
||||
NSLog(@"Error occurred while running Objective-C command: %@", e);
|
||||
_return(context, _error([NSString stringWithFormat:@"Error occurred while running Objective-C command: %@", e]));
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user