bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-12 06:23:38 +00:00
Code Issues Releases Wiki Activity

PM-14927 changed retrieveCriticalApps to private method

Browse Source
This commit is contained in:
voommen-livefront
2024-12-06 09:43:26 -06:00
parent f11deb5a3b
commit f330bdac71
2 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bitwarden_license/bit-common/src/tools/reports/risk-insights/services/critical-apps-api.service.spec.ts
View File

@@ -116,12 +116,10 @@ describe("CriticalAppsApiService", () => {
encryptService.decryptToUtf8.mockResolvedValue("https://example.com");
apiService.send.mockResolvedValue(response);
const spy = jest.spyOn(service, "retrieveCriticalApps");
service.setOrganizationId(orgId as OrganizationId);
flush();
expect(spy).toHaveBeenCalled();
expect(keyService.getOrgKey).toHaveBeenCalledWith(orgId.toString());
expect(encryptService.decryptToUtf8).toHaveBeenCalledTimes(2);
expect(apiService.send).toHaveBeenCalledWith(

9
bitwarden_license/bit-common/src/tools/reports/risk-insights/services/critical-apps-api.service.ts
View File

@@ -1,5 +1,5 @@
import { Injectable, OnDestroy } from "@angular/core";
import { BehaviorSubject, firstValueFrom, map, Observable, Subject, takeUntil } from "rxjs";
import { BehaviorSubject, firstValueFrom, map, Observable, of, Subject, takeUntil } from "rxjs";
import { Opaque } from "type-fest";
import { ApiService } from "@bitwarden/common/abstractions/api.service";
@@ -90,11 +90,9 @@ export class CriticalAppsApiService implements OnDestroy {
this.orgId.next(orgId);
}
async retrieveCriticalApps(
orgId: OrganizationId | null,
): Promise<PasswordHealthReportApplicationsResponse[]> {
private async retrieveCriticalApps(orgId: OrganizationId | null) {
if (orgId === null) {
return [];
return of([]);
}
const response = await this.apiService.send(
@@ -126,7 +124,6 @@ export class CriticalAppsApiService implements OnDestroy {
);
this.criticalAppsList.next(updatedList);
return updatedList;
}
private async filterNewEntries(orgId: OrganizationId, selectedUrls: string[]): Promise<string[]> {