bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 14:53:33 +00:00
Code Issues Releases Wiki Activity

[PM-8027] Reverting flag from a fallback flag to an enhancement feature flag

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-06-17 05:02:38 -05:00
parent 42825a405a
commit f44f7c77f0
3 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts
View File

@@ -17,13 +17,12 @@ export class InlineMenuFieldQualificationService
private autofillFieldKeywordsMap: WeakMap<AutofillField, string> = new WeakMap(); private autofillFieldKeywordsMap: WeakMap<AutofillField, string> = new WeakMap();
private autocompleteDisabledValues = new Set(["off", "false"]); private autocompleteDisabledValues = new Set(["off", "false"]);
private newFieldKeywords = new Set(["new", "change", "neue", "ändern"]); private newFieldKeywords = new Set(["new", "change", "neue", "ändern"]);
private useBasicInlineMenuFieldQualificationFlagSet = false; private inlineMenuFieldQualificationFlagSet = false;
constructor() { constructor() {
void sendExtensionMessage("getUseBasicInlineMenuFieldQualificationFeatureFlag").then( void sendExtensionMessage("getInlineMenuFieldQualificationFeatureFlag").then(
(getUseBasicInlineMenuFieldQualificationFlag) => (getInlineMenuFieldQualificationFlag) =>
(this.useBasicInlineMenuFieldQualificationFlagSet = (this.inlineMenuFieldQualificationFlagSet = !!getInlineMenuFieldQualificationFlag?.result),
!!getUseBasicInlineMenuFieldQualificationFlag?.result),
); );
} }
@@ -34,7 +33,7 @@ export class InlineMenuFieldQualificationService
* @param pageDetails - The details of the page that the field is on. * @param pageDetails - The details of the page that the field is on.
*/ */
isFieldForLoginForm(field: AutofillField, pageDetails: AutofillPageDetails): boolean { isFieldForLoginForm(field: AutofillField, pageDetails: AutofillPageDetails): boolean {
if (this.useBasicInlineMenuFieldQualificationFlagSet) { if (!this.inlineMenuFieldQualificationFlagSet) {
return this.isFieldForLoginFormFallback(field); return this.isFieldForLoginFormFallback(field);
} }

8
apps/browser/src/background/runtime.background.ts
View File

@@ -69,7 +69,7 @@ export default class RuntimeBackground {
const messagesWithResponse = [ const messagesWithResponse = [
"biometricUnlock", "biometricUnlock",
"getUseTreeWalkerApiForPageDetailsCollectionFeatureFlag", "getUseTreeWalkerApiForPageDetailsCollectionFeatureFlag",
"getUseBasicInlineMenuFieldQualificationFeatureFlag", "getInlineMenuFieldQualificationFeatureFlag",
]; ];
if (messagesWithResponse.includes(msg.command)) { if (messagesWithResponse.includes(msg.command)) {
@@ -187,10 +187,8 @@ export default class RuntimeBackground {
FeatureFlag.UseTreeWalkerApiForPageDetailsCollection, FeatureFlag.UseTreeWalkerApiForPageDetailsCollection,
); );
} }
case "getUseBasicInlineMenuFieldQualificationFeatureFlag": { case "getInlineMenuFieldQualificationFeatureFlag": {
return await this.configService.getFeatureFlag( return await this.configService.getFeatureFlag(FeatureFlag.InlineMenuFieldQualification);
FeatureFlag.UseBasicInlineMenuFieldQualification,
);
} }
} }
} }

4
libs/common/src/enums/feature-flag.enum.ts
View File

@@ -18,7 +18,7 @@ export enum FeatureFlag {
UseTreeWalkerApiForPageDetailsCollection = "use-tree-walker-api-for-page-details-collection", UseTreeWalkerApiForPageDetailsCollection = "use-tree-walker-api-for-page-details-collection",
BulkDeviceApproval = "bulk-device-approval", BulkDeviceApproval = "bulk-device-approval",
EmailVerification = "email-verification", EmailVerification = "email-verification",
UseBasicInlineMenuFieldQualification = "use-basic-inline-menu-field-qualification", InlineMenuFieldQualification = "inline-menu-field-qualification",
} }
export type AllowedFeatureFlagTypes = boolean | number | string; export type AllowedFeatureFlagTypes = boolean | number | string;
@@ -47,7 +47,7 @@ export const DefaultFeatureFlagValue = {
[FeatureFlag.UseTreeWalkerApiForPageDetailsCollection]: FALSE, [FeatureFlag.UseTreeWalkerApiForPageDetailsCollection]: FALSE,
[FeatureFlag.BulkDeviceApproval]: FALSE, [FeatureFlag.BulkDeviceApproval]: FALSE,
[FeatureFlag.EmailVerification]: FALSE, [FeatureFlag.EmailVerification]: FALSE,
[FeatureFlag.UseBasicInlineMenuFieldQualification]: FALSE, [FeatureFlag.InlineMenuFieldQualification]: FALSE,
} satisfies Record<FeatureFlag, AllowedFeatureFlagTypes>; } satisfies Record<FeatureFlag, AllowedFeatureFlagTypes>;
export type DefaultFeatureFlagValueType = typeof DefaultFeatureFlagValue; export type DefaultFeatureFlagValueType = typeof DefaultFeatureFlagValue;