1
0
mirror of https://github.com/bitwarden/browser synced 2026-01-27 23:03:45 +00:00

PM-29919 resolved pr comments

This commit is contained in:
Ben McFerren
2026-01-20 18:25:33 -05:00
parent 377154b461
commit f7deef102d
2 changed files with 4 additions and 8 deletions

View File

@@ -100,7 +100,7 @@ describe("SendDetailsComponent", () => {
expect(component).toBeTruthy();
});
it("should initialize authType to null if no password or emails", () => {
it("should initialize authType to None if no password or emails", () => {
expect(component.sendDetailsForm.value.authType).toBe(AuthType.None);
});

View File

@@ -204,7 +204,7 @@ export class SendDetailsComponent implements OnInit {
.split(",")
.map((e) => e.trim())
.filter((e) => e.length > 0)
: [],
: null,
} as unknown as SendView);
});
});
@@ -245,12 +245,8 @@ export class SendDetailsComponent implements OnInit {
name: this.originalSendView.name,
selectedDeletionDatePreset: this.originalSendView.deletionDate.toString(),
password: this.hasPassword ? "************" : null,
authType: this.hasPassword
? AuthType.Password
: this.originalSendView.emails?.length > 0
? AuthType.Email
: AuthType.None,
emails: this.originalSendView.emails?.join(", "),
authType: this.originalSendView.authType,
emails: this.originalSendView.emails?.join(", ") ?? null,
});
if (this.hasPassword) {