1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 00:33:44 +00:00

Date time fallback fixes (#292)

* tightened up the Send datetime fallback conditionals

* cleaned up
This commit is contained in:
Addison Beck
2021-03-02 17:00:07 -05:00
committed by GitHub
parent 36089fd68f
commit f836629b48

View File

@@ -39,7 +39,7 @@ export class AddEditComponent implements OnInit {
deletionDate: string;
deletionDateFallback: string;
deletionTimeFallback: string;
expirationDate: string;
expirationDate: string = null;
expirationDateFallback: string;
expirationTimeFallback: string;
hasPassword: boolean;
@@ -156,11 +156,16 @@ export class AddEditComponent implements OnInit {
// Parse dates
if (!this.isDateTimeLocalSupported) {
const deletionDateParts = this.dateToSplitString(this.send.deletionDate);
this.deletionDateFallback = deletionDateParts[0];
this.deletionTimeFallback = deletionDateParts[1];
if (deletionDateParts !== undefined && deletionDateParts.length > 0) {
this.deletionDateFallback = deletionDateParts[0];
this.deletionTimeFallback = deletionDateParts[1];
}
const expirationDateParts = this.dateToSplitString(this.send.expirationDate);
this.expirationDateFallback = expirationDateParts[0];
this.expirationTimeFallback = expirationDateParts[1];
if (expirationDateParts !== undefined && expirationDateParts.length > 0) {
this.expirationDateFallback = expirationDateParts[0];
this.expirationTimeFallback = expirationDateParts[1];
}
} else {
this.deletionDate = this.dateToString(this.send.deletionDate);
this.expirationDate = this.dateToString(this.send.expirationDate);
@@ -168,12 +173,11 @@ export class AddEditComponent implements OnInit {
}
async submit(): Promise<boolean> {
if (!this.isDateTimeLocalSupported && this.expirationDateTimeFallback !== null) {
this.expirationDate = this.expirationDateTimeFallback;
}
if (!this.isDateTimeLocalSupported && this.deletionDateTimeFallback !== null) {
if (!this.isDateTimeLocalSupported) {
this.deletionDate = this.deletionDateTimeFallback;
if ((this.editMode && this.expirationDateFallback != null) || this.expirationDateSelect === 0) {
this.expirationDate = this.expirationDateTimeFallback;
}
}
if (this.disableSend) {