1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Commit Graph

5976 Commits

Author SHA1 Message Date
John Harrington
9719210a59 replace swift logic with objc 2025-11-25 15:19:45 -07:00
Jordan Aasen
94327b8caa [PM-28817] - update copy for vault premium spotlight (#17667)
* update copy for vault premium spotlight

* remove unecessary observable

* fix logic
2025-11-25 13:59:09 -08:00
Thomas Rittson
63812009d7 [PM-25913] Fix owners unable to rename provider-managed organization (#17482)
Update to match new API: send null properties
for organization properties that are unchanged
2025-11-26 07:37:18 +10:00
Nick Krantz
273f04c6a3 [PM-26513] Desktop Archive Upgrade (#16964)
* always shows desktop archive filter regardless of the users premium status

* include spec files in tsconfig

* add upgrade path for desktop

* combine duplicate class instances

* remove optional chaining

* update tests to avoid null assertions

* add test files to the spec tsconfig

* implement signal for premium badge component

* remove badge template reference
2025-11-25 15:12:20 -06:00
John Harrington
5625efbdf7 Merge branch 'main' into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build 2025-11-25 13:25:15 -07:00
renovate[bot]
854f2abd28 [deps] Autofill: Update tldts to v7.0.18 (#17452)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-25 19:49:25 +01:00
Daniel Riera
3de3bee08f [PM-27821]Add validation of extension origin for uses of window.postMessage (#17476)
* PM-27821 - Replace chrome.runtime.getURL() with BrowserApi.getRuntimeURL() for consistency
- Add extension origin validation for all window.postMessage calls
- Implement token-based authentication for inline menu communications
- Add message source validation (event.source === globalThis.parent)
- Add command presence validation (- Update notification bar to validate message origins and commands
- Add extensionOrigin property to services using postMessage
- Generate session tokens for inline menu containers (32-char random)
- Validate tokens in message handlers to prevent unauthorized commands

* Add explicit token validation

* only set when receiving the trusted initNotificationBar message

* await windowmessageorigin before posting to parent

* fix tests

* the parent must include its origin in the message for notification bar race condition

* reduce if statements to one block and comment

* extract parentOrigin from the URL and set windoMessageOrigin accordingly

* consolidate if statements

* add bar.spec file

* fix merge conflict
2025-11-25 13:42:46 -05:00
Jordan Aasen
eae894123d [PM-28376] - update copy for autofill confirmation dialog url list expand button (#17594)
* update copy for autofill confirmation dialog url list expand button

* fix tests
2025-11-25 10:33:21 -08:00
Nick Krantz
441783627b [PM-26359] Archive Upgrade - Browser (#16904)
* add archive upgrade flow to more options menu

* add reprompt for archiving a cipher

* add premium badge for archive in settings

* update showArchive to only look at the feature flag

* add premium badge for browser settings

* add event to prompt for premium

* formatting

* update test
2025-11-25 11:28:34 -06:00
Dave
cf6569bfea feat(user-decryption-options) [PM-26413]: Remove ActiveUserState from UserDecryptionOptionsService (#16894)
* feat(user-decryption-options) [PM-26413]: Update UserDecryptionOptionsService and tests to use UserId-only APIs.

* feat(user-decryption-options) [PM-26413]: Update InternalUserDecryptionOptionsService call sites to use UserId-only API.

* feat(user-decryption-options) [PM-26413] Update userDecryptionOptions$ call sites to use the UserId-only API.

* feat(user-decryption-options) [PM-26413]: Update additional call sites.

* feat(user-decryption-options) [PM-26413]: Update dependencies and an additional call site.

* feat(user-verification-service) [PM-26413]: Replace where allowed by unrestricted imports invocation of UserVerificationService.hasMasterPassword (deprecated) with UserDecryptionOptions.hasMasterPasswordById$. Additional work to complete as tech debt tracked in PM-27009.

* feat(user-decryption-options) [PM-26413]: Update for non-null strict adherence.

* feat(user-decryption-options) [PM-26413]: Update type safety and defensive returns.

* chore(user-decryption-options) [PM-26413]: Comment cleanup.

* feat(user-decryption-options) [PM-26413]: Update tests.

* feat(user-decryption-options) [PM-26413]: Standardize null-checking on active account id for new API consumption.

* feat(vault-timeout-settings-service) [PM-26413]: Add test cases to illustrate null active account from AccountService.

* fix(fido2-user-verification-service-spec) [PM-26413]: Update test harness to use FakeAccountService.

* fix(downstream-components) [PM-26413]: Prefer use of the getUserId operator in all authenticated contexts for user id provided to UserDecryptionOptionsService.

---------

Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>
2025-11-25 11:23:22 -05:00
Ben Brooks
c04c1757ea Revert "Lets shadow DOM check signal page update (#16114)" (commit 6129ca5366) (#17503)
Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
2025-11-25 08:06:03 -08:00
Bryan Cunningham
540da69daf [CL-761] Enable strict template typechecking (#17334)
* enable strict template typechecking

* add callout component to module

* fixing popup action types

* fixing cipher item copy types

* fix archive cipher type

* fixing trash list items types

* fix remaining trash list item type errors

* use CipherViewLike as correct type

* change popup back directive to attribute selector

* allow undefined in popupBackAction handler

* Remove undefined from type

* fix error with firefox commercial build

---------

Co-authored-by: Vicki League <vleague@bitwarden.com>
2025-11-25 11:04:37 -05:00
John Harrington
7e11c22779 Merge branch 'main' into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build 2025-11-25 07:57:16 -07:00
Nick Krantz
cdd8a697e8 do not show copy password button on the web for users that do not have access (#17635) 2025-11-25 08:41:41 -06:00
Oscar Hinton
e6d6f8d266 Migrate org reports to standalone and remove from loose components (#15791) 2025-11-25 11:11:21 +01:00
Jordan Aasen
43fd99b002 [PM-24722][PM-27695] - add persistent callout in settings for non-premium users (#17246)
* add persistent callout in settings for non-premium users

* remove premium v2 component

* add spec

* remove premium-v2.component.html

* fix title

* fix typo

* conditionally render h2

* re-add pemiumv2component. change class prop to observable

* change from bold to semibold

* remove unecessary tw classes. use transform: booleanAttribute

* add spotlight specs

* code cleanup
2025-11-24 13:49:05 -08:00
blackwood
883ff8968e Allows limited internal message posting when host experience content is controlled (#17313) 2025-11-24 14:08:11 -05:00
Oscar Hinton
4c36a46ef2 Enable directive-class-suffix (#17385) 2025-11-24 18:03:16 +01:00
Leslie Tilton
5779df2417 Correct phishing blocker file structure (#17477) 2025-11-24 10:46:28 -06:00
renovate[bot]
3a4eec38a1 [deps] Platform: Update Rust crate arboard to v3.6.1 (#17547)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-11-24 15:38:40 +00:00
Andreas Coroiu
7e32d0a59f [PM-27564] Self-host configuration is not applied with nx build (#17279)
* fix: web not using env variables

* fix: apply claude suggestion

* fix: remove non-working serve targets
2025-11-24 16:36:23 +01:00
Bernd Schoolmann
13940a74ae Fix biometrics unlock when pin is enabled (#17528) 2025-11-22 11:53:45 +01:00
John Harrington
7a25b40255 Merge branch 'main' into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build 2025-11-21 14:02:45 -07:00
neuronull
489eb40057 Desktop Autotype fix IPC error handling (#17332)
* Desktop Autotype fix IPC error handling

* TS lint

* sweep sweep: fix unecessary member name qualifier
2025-11-21 14:02:22 -07:00
Todd Martin
23ac477bbc chore(feature-flag): Removed pm-28325-remove-pm-22110-disable-alternate-login-methods flag 2025-11-21 16:01:41 -05:00
Nick Krantz
aa2d263751 [PM-24505] Manually open extension error message (#17116)
* update manual open message to be more generic to cover more scenarios

* update error state when attempting to open the extension via button press
2025-11-21 14:48:50 -06:00
John Harrington
f900acf0c5 re-run cargo fmt after fixing clippy lints 2025-11-21 13:37:01 -07:00
John Harrington
9fbf45e7a5 fix more clippy lints not caught locally 2025-11-21 13:29:58 -07:00
John Harrington
abf8991a90 remove unused dep 2025-11-21 12:57:15 -07:00
renovate[bot]
129c21cfb8 [deps] Vault: Update koa to v2.16.3 [SECURITY] (#17514)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-21 13:23:51 -05:00
Daniel Riera
279632d65f [PM-28516] Inline menu is not working in main (#17524)
* PM-28516 alidate iframe and stylesheet URLs against their own origins to handle
cases where chrome assigns different extension ids in different contexts

* switch to regex to match exisiting match pattern

* updated regex to account for safari
2025-11-21 17:10:03 +00:00
John Harrington
f14a6f4501 fix another clippy warning 2025-11-21 09:16:16 -07:00
John Harrington
46d24d33d9 cargo clippy 2025-11-21 08:56:20 -07:00
John Harrington
be9452530d pass args directly in objc/build.rs 2025-11-21 08:40:37 -07:00
Dave
daf7b7d2ce fix(two-factor) [PM-21204]: Users without premium cannot disable premium 2FA (#17134)
* refactor(two-factor-service) [PM-21204]: Stub API methods in TwoFactorService (domain).

* refactor(two-factor-service) [PM-21204]: Build out stubs and add documentation.

* refactor(two-factor-service) [PM-21204]: Update TwoFactorApiService call sites to use TwoFactorService.

* refactor(two-fatcor) [PM-21204]: Remove deprecated and unused formPromise methods.

* refactor(two-factor) [PM-21204]: Move 2FA-supporting services into common/auth/two-factor feature namespace.

* refactor(two-factor) [PM-21204]: Update imports for service/init containers.

* feat(two-factor) [PM-21204]: Add a disabling flow for Premium 2FA when enabled on a non-Premium account.

* fix(two-factor-service) [PM-21204]: Fix type-safety of module constants.

* fix(multiple) [PM-21204]: Prettier.

* fix(user-verification-dialog) [PM-21204]: Remove bodyText configuration for this use.

* fix(user-verification-dialog) [PM-21204]: Improve the error message displayed to the user.
2025-11-21 10:35:34 -05:00
John Harrington
60eb309fba avoid unwrap 2025-11-21 08:32:37 -07:00
John Harrington
61ace267f0 cargo fmt 2025-11-21 08:19:50 -07:00
John Harrington
f55e6992da add dep to desktop_native cargo.toml 2025-11-21 08:14:51 -07:00
John Harrington
5fc55c86a0 Merge branch 'PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build' of github.com:bitwarden/clients into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build
merge conflict resolution
2025-11-21 08:13:34 -07:00
John Harrington
4be25d9290 remove additional debug output and revert popup-modal-style to match main 2025-11-21 08:12:34 -07:00
John Harrington
245171e999 Merge branch 'main' into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build 2025-11-21 08:10:27 -07:00
John Harrington
83c01ba9bf added docs and removed debug output 2025-11-21 07:56:10 -07:00
renovate[bot]
e9f67f4fd6 [deps]: Update Rust crate cc to v1.2.46 (#17571)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2025-11-21 13:57:31 +01:00
renovate[bot]
87e49c174c [deps] Platform: Update Rust crate libc to v0.2.177 (#17549)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2025-11-21 13:56:54 +01:00
renovate[bot]
f6eb0f642e [deps]: Update Rust crate clap to v4.5.51 (#17572)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-21 11:52:51 +01:00
renovate[bot]
678e5193ca [deps]: Update Rust crate async-trait to v0.1.89 (#17570)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-21 11:32:36 +01:00
bw-ghapp[bot]
bc7825654b Autosync the updated translations (#17531)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-11-21 09:45:19 +01:00
bw-ghapp[bot]
5ff6e50e1d Autosync the updated translations (#17530)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-11-21 09:40:12 +01:00
bw-ghapp[bot]
8077270ef8 Autosync the updated translations (#17529)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-11-21 09:39:50 +01:00
Addison Beck
ba93526965 chore: create eslint rule to catch insecure page script injection (#17437)
* chore: create eslint rule to catch insecure page script injection

* chore: ignore existing lints

* review: tighten rule scope

* review: add tests
2025-11-20 19:45:49 -05:00