bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-11 22:13:32 +00:00
Code Issues Releases Wiki Activity
17,088 Commits 1,322 Branches 581 Tags
308bbdad02f27f327d53dc7458476874cb6b8fd2
Commit Graph

17088 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bernd Schoolmann
308bbdad02 Merge remote-tracking branch 'origin/km/browser-integration-supported-platform-check' into km/tmp-biometrics-fixed 2025-01-10 13:12:05 +01:00
Bernd Schoolmann
b4d024208a Merge branch 'km/fix-biometrics-browser-prompt' into km/tmp-biometrics-fixed 2025-01-10 13:11:01 +01:00
Maciej Zieniuk
df39db6a06 in desktop "Allow browser integration" button fails on dev environment, but should pass fine. 2025-01-10 00:27:41 +00:00
Bernd Schoolmann
f66e1a345a Fix biometrics being disabled before permission is granted 2025-01-10 00:25:51 +01:00
Bernd Schoolmann
2439e23e94 Fix tests 2025-01-09 22:18:52 +01:00
Bernd Schoolmann
8cabb36c99 [PM-16699] Add decrypt trace for decrypt failures (#12749) 
* Improve decrypt failure logging

* Rename decryptcontext to decrypttrace

* Improve docs

* Revert changes to decrypt logic

* Revert keyservice decryption logic change

* Undo one more change to decrypt logic
 2025-01-09 20:23:55 +01:00
Jared Snider
bb8e649048 Auth/PM-16896 - Device Management - Remove 3 dot menu and remove text from table description (#12787) 
* PM-16896 - Remove 3 dot menu and remove text from table description

* PM-16896 - Add requested comment
 2025-01-09 14:14:42 -05:00
Thomas Avery
8cfa30acb5 [PM-16889] Add KM lib to tailwind configs (#12783) 
Add KM lib to tailwind configs
 2025-01-09 13:07:26 -06:00
Jordan Aasen
2271062a5a clear cipher cache after deleting a collection (#12686) 2025-01-09 10:38:27 -08:00
Bernd Schoolmann
d10baf8fde Fix biometrics button showing up when biometrics is not enabled 2025-01-09 19:28:45 +01:00
1fexd
a872f67523 fix: Don't try to load icon for .onion/.i2p URIs (#9125) 
Co-authored-by: Bernd Schoolmann <mail@quexten.com>
Co-authored-by: Jason Ng <jng@bitwarden.com>
 2025-01-09 13:23:17 -05:00
✨ Audrey ✨
f1c3c690a7 remove circular dependency from @bitwarden/generator-core (#12785) 2025-01-09 13:18:45 -05:00
SmithThe4th
14568f11dc [PM-12034] Remove usage of ActiveUserState from vault-banners.service (#11543) 
* Migrated banner service from using active user state

* Fixed unit tests for the vault banner service

* Updated component to pass user id required by the banner service

* Updated component tests

* Added comments

* Fixed unit tests

* Updated vault banner service to use lastSync$ version and removed polling

* Updated to use UserDecryptionOptions

* Updated to use getKdfConfig$

* Updated shouldShowVerifyEmailBanner to use account observable

* Added takewhile operator to only make calls when userId is present

* Simplified to use sing userId

* Simplified to use sing userId
 2025-01-09 13:12:08 -05:00
Jordan Aasen
06ca00f3c1 [PM-13306] - add missing elements to browser vault trash list (#12736) 
* add missing elements to trash list

* fix failing test
 2025-01-09 09:40:59 -08:00
Jordan Aasen
8fe1802963 add missing provider in premium-badge story (#12766) 2025-01-09 09:27:52 -08:00
Bernd Schoolmann
c451f500f9 Cleanup destkop native loader and support gnu fallback loading (#12498) 2025-01-09 18:15:58 +01:00
Jared McCannon
3550a904dc [PM-13764] - Update Collection Settings (#12734) 
* Updating org when collection settings change.
 2025-01-09 10:32:21 -06:00
Bernd Schoolmann
20c8eda986 Fix ssh agent initializiation (#12779) 2025-01-09 16:37:16 +01:00
Michał Chęciński
1a80ae8968 [BRE-513] Remove brew bump desktop workflow (#12772) 2025-01-09 16:10:28 +01:00
Bernd Schoolmann
11a7eb2f73 [PM-16612] Prevent emergency access fingerprint confirmation dialog being spoofable (#12651) 
* Prevent emergency access dialog spoofing

* Fix tests
 2025-01-09 16:06:14 +01:00
Brandon Treston
1b64bc2462 Fix invite member dialog remaining count (#12667) 2025-01-09 09:58:45 -05:00
Bernd Schoolmann
a527aa9196 [PM-2094] Fix windows hello focusing behavior (#12255) 
* Implement new windows focus behavior

* Fix formatting

* Fix clippy warning

* Fix clippy warning

* Fix build

* Fix build
 2025-01-09 14:07:40 +01:00
Bernd Schoolmann
67a59b6072 [PM-15584] Fix autoprompt safari process reload (#12352) 
* Move ownership of biometrics to key-management

* Move biometrics ipc ownership to km

* Move further files to km; split off preload / ipc to km

* Fix linting

* Fix linting

* Fix tests

* Extract biometric messaging service

* Fix tests

* Update .github/CODEOWNERS

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Change ownership of native messaging to key-management

* Initial refactor

* Initial refactor

* Continued refactor

* Continued refactor

* Add message for when biometric unlock is not configured in desktop app

* Clean up lock component

* Clean up lock component html

* Fix build

* Fix status for windows and linux

* Continue refactor

* Refactor browser

* Fix unlock on extensions and add message enums

* Implement safari and fix setup

* Fix cli and web

* Make tests pass

* Add backward compatibility

* Fix version incompatibility

* Clean up auto-bio-prompt on desktop

* Fix biometric auto prompt on browser

* Fix tests

* Remove logging

* Add null in return type of unlockwithbiometricsforuser

* Move biometrics to libs/key-management

* Add README to capital whitelist

* Update package-lock.json

* Move km to key-management

* Move km to key-management

* Fix build for cli

* Import fixes

* Apply prettier fix

* Fix test

* Import fixes

* Import fixes

* Update libs/key-management/README.md

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Update libs/key-management/package.json

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Update lock file

* Change imports to top level km package

* Change import order

* Fix cli build

* Remove debug logging

* Fix user not showing in "notenabledinconnecteddesktopapp" helptext

* Document autoprompt and enable it on manual account switch

* Fix build

* Fix unlock on windows

* Rename duckduckgo message handler service

* Fix merge conflicts

* Fix codeowners

* Fix biometric message handler naming

* Update codeowners for renamed message handler service

* Fix cli build error

* Fix browser build errors

* Fix tests and update lock components

* Fix linking

* Fix build error

* Fix build error

* Fix build error

* Fix build error

* Fix logging message

* Fix conflicts

* Add jsdoc to biometric status enum

* Add jsdoc to biometric commands

* Remove unused initialization code

* Fix incorrectly checked setup-required status in desktop settings component

* Extract process reload when required

* Remvoe cryptoservice reference

* Remove commented out tests

* Improve tests

* Fix build

* Fix tests

* Fix biometric unlock

* Fix errors from prior merge

* Re-add tests

* Update lock component tests

* Add tests for process reload for biometric ipc unlock

* Fix autoprompt happening when it should not

* Fix lock v2

* Fix lint

* Update apps/browser/src/auth/popup/settings/account-security.component.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update apps/desktop/src/app/accounts/settings.component.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update apps/desktop/src/key-management/biometrics/main-biometrics.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/key-management/src/biometrics/biometric.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/key-management/src/biometrics/biometrics-status.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update apps/browser/src/background/nativeMessaging.background.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update apps/desktop/src/key-management/biometrics/main-biometrics.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Cleanup

* Remove unavailabilityReason from UI

* Fix autoprompt safari process reload

* Apply changes according to feedback

* Adjust PR according to feedback

* Address feedback

* Fix account settings biometrics setting

* Fix build

* Cleanup

* Fix incorrect merge

* Allow disabling biometrics in browser while desktop app is disconnected

---------

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
 2025-01-09 13:01:49 +01:00
Jonas Hendrickx
aec25b1491 [PM-15840] When org reaches collection limit, organization upgrade pa… (#12648) 2025-01-09 07:53:29 +00:00
Addison Beck
5c96634974 fix(ci): Adjust variable name missed during lint update (#12768) 2025-01-09 04:37:26 +00:00
Jordan Aasen
a3e876eb8f fixed icon width (#12721) 2025-01-08 16:19:51 -08:00
Bernd Schoolmann
0d5e4c6f58 [PM-16859] Fix item creation resetting to login item type on browser (#12765) 
* Fix broken item creation on browser

* Fix creation of ssh keys items from a filtered vault resetting to login on web
 2025-01-08 23:24:23 +00:00
Thomas Avery
bb61b3df3a [PM-15940] Add regen to SSO login (#12643) 
* Add loginSuccessHandlerService to SSO login component

* Update regen service to handle SSO login
 2025-01-08 16:41:02 -06:00
Todd Martin
d9e65aca14 Remove lock and logout settings from Safari Account Settings (#12699) 2025-01-08 15:34:16 -05:00
tangowithfoxtrot
16a0176f84 fix: account for different build output on arm (#12761) 2025-01-08 10:53:57 -08:00
Addison Beck
a9ca361523 fix(ci): Adjust for a breaking change in the Slack action (#12753) 2025-01-08 18:47:45 +00:00
Oscar Hinton
48f99099b2 [PM-16845] Lint unowned dependencies (#12748) 
* Lint unowned dependencies

* Split npm ci and run linter

* Set explicit versions for unchanged parts of the workflow ....

* Rename yao-pkg

* Add owners for sdk-internal, fuses and angular-eslint/schematics

* Assign owners for angular and storybook

* Add typescript-strict-plugin

* Add two more unowned dependencies

---------

Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com>
Co-authored-by: Addison Beck <github@addisonbeck.com>
 2025-01-08 13:37:08 -05:00
Jordan Aasen
38c1cdfb62 [PM-14289] - vault cipher form - set default owner as organization from collection when possible (#12682) 
* set default org by referencing collecction

* get organizationId from collection

* always get organizationId from collection when possible
 2025-01-08 10:36:38 -08:00
Addison Beck
4d576f0533 fix(ci): Resolve errors and warnings exposed by new workflow linter (#12755) 
* fix(ci): Resolve errors and warnings exposed by new workflow linter

* Add missed warning
 2025-01-08 13:06:19 -05:00
Shane Melton
d72dd2ea76 [PM-16098] Improved cipher decryption error handling (#12468) 
* [PM-16098] Add decryptionFailure flag to CipherView

* [PM-16098] Add failedToDecryptCiphers$ observable to CipherService

* [PM-16098] Introduce decryption-failure-dialog.component

* [PM-16098] Disable cipher rows for the Web Vault

* [PM-16098] Show decryption error dialog on vault load or when attempting to view/edit a corrupted cipher

* [PM-16098] Browser - Show decryption error dialog on vault load or when attempting to view/edit a corrupted cipher

* [PM-16098] Desktop - Show decryption error dialog on vault load or when attempting to view a corrupted cipher. Remove edit/clone context menu options and footer actions.

* [PM-16098] Add CS link to decryption failure dialog

* [PM-16098] Return cipherViews and move filtering of isDeleted to consumers

* [PM-16098] Throw an error when retrieving cipher data for key rotation when a decryption failure is present

* [PM-16098] Properly filter out deleted, corrupted ciphers when showing dialog within the Vault

* [PM-16098] Show the decryption error dialog when attempting to view a cipher in trash and disable the restore option

* [PM-16098] Exclude failed to decrypt ciphers from getAllDecrypted method and cipherViews$ observable

* [PM-16098] Avoid re-sorting remainingCiphers$ as it was redundant

* [PM-16098] Update tests

* [PM-16098] Prevent opening view dialog in AC for corrupted ciphers

* [PM-16098] Remove withLatestFrom operator that was causing race conditions when navigating away from the individual vault

* [PM-16098] Ensure decryption error dialog is only shown once on Desktop when switching accounts
 2025-01-08 08:42:46 -08:00
Tom
65a27e7bfd At risk member count fix (#12733) 2025-01-08 10:35:30 -05:00
Jonathan Prusik
d864dc2e16 assign Autofill team ownership of lit and @emotion/css packages (#12750) 2025-01-08 10:19:18 -05:00
Tom
8bb080cf93 Removing testing tabs and the learn more link (#12481) 2025-01-08 16:09:05 +01:00
Bernd Schoolmann
bb2961f4ca [PM-10413] ssh keygen on web and browser (#12176) 
* Move desktop to sdk ssh-key generation

* Add ssh keygen support on web and browser

* Move ssh keygen on all clients behind feature flag

* Update package lock

* Fix linting

* Fix build

* Fix build

* Remove rand_chacha

* Move libc to linux-only target

* Remove async-streams dep

* Make generateSshKey private

* Remove async from generate ssh key

* Update cargo lock

* Fix sdk init for ssh key generation

* Update index.d.ts

* Fix build on browser

* Fix build

* Fix build by updating libc dependency
 2025-01-08 16:01:23 +01:00
Oscar Hinton
3949aae8e3 [PM-16838] Fix bad imports for shared and platform code (#12743) 
Imports containing /src/ are forbidden.
 2025-01-08 14:29:26 +01:00
Bernd Schoolmann
244539cc38 [PM-16837] Fix agent only loading when featureflag is on during startup (#12742) 
* Fix ssh generation and import not being available when agent feature-flag is disabled

* Fix agent only loading when featureflag is on during startup
 2025-01-08 14:25:19 +01:00
Bernd Schoolmann
1b08335245 Fix ssh generation and import not being available when agent feature-flag is disabled (#12741) 2025-01-08 14:08:52 +01:00
Bernd Schoolmann
72121cda94 [PM-10741] Refactor biometrics interface & add dynamic status (#10973) 2025-01-08 10:46:00 +01:00
Evan Bassler
0bd988dac8 [PM-15190] hide empty ciphers from autofill (#12491) 
* hide empty ciphers from autofill

---------

Co-authored-by: Evan Bassler <evanbassler@EvanBasslersMBP.attlocal.net>
 2025-01-07 17:07:30 -06:00
Jimmy Vo
d422e85310 [14415] Extend VS Code extensions. (#12604) 
Add extensions that we believe will be useful for working in this repository to the Visual Studio recommended extensions list to make them more discoverable.
 2025-01-07 15:46:03 -05:00
Jason Ng
5cb31f37e9 [PM-16824] update new device verification notice page one so learn more link opens in browser from desktop (#12731) 2025-01-07 15:10:42 -05:00
Jonathan Prusik
dbed5ff79b [PM-16247] Autofill base common content components (#12668) 
* PoC implementation

* build notification header components

* use emotion css, and add button row components

* add icons

* update close button component to use new icon

* add cipher components

* reorganize notification component to accomodate body overflow with static footer

* add action row component and fix overflow cases

* fix component directory casings

* add scrollbar styles

* fix edit button icon display size issue

* fix edit button interaction

* cleanup and add dropdown menu buttons

* fix footer display of full-width children

* use svg brand icon in header component

* refine body and footer overflow layout handling

* fix fallback cipher icon sizing and other cleanup

* component restructure and cleanup

* restructure icon components

* cleanup

* re-org notification body and footer components and add typing

* additional cleanup
 2025-01-07 15:09:43 -05:00
Alec Rippberger
f99a3c4162 feat(web): [PM-1214] add device management screen 
Adds a device management tab under settings -> security that allows users to:
- View and manage their account's connected devices
- Remove/deactivate devices
- See device details like platform, last login, and trust status
- Sort and filter device list with virtual scrolling

Resolves PM-1214
 2025-01-07 13:29:36 -06:00
cyprain-okeke
02556c1416 Changes to restart cancelled org (#12730) 2025-01-07 20:09:37 +01:00
Jonathan Prusik
966e8d3fb8 [PM-16667] Followup clarifying work (#12665) 
* clean up readability

* fix ts-strict violations

* fix consistency with uncertain cases in isCardExpired
 2025-01-07 13:48:18 -05:00