1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-12 22:44:11 +00:00
Commit Graph

16667 Commits

Author SHA1 Message Date
Matt Gibson
42ebc23fd3 Add optional aad for aes gcm mode decryption
This is used in key connector communication tunneling to prevent downgrade attacks in the future
2024-11-18 14:47:01 -08:00
Matt Gibson
8ccf0b77ac Include aes gcm encryption
key connector will always provide the asym keys and the clients will encapsulate a key and encrypt communications with it.
2024-11-18 14:09:25 -08:00
Matt Gibson
6a7c05ae12 Prefer key encapsulation to shared key derivation 2024-11-18 10:25:09 -08:00
Matt Gibson
a59512daa9 Add necessary gcm decryption to encryptService
This is not added as an EncString and SymmetricCryptoKey because this is part of the transport layer, not vault encryption.

TODO: This still probably needs better typing.
2024-11-14 16:58:03 -08:00
Matt Gibson
b036c0ce16 Add diffie-hellman and aes-gcm cryptography
We're planning on using x25519 encapsulating an aes-256-gcm key.
2024-11-14 16:57:57 -08:00
Brandon Treston
5c540a86f4 [PM-13829] Add organizationId to isAdmin check, refactor isAdmin to getter (#11997)
* Add organizationId to isAdmin check, refactor isAdmin to getter for restore and delete

* add comment
2024-11-14 17:17:40 -05:00
✨ Audrey ✨
48294aac86 invert ambiguous character flag (#12004) 2024-11-14 15:55:19 -05:00
Daniel James Smith
73632cd368 [PM-12598] Create dedicated importer for Password-XP (csv) (#11751)
* Create dedicated password-xp csv importer

* Add support for importing unmapped columns as custom fields

* Add support for importing folders and assiging items to them

* On import into an organization, convert folders to collections

* Register importer within importService and make it selectable via the UI

Add instructions on how to export from Password XP

* Mark method as private

* Add docs

* Add comment around folder detection

* Move test data into separate file

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-14 21:28:55 +01:00
Nick Krantz
d4a381e1bd [PM-14653] PM/AC Delete Cipher (#11996)
* check for admin console for unassigned ciphers

* use `isUnassigned` helper

* remove unneeded comment
2024-11-14 14:22:17 -06:00
Jordan Aasen
b0c5b5e9e6 [PM-14567] - fix routes. update copy and headers (#11908)
* fix routes. update copy and headers

* Patch build process

* Revert "Patch build process"

This reverts commit 4d3716d375.

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
Co-authored-by: Tom <144813356+ttalty@users.noreply.github.com>
2024-11-14 14:38:10 -05:00
Bernd Schoolmann
76105aa275 Fix double prompt when unlocking by ssh request (#12000) 2024-11-14 19:56:39 +01:00
Evan Bassler
c1302a3604 reorder address field identification (#11824)
Co-authored-by: Evan Bassler <evanbassler@Evans-MBP.attlocal.net>
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-14 13:29:30 -05:00
Jonas Hendrickx
a4156799e9 [PM-13783] Battle harden ProviderType enum expansion (#11920) 2024-11-14 17:46:02 +01:00
Daniel García
d0f24dc41f Improve desktop IPC logging (#11864)
* Improve desktop IPC logging

* Log error

* Force file to only log info, like the desktop app does

* use ?
2024-11-14 17:45:19 +01:00
Oscar Hinton
ef127fd26e Ensure we await for the wasm module to load (#11995)
Webpack seems to always convert imports to be async. This causes a issue where
init_sdk is not always initialized before we call it. To resolve this I added
a promise we can await in MV3 mode, and also defined a timeout which throws an
error we can use to identify if we have issues loading the module.
2024-11-14 17:29:56 +01:00
Github Actions
5da5c886ea Bumped client version(s) 2024-11-14 16:13:41 +00:00
cd-bitwarden
a1ad3383f7 [PM-13894] updating the text area for notes to have 5 rows (#11976)
* updating the text area for notes to have 5 rows

* Applying the row count to the edit page as well

---------

Co-authored-by: --global <>
2024-11-14 16:06:57 +00:00
Rui Tomé
e6fce421f5 [PM-10324] Add bulk delete option for organization members (#11892)
* Refactor organization user API service to support bulk deletion of users

* Add copy for bulk user delete dialog

* Add bulk user delete dialog component

* Add bulk user delete functionality to members component

* Refactor members component to only display bulk user deletion option if the Account Deprovisioning flag is enabled

* Patch build process

* Revert "Patch build process"

This reverts commit 917c969f00.

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-14 15:49:16 +00:00
✨ Audrey ✨
642b8d2e6b [PM-14838] upgrade generator account storage to ObjectKey storage (#11975) 2024-11-14 10:09:59 -05:00
aj-bw
a08c9776cb PM-14914/ssh-key-item-type-filtering-web (#11990) 2024-11-14 10:05:43 -05:00
cyprain-okeke
2e6d98938a [PM-13868]Remove Upgrade password manager flag (#11789)
* Remove the feature flag

* Add the feature flag reference
2024-11-14 15:57:54 +01:00
Andreas Coroiu
b4aea05169 revert: recent changes to build-desktop.yml and entitlements (#11991)
* Revert workflow changes in "[PM-9022] scaffold the extension and build pipeline (#9948)"

This reverts commit 62112b99a9.

* fix: comment out autofill entitlement
2024-11-14 11:42:10 +01:00
Brandon Treston
0cfe18ac4d [PM-13829] Add check for empty array when deleting unassigned items (#11927)
* add check for empty array

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-13 14:34:43 -05:00
Jonathan Prusik
3a293bbf1f [PM-12399] Show card and identity ciphers in the autofill suggestions only if the active tab appears to have fields for that type of cipher (#11913)
* show card and identity ciphers in the autofill suggestions only if the active tab appears to have fields for that type of cipher

* handle cases where collectPageDetailsFromTab$ does not emit

* update tests
2024-11-13 14:08:32 -05:00
rr-bw
204eb3105b update anon-layout and extension-anon-layout spacing (#11869) 2024-11-13 10:17:23 -08:00
rr-bw
7ef1d01401 [PM-13822] Password Hint UI tweaks (#11867)
* update env selector label

* update icon colors

* re-upload SVG with viewBox and correct classes
2024-11-13 09:46:58 -08:00
Nick Krantz
251213b69c remove check for SHOW_AUTOFILL_BUTTON (#11971) 2024-11-13 10:58:34 -06:00
Bernd Schoolmann
a75c2118ec [PM-14850] Flatpak development & qa artifacts (#11925)
* Add flatpak development manifest

* Undo removal of libsecret

* Update .github/workflows/build-desktop.yml

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>

---------

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
2024-11-13 17:41:47 +01:00
Jordan Aasen
0b11596f08 [PM-14813] - Implement server API to user member cipher details instead of mock data (#11978)
* use cipher details data

* fix failing tests

* fix failing tests
2024-11-13 11:37:29 -05:00
Kyle Spearrin
379efb1326 Update the publisher name for Bitwarden (#11846) 2024-11-13 11:05:19 -05:00
Michał Chęciński
63a71981fb Fix github token generating in repository-management.yml workflow (#11983)
* Skip token revoke in repository-management.yml workflow

* GEt gh token in every job
2024-11-13 16:58:43 +01:00
Vince Grassia
334b82764c Change Docker image tag logic to support pull_request_target trigger (#11984) 2024-11-13 16:19:38 +01:00
Andreas Coroiu
62112b99a9 [PM-9022] scaffold the extension and build pipeline (#9948)
* feat: add macos xcode project

* feat: add extension to mas build

* feat: use `after-sign` to avoid issues

Electron builder modifies the .plist in the extension which causes issues with the signing process. Copying and re-signing manually avoids this because it bypasses the electron builder for the extension

* feat: always clean build and add better error handling

* chore: add some logging to after-sign

* feat: automatically cleanup xcode build to avoid duplicate extensions

* docs: add information about managing extensions

* feat: add missing safari extension logging

* lint: allow macos filenames

* chore: add macos to platform ownership

* lint: add some additional allowed files

* feat: don't build autofill extension for MAS

* chore: ignore capital letters linting for all macos files

* chore: replace gulpfile with regular node script

* chore: add lint rules to script

* lint: fix remaining lint issues in script

* chore: tweak lint rule

* feat: remove desktop target

* fix: use new provisioning profile for dev extension

* Update to unblock CI builds

* chore: remove extension from masdev pack

This way we don't include the extension in any build and can avoid the signing issues it brings

* chore: add autofill as codeowner

* chore: remove xcuserdata

* chore: ignore xcuserdata

---------

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-13 15:54:35 +01:00
Daniel James Smith
e341a66a2e Add autofocus to search field on Send page (#11979)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-13 15:15:48 +01:00
Daniel James Smith
913f109ffa Fix totp import on Dashlane csv importer (#11747)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-13 15:11:53 +01:00
Alex Morask
88cbee9b0a Remove consolidated billing feature flag (#11969) 2024-11-13 09:01:22 -05:00
Bernd Schoolmann
3508b4631d Fix snap protocol handler (#11932)
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-13 08:06:57 -05:00
cyprain-okeke
24ca942cd6 [PM-14861]Vault items fail to load (#11974)
* Resolve the vault items fail to load

* Remove the hasSubscription

* Replace with hasSubscription from metadata

* Resolve the failing popup
2024-11-13 13:28:40 +01:00
Michał Chęciński
84b2b02f12 Bump browser version in package-lock.json (#11981) 2024-11-13 12:14:52 +00:00
Michał Chęciński
031a9bcae8 Bump browser version (#11980) 2024-11-13 12:02:34 +00:00
renovate[bot]
c49679207b [deps] Autofill: Update concurrently to v9.1.0 (#11949)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-12 15:03:53 -05:00
renovate[bot]
d40dedf2b3 [deps] Platform: Update @types/node to v22 (#11951)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-12 15:00:07 -05:00
Jared McCannon
e32bfce094 [PM-12479] Updating retrieval of groups (#11800)
* Renamed group service to group api service
* Updating models in various components.
* Updating internal service name. clean up.
---------
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-12 13:52:11 -06:00
Chandra Mauli Sharma
ea2f95e226 fix: Add new item should set item type (bitwarden#10994) (#11049)
Co-authored-by: cd-bitwarden <106776772+cd-bitwarden@users.noreply.github.com>
2024-11-12 14:37:44 -05:00
Jason Ng
9ec6f45803 [PM-8682] Add Flags for New Device Verification Notice (#11968) 2024-11-12 12:56:25 -05:00
SHASHI KUMAR KASTURI
aa04d84c11 [PM-14627] Import TOTP with ZohoVault CSV importer (#11912)
* totp secret is assigned to cipher object in zohovalut-csv-importer to populate when importing keys from zoho vault fixes #11872 closes #11872

* fixed issue#11872

* assigned full totp url to cipher object and also implemented unit tests for zohovault importer

* Add test to when no data is passed to the importer

* Fix import of folders

- Replace "Chambername" with "Folder Name"
- Add tests for importing folders and collections

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-11-12 18:47:25 +01:00
Jason Ng
40f2e15cec [PM-13895] Autofocus on Vault Search Browser (#11888)
* use appAutoFocus directive for browser vault v2 search
2024-11-12 10:38:48 -05:00
Daniel James Smith
ac0e008e3c [PM-8506] Create importer for csv-export from Netwrix Password Secure (#9446)
* Create an importer for csv-export from Netwrix Password Secure

* Wire the new importer into the clients

* Add instructions to export from Netwrix Password Secure

* Mark method as private

* Remove line which disables linting

* Add docs to importer

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-12 16:07:42 +01:00
renovate[bot]
cab1156d63 [deps] Platform: Update Rust crate thiserror to v1.0.69 (#11944)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-12 15:17:00 +01:00
renovate[bot]
5592d640a8 [deps] Autofill: Update tldts to v6.1.60 (#11939)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 17:08:50 -05:00