1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-27 21:53:25 +00:00
Commit Graph

2228 Commits

Author SHA1 Message Date
Bryan Cunningham
4449d8baf6 [CL-689][CL-799] Fix Icon button a11y errors (#15750)
* Throw error if appA11yTitle is null in icon button

* Add required label input

* Fix icon button errors in CL components and storeis

* fix popover aria-label errors

* remove commented code

* add labels to icon buttons in browser

* add labels to icon buttons in web

* add labels to icon buttons in license

* add labels to icon buttons in send

* add labels to icon buttons in angular

* fix missing pipe error

* fix sso icon button missed in error

* update labels in vault

* add section expand button label

* Adding labels to icon buttons

* Add lint rule to not allow icon buttons without label input

* rename util file

* trigger updates on title change

* update eslint rule name and folder

* add edit collection label to vault headers

* fix web header story label

* add show/hide summary labels

* update summary message

* fix breadcrumbs label message

* fix JSDoc to use correct input

* remove commented code

* use label as aria-label always. Remove init function

* add moreBreadcrumbs translation message to other apps

* add @bitwarden/team-ui-foundation as code owner for component eslint rules

* switch title to const variable

* add jsdoc comment on what the label input is used for

* [PM-22415] Tax ID notifications for Organizations and Providers (#15996)

* [NO LOGIC] Rename BillableEntity to BitwardenSubscriber

This helps us maintain paraody with server where we call this choice type ISubscriber. I chose BitwardenSubscriber to avoid overlap with RxJS

* [NO LOGIC] Move subscriber-billing.client to clients folder

* [NO LOGIC] Move organization warnings under organization folder

* Move getWarnings from OrganizationBillingApiService to new OrganizationBillingClient

I'd like us to move away from stashing so much in libs and utilizing the JsLibServicesModule when it's not necessary to do so. These are invocations used exclusively by the Web Vault and, until that changes, they should be treated as such

* Refactor OrganizationWarningsService

There was a case added to the Inactive Subscription warning for a free trial, but free trials do not represent inactive subscriptions so this was semantically incorrect. This creates another method that pulls the free trial warning and shows a dialog asking the user to subscribe if they're on one.

* Implement Tax ID Warnings throughout Admin Console and Provider Portal

* Fix linting error

* Jimmy's feedback

* remove duplicate messages keys

* revert changes to popover stories

* add back dupe myItems key for now as it was already here

* fix directive type errors

* remove variable left in error from merge conflict

* revert unintentional change to reports layout

* add back reports change

---------

Co-authored-by: Alex Morask <144709477+amorask-bitwarden@users.noreply.github.com>
2025-08-19 15:15:41 -04:00
Andreas Coroiu
1a57ad3fc5 fix(badge): [PM-24661] Improve performance of badge state calculation for large number of tabs
* refactor: rewrite the badge service to only calculate states for active tab

This also fixes an issue where the `difference` function didn't work and caused
all tabs to update for every single state update.

* fix: compilation issue

* feat: add error logging

* fix: linting

* fix: badge clearing on reload on firefox

* feat: optimize observable

* feat(wip): update all active tabs

tests are broken

* fix: existing tests

* feat: add new tests
2025-08-19 12:05:06 -04:00
Jonathan Prusik
e942645d44 [PM-24936] Prevent inline menu inheritance of potentially dangerous opacity from host body and above (#16063)
* prevent inline menu inheritance of dangerous opacity from host body and above

* cleanup and update tests

* check page opacity after html/body attribute mutations

* update tests

* cleanup
2025-08-18 20:45:35 -04:00
Will Martin
827c4c0301 [PM-15847] libs/components strict migration (#15738)
This PR migrates `libs/components` to use strict TypeScript.

- Remove `@ts-strict-ignore` from each file in `libs/components` and resolved any new compilation errors
- Converted ViewChild and ContentChild decorators to use the new signal-based queries using the [Angular signal queries migration](https://angular.dev/reference/migrations/signal-queries)
  - Made view/content children `required` where appropriate, eliminating the need for additional null checking. This helped simplify the strict migration.

---

Co-authored-by: Vicki League <vleague@bitwarden.com>
2025-08-18 15:36:45 -04:00
Justin Baur
939fd402c3 [PM-24677] Slim StateService down so it can be moved to state lib (#16021)
* Slim StateService down so it can be moved to state lib

* Fix accidental import changes

* Add `switchAccount` assertion

* Needs to use mock
2025-08-18 12:37:25 -04:00
Jonathan Prusik
0c166b3f94 remove BlockBrowserInjectionsByDomain feature flag (#16008) 2025-08-18 10:17:05 -04:00
Bernd Schoolmann
a60b7fed9a [PM-17667] Move key-generation service to KM ownership (#16015)
* Move key-generation service

* Update comment

* Add deprecation comments

* Fix firefox build

* Update comment

* Update DI import

* Update module imports
2025-08-15 23:49:49 +02:00
Vladimir Pakhomchik
931f8650cf Enhance trimAndRemoveNonPrintableText to support extended characters (#15919)
Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2025-08-15 13:26:42 -04:00
Daniel Riera
59169fb0c7 PM-23976 Autofilling not working in https://www.sketchup.com (#15990)
* PM-23976

* add space
2025-08-15 12:16:52 -04:00
Shane Melton
e7a55d3395 [PM-24710] Add a debounceTime to autofill currentPageDetails (#16029)
* [PM-24710] Add a debounceTime to currentPageDetails to ensure details collection content script has enough time to collect for details

* Adjust test observables to account for debounce

---------

Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
2025-08-15 11:07:59 -04:00
Nick Krantz
7f841a4f06 remove PM8851_BrowserOnboardingNudge feature flag (#15956) 2025-08-15 08:55:37 -05:00
bw-ghapp[bot]
3643bd910e Autosync the updated translations (#16030)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-15 09:39:38 +00:00
bw-ghapp[bot]
efcc602696 Autosync the updated translations (#16026)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-15 11:09:17 +02:00
Miles Blackwood
89f797d45f Creates notification queue type standard. (#16009) 2025-08-14 18:43:48 -04:00
SmithThe4th
41ad0a7ef9 [PM-22693] Firefox - After creating a new item, the View Item screen is blank (#15868)
* Updated get cipher data to retrieve data from observable

* Fixed tests
2025-08-14 14:22:45 -04:00
Oscar Hinton
40455546d1 [CL-652] Remove bootstrap and enable tailwind preflight (#8071)
Wraps up the tailwind migration by removing bootstrap from the web vault.
2025-08-12 20:32:19 +02:00
Dave
0b057f4c68 fix(environment-selector): [PM-21214] Extension and desktop server selector have incorrect styling (#15920)
* refactor(environment-selector): [PM-21214] Lib Environment Selector Styling - Make component standalone.

* refactor(environment-selector): [PM-21214] Lib Environment Selector Styling - Convert template to bit-menu.

* refactor(environment-selector): [PM-21214] Lib Environment Selector Styling - Move component to its own folder.

* fix(environment-selector): [PM-21214] Lib Environment Selector Styling - Fix button role redundancy.

* fix(environment-selector): [PM-21214] Lib Environment Selector Styling - Remove unneeded data-testid attributes.

* fix(environment-selector): [PM-21214] Lib Environment Selector Styling - Arrow glyph should not override link styling.
2025-08-12 13:57:52 -04:00
Dave
ff11ca9133 fix(current-account-component): [Auth/PM-16263] Current account avatar outline should be blue. (#15973) 2025-08-12 12:50:17 -04:00
Nick Krantz
7ec916802b Remove pm-10609-end-user-notifications feature flag (#15958) 2025-08-11 14:25:33 -05:00
bw-ghapp[bot]
a5e9485fa1 Autosync the updated translations (#15975)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-11 15:45:32 +00:00
Nick Krantz
3c5fcfc7ef Navigate the user from the autofill nudge to the proper destination based on their browser (#15876) 2025-08-11 09:44:51 -05:00
Github Actions
f2d42138b6 Bumped client version(s) 2025-08-11 14:30:29 +00:00
bw-ghapp[bot]
9f6757dadc Autosync the updated translations (#15946)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-11 14:11:11 +02:00
Jason Ng
2ef8b1a6bf [PM-18066] new item details view (#15311)
* update item details v2 in libs for new view design. targets web, browser, and desktop
2025-08-07 13:21:24 -04:00
Andreas Coroiu
c3f6892f9e [PM-24451] firefox extension crash due to huge memory usage when unlocking vault (#15938)
* feat: only set badge state for the active tab

* fix: tests

* feat: avoid calculating states unecessarily

* Revert BrowserApi.removeListener change

* Add fatal log on observable failure

* Use fromChromeEvent

* Remove required-using tests

* Only disable some

* One of each

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2025-08-07 13:19:14 -04:00
Miles Blackwood
f7169e909f Generate password triggers notifications (#15874) 2025-08-07 13:12:05 -04:00
Github Actions
1ffe8e433f Bumped client version(s) 2025-08-07 14:01:33 +00:00
Bernd Schoolmann
c13f8241c6 Remove worker js on safari (#15914) 2025-08-07 14:50:52 +02:00
Daniel Riera
5e5a24922b PM-24355 (#15862) 2025-08-06 09:49:50 -04:00
Daniel Riera
55464a0fc9 PM-24242 Add IDs to AtRisk Notification for automation (#15865)
* PM-24242

* fix ts issue in storybook
2025-08-06 09:49:23 -04:00
Thomas Rittson
61cd0c4f51 [PM-23920] Admin Console - adopt strongly typed guids (#15814)
Update organization, collection and policy to use strongly typed IDs
2025-08-06 15:27:52 +10:00
Jonathan Prusik
598348fcc1 eslint/ts disable removals (#15418) 2025-08-05 17:31:41 -04:00
Daniel Riera
2549afc45d PM-23890 Update overlays when a cipher is deleted (#15800)
* PM-23890 WIP

* add messaging service references

* Revert "PM-19574 Browser Autofill overlay displays outdated data (#15624)"

This reverts commit 9eceaa3d4c.

* add test

* fix merge spacing

* Revert "Revert "PM-19574 Browser Autofill overlay displays outdated data (#15624)""

This reverts commit 0fc6ec4d0b.
2025-08-05 12:17:38 -04:00
Vicki League
26c0176e2e [CL-712] Update icon button, components using it, and affected virtual scroll heights (#15683) 2025-08-05 10:58:49 -04:00
Ben Brooks
bddd81ce79 fix: [PM-23494] detect ID vs login inputs on booksamillion.com (#15548)
* fix: [PM-23494] add newsletter checks; cleanup

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* fix: [PM-23494] improve isExplicitIdentityEmailField, add NewEmailFieldKeywords

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* fix: [PM-23494] improve isNewsletterForm, add NewsletterFormNames

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

---------

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
2025-08-04 11:02:15 -07:00
rr-bw
25ada6f80f refactor(login-approval-component) [Auth/PM-14940] Update LoginApprovalComponent (#15511)
- Renames the `LoginApprovalComponent` to `LoginApprovalDialogComponent`
- Renames the property `notificationId` to `authRequestId` for clarity
- Updates text content on the component
2025-08-04 09:20:12 -07:00
Bernd Schoolmann
6bd8638ad8 [PM-24126] Move pin service to km ownership (#15821)
* Move pin service to km ownership

* Run format

* Eslint

* Fix tsconfig

* Fix imports and test

* Clean up imports

* Remove unused dependency on PinService

* Fix comments

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-08-04 17:01:39 +02:00
renovate[bot]
2dd6164fce [deps] Autofill: Update prettier to v3.6.2 (#15496)
* [deps] Autofill: Update prettier to v3.6.2

* fix: [PM-23425] Fix prettier issues related to dependency updte

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* [deps] Autofill: Update prettier to v3.6.2

---------

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ben Brooks <bbrooks@bitwarden.com>
2025-08-01 14:02:54 -07:00
Miles Blackwood
56f80539b9 Combine notif check/attempt, end msg pass syntax. (#15771) 2025-08-01 11:30:40 -04:00
bw-ghapp[bot]
0b3fb6fe87 Autosync the updated translations (#15870)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-01 09:38:34 +00:00
Justin Baur
4f9b2b618f [PM-24280] Remove account service from state (#15828)
* Introduce ActiveUserAccessor

* Use ActiveUserAccessor over AccountService

* Updates tests and testing utils to support ActiveUserAccessor

* Update all injection points

* Fix types test

* Use ternary instead
2025-07-31 09:09:14 -04:00
Bernd Schoolmann
5dae5267d9 [PM-22623] Remove most TS encryption code, remove service workers (#15153)
* Add new encrypt service functions

* Undo changes

* Cleanup

* Fix build

* Fix comments

* Switch encrypt service to use SDK functions

* Move remaining functions to PureCrypto

* Tests

* Increase test coverage

* Enforce sdk.ready and drop unused codepaths

* Delete unused code

* Delete unused code

* Delete more code

* Add forgotten sdk init logic

* Fix build

* Fix cli

* Fix tests

* Fix build

* Fix browser build

* Remove compare and add more comments / warnings

* Run prettier

* Remove unused feature flags

* Add hazmat warning to aesDecrypt

* Fix build

* Fix comment

* Fix test
2025-07-30 15:50:00 +02:00
Jason Ng
2e6977e98c [PM-23788] changed the getType for canClone to address new cipherLike (#15829) 2025-07-30 08:54:45 -04:00
Vicki League
6a2d8ee294 [CL-768] Fix small a11y errors in storybook stories (#15826) 2025-07-29 14:29:37 -04:00
Bernd Schoolmann
a7d3c0f5c2 [PM-23809] Add simplified interface to MP service (#15631)
* Add new mp service api

* Fix tests

* Add test coverage

* Add newline

* Fix type

* Rename to "unwrapUserKeyFromMasterPasswordUnlockData"

* Fix build

* Fix build on cli

* Fix linting

* Re-sort spec

* Add tests

* Fix test and build issues

* Fix build

* Clean up

* Remove introduced function

* Clean up comments

* Fix abstract class types

* Fix comments

* Cleanup

* Cleanup

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/services/master-password.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add comments

* Fix build

* Add arg null check

* Cleanup

* Fix build

* Fix build on browser

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add tests for null params

* Cleanup and deprecate more functions

* Fix formatting

* Prettier

* Clean up

* Update libs/key-management/src/abstractions/key.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Make emailToSalt private and expose abstract saltForUser

* Add tests

* Add docs

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2025-07-29 18:53:17 +02:00
Bernd Schoolmann
38d5edc2c5 [PM-23524] Port desktop settings to CL vault timeout, and drop old non-CL vault timeout components (#15513)
* Remove unused old vault timeout component

* Drop desktop specific vault timeout component and replace it with shared CL implementation

* Fix tests

* Fix test

* Fix build on desktop

* Fix tests

* Fix margin
2025-07-28 07:17:53 -07:00
Daniel Riera
9eceaa3d4c PM-19574 Browser Autofill overlay displays outdated data (#15624)
* PM-19574

* explicitly set true

* remove delete cipher call to address the issue at the core separately

* add test
2025-07-28 09:55:20 -04:00
bw-ghapp[bot]
106739b730 Autosync the updated translations (#15797)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-07-28 13:18:00 +00:00
bw-ghapp[bot]
5e402d9e54 Autosync the updated translations (#15774)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-07-25 10:07:43 +02:00
Todd Martin
b3db1b79ce chore(feature flags): [PM-19034] Remove feature flags and old components for Set/Change Password
* Removed flag and components.

* More cleanup

* Removed ChangePasswordComponent.

* Removed old EmergencyAccessTakeover

* Removed service initialization.

* Fixed test failures.

* Fixed tests.

* Test changes.

* Updated comments

* Fixed tests.

* Fixed tests.

* Fixed merge conflict.

* Removed style and routing references.

* Better comments.

* Removed ResetPasswordComponent
2025-07-24 12:46:18 -04:00