1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-26 17:43:22 +00:00
Commit Graph

2705 Commits

Author SHA1 Message Date
John Harrington
1e2ce42437 [PM-30127] [Defect] Automatic pop out is not necessary when editing a file send (#19111)
* relax popout requirement on file type Send edit

* remove popout req for text sends on firefox and safari & adjust test coverage
2026-02-24 07:32:14 -07:00
Thomas Avery
672a6026e3 [PM-27331] Update the sdk service to use accountCryptographicState (#18274)
* Update the sdk service to use accountCryptographicState
2026-02-23 12:23:37 -06:00
Jared Snider
3782e328e1 refactor(Auth-Font-Icons): [Auth/PM-31804] Migrate auth font icons to use bit-icon (#18816)
* PM-31804 - WIP

* PM-31804 - Profile Component - fix missing translation

* PM-31804 - Web - Emergency Access Takeover Dialog Comp - remove screen reader only span as arialabel on spinner should be sufficient

* PM-31804 - Web - EmergencyAccessViewComp - remove redundant span as aria label handles accessibility.

* PM-31804 - Web - EmergencyAccessViewComp - Remove redundant sr only span - replaced w/ aria label

* PM-31804 - Web - EmergencyAccessViewComp - Remove redundant sr only span - replaced w/ aria label

* PM-31804 - EmergencyAccessComp - Replace redundant sr only span with aria label

* PM-31804 - two-factor-setup.component.html - Replace redundant sr only spans with aria labels

* PM-31804 - WebauthnLoginSettingsModule - remove unnecessary IconModule - it's imported via SharedModule

* PM-31804 - web - emergency-access.component.html - Replace redundant sr only span with aria label

* PM-31804 - LoginDecryptionOptionsComponent - Replace redundant sr only span with aria label

* PM-31804 - ChangePasswordComp - Replace redundant sr only span with aria label

* PM-31804 - AccountComponent - add BitwardenIcon type to satisfy template type requirements for name property.

* PM-31804 - Browser Account Security Component - replace nonexistent chevron icon with existing angle right icon.

* PM-31804 - Fix A11y issues with missing aria labels

* PM-31804 - Remove remaining redundant sr only spans since we now have aria labels
2026-02-23 10:42:02 -05:00
bitwarden-devops-bot
e6c4998b7c Bumped client version(s) 2026-02-23 11:48:40 +00:00
bw-ghapp[bot]
a90d74c32c Autosync the updated translations (#19130)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-23 04:35:06 -06:00
Jackson Engstrom
ef7df6b841 [PM-30521] Add Autofill button to View Login screen for extension (#18766)
* adds autofill button for cipher view

* adds tests

* changes autofill function for non login types

* adds top margin to autofill button

* adds more top margin to autofill button

* only shows autofill button when autofill is allowed (not in a popout)

* add button type

* updates _domainMatched to take a tab param, updates how the component is passed through to slot

* fixes tests from rename

* adds comment about autofill tab checking behavior

* removes diff markers
2026-02-20 14:28:54 -08:00
Jonathan Prusik
aa4eac7d40 do not show passkey dialog and notifications at the same time (#18878) 2026-02-20 10:01:04 -05:00
bw-ghapp[bot]
2f6a5133f8 Autosync the updated translations (#19094)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-20 13:24:40 +01:00
Jordan Aasen
46a2af38a0 [PM-31974] - Vault Welcome dialog (#18960)
* premium upgrade prompt and onboarding dialog

* finalize onboard vault dialog

* vault welcome dialog no ext

* finish welcome dialog prompt

* revert changes to unified upgrade prompt service

* rename component

* rename feature flag

* add welcome dialog service

* fix tests

* fix footer position in welcome dialog

* present dialog in order

* fix tests

* fix padding
2026-02-19 09:29:54 -08:00
Brandon Treston
c8ba23e28d [PM-26378] Auto confirm events (#19025)
* add notification handler for auto confirm

* add missing state check

* fix test

* isolate angular specific code from shared lib code

* clean up

* use autoconfirm method

* add event logging for auto confirm

* update copy
2026-02-19 09:57:52 -05:00
✨ Audrey ✨
e66a1f37b5 Extract urlOriginsMatch utility and refactor senderIsInternal (#19076)
Adds urlOriginsMatch to @bitwarden/platform, which compares two URLs by
scheme, host, and port. Uses `protocol + "//" + host` rather than
`URL.origin` because non-special schemes (e.g. chrome-extension://)
return the opaque string "null" from .origin, making equality comparison
unreliable. URLs without a host (file:, data:) are explicitly rejected
to prevent hostless schemes from comparing equal.

Refactors senderIsInternal to delegate to urlOriginsMatch and to derive
the extension URL via BrowserApi.getRuntimeURL("") rather than inline
chrome/browser API detection. Adds full test coverage for
senderIsInternal.

The previous string-based comparison used startsWith after stripping
trailing slashes, which was safe in senderIsInternal where inputs are
tightly constrained. As a general utility accepting arbitrary URLs,
startsWith can produce false positives (e.g. "https://example.com"
matching "https://example.com.evil.com"). Structural host comparison
is the correct contract for unrestricted input.
2026-02-19 08:45:24 -05:00
Jackson Engstrom
d1250cf5a4 [PM-26704] Vault List Item Ordering for Extension (#18853)
* shows all/filtered ciphers in allItems instead of the ones that haven't been bubbled up into autofill or favorites

* removes remainingCiphers$ remnants

* updates loading$ observable logic

* updates loading$ test
2026-02-18 14:34:17 -08:00
John Harrington
f8b5e15a44 [PM-31731] [Defect] No error is returned when entering an invalid email + an invalid verification code (#18913)
* share i18n key for both invalid email and invalid otp submission

* claude review
2026-02-18 14:08:57 -08:00
John Harrington
263ec94124 [PM-32161] Remove all emails when email list field is cleared and send is saved (#18959)
* add new validation criteria to prevent authType.Email with an empty emails field

* simplify validation logic
2026-02-18 14:59:34 -07:00
Jason Ng
bca2ebaca9 [PM-30122] allow no folders inside browser folder settings (#19041) 2026-02-18 16:22:50 -05:00
Mike Amirault
f7f06267ee [PM-31347] Add missing messages resulting in empty toast on invalid export master password (#19037) 2026-02-18 11:50:52 -05:00
Jordan Aasen
ff775c7bbc fix click on "Fill" text (#19047) 2026-02-17 16:43:37 -08:00
Jordan Aasen
24c3b8fb2b fix autofill on click behavior (#19046) 2026-02-17 16:43:23 -08:00
bitwarden-devops-bot
e760b1c923 Bumped client version(s) 2026-02-17 20:45:06 +00:00
Brandon Treston
8a670f1731 fix circular dependency (#19023) 2026-02-17 14:05:14 -05:00
Nik Gilmore
e8df377ba1 [PM-30735] Fix bug causing ciphers not to load under certain circumstances. (#18895) 2026-02-17 09:10:39 -08:00
John Harrington
5623568a2f [PM-31620] Browser - Incorrect "Copy link" message when Send is shared with specific people (#18982)
* add existing Send creation messages to browser

* remove unused method and associated tests
2026-02-16 15:54:22 -07:00
bw-ghapp[bot]
8620a2d7e4 Autosync the updated translations (#19008)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-16 04:36:42 -06:00
Brandon Treston
2912bf05e1 [PM-26901] Add notification handler for auto confirm (#18886)
* add notification handler for auto confirm

* add missing state check

* fix test

* isolate angular specific code from shared lib code

* clean up

* use autoconfirm method

* fix test
2026-02-13 14:36:11 -05:00
Jason Ng
10a20a43a3 [PM-31738] update archive toasts (#18923)
* update archive toast for all clients and trash archive restore toast, update archive cipher utilities spec
2026-02-13 13:53:11 -05:00
Daniel James Smith
69264c8841 [PM-32212] Migrate platform font icons to bit-icon (#18970)
* Changes on browser

* Changes on desktop

* Changes on web

* Fix chromatic story

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-02-13 09:43:42 -05:00
bw-ghapp[bot]
c9a125b338 Autosync the updated translations (#18961)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-13 10:24:50 +01:00
Jordan Aasen
2a72d2e74d [PM-25685][PM-31077] - Migrate all Folder models (#17077)
* enforce strict types on folders

* fix folder api service

* fix tests

* fix test

* fix type issue

* fix test

* add extra checks for folders. add specs

* fix folder.id checks

* fix id logic

* remove unecessary check

* name name and id optional in folder model

* fix tests

* Update folder and folderview

* fix folder with id export

* fix tests

* fix tests

* more defensive typing

* fix tests

* no need to check for presence

* check for empty name in folder toDomain

* fixes to folder

* initialize id in folder constructor. fix failing tests

* remove optional param to folder constructor

* fix folder

* fix test

* remove remaining checks for null folder id

* fix logic

* pass null for empty folder ids

* make id more explicit

* fix failing test

* fix failing test

* fix "No Folder" filter
2026-02-12 13:52:29 -08:00
Alex
bfc1833139 [PM-32088] Switch phishing data source to GitHub (#18890)
* Switch phishing data source to GitHub and remove fallback mechanism

The phish.co.za mirror is down, causing every update cycle to timeout on
the primary fetch before falling back to the GitHub raw URL. This removes
phish.co.za entirely and uses GitHub as the sole data source, which was
the original source before the mirror was introduced.

- Rename `remoteUrl`/`fallbackUrl` to `ghSourceUrl` on PhishingResource type
- Remove phish.co.za URLs from both Domains and Links resources
- Remove catchError fallback block in `_updateFullDataSet()`
- Errors now propagate to `_backgroundUpdate()` which already handles
  retries (3 attempts with 5-minute delays) and graceful degradation

* revert the fallback logic removal, change prop name, add use fallback flag

* Update Links primaryUrl to Bitwarden-hosted blocklist

* remove all fallback logic
2026-02-12 09:29:18 -08:00
blackwood
7fcb1a7a76 Expand generic pattern for notification queue messages. (#18543) 2026-02-12 10:39:41 -05:00
Will Martin
ad8bde057f Fix EventListener type errors in inline menu list handlers (#18943)
Changed event parameter type from MouseEvent to Event in handleFillCipherClickEvent and handleViewCipherClickEvent to match the EventListener interface expected by useEventHandlersMemo.

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-12 09:50:31 -05:00
Jordan Aasen
396286ff9a [PM-26703] - Update Item Action Behavior for Extension (#18921)
* Revert "Revert "[PM-26703]- Browser - Update autofill Behavior (#18467)" (#18723)"

This reverts commit 5d17d9ee71.

* fix title in non-autofill list

* add feature flag

* add old logic. add specs

* revert changes

* remove comments

* update language in spec

* update appearance spec

* revert change to security-tasks

* fix logic for blocked uri. add deprecated notice.

* fix test

* fix type error
2026-02-11 16:54:05 -08:00
Ben Brooks
11e2b25ede PM-28831 Add isTrusted checks to ignore programmatically generated events (#18627)
* ignore events that do not originate from the user agent
* [pm-28831] Add isTrusted checks and update tests
* [pm-28831] Add isTrusted check to click events
* [pm-28831] Replace in-code jest exceptions with new utils
* [pm-28831] Move isTrusted checks to testable util
* [pm-28831] Remove redundant check in cipher-action.ts
* [pm-28831] Add isTrusted checks to click events in autofill-inine-menu-list
---------

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
Co-authored-by: Jonathan Prusik <jprusik@classynemesis.com>
2026-02-11 14:47:27 -08:00
Jonathan Prusik
b2f8fd67ef consolidate excluded domains copy to allow removal of service invocation (#18610) 2026-02-11 13:53:26 -05:00
Daniel Riera
bd3f8dd4c1 [PM-29519]Remove @ts-strict-ignore in browser-fido2-user-interface.service.ts (#18691) 2026-02-11 12:24:02 -05:00
Leslie Xiong
ea55aaaede [CL-1022] Update Berry Styles (#18799)
* created 'berry' component

* added 'bit-berry' to 'popup-tab-navigation'

* simplified - removed null checks

* changed 'effectiveSize' to 'computedSize'

* fixed 'accentPrimary' color

* updated to not render berry if 'count' is 0 or negative number

* simplified checking count undefined

* updated computed padding

* switched from `[ngClass]` to `[class]`

* updated 'popup-tab-navigation' berry to use 'danger' variant

* fixed berry positioning in popup-tab-navigation

* updated content logic

* cleanup unused 'ngClass'

* updated conditional rendering of berry

* updated story 'Usage'

* updates with adding berry 'type'

* added type "status" to popup-tab-navigation

* fixed type error

* updated 'Count Behavior' description
2026-02-11 12:21:33 -05:00
Nick Krantz
f20686cdf4 [PM-24978] Corrupt Attachment Keys (#17790)
* display translated content for attachments that cannot be downloaded

* consume decryption failure from the sdk for attachments

* add decryption errors from sdk

* only show fix attachment issues for when key is null and it does not have a decryption failure

* separate decryption failure state in view
2026-02-11 10:31:38 -06:00
Jason Ng
428a96902c [PM-31679] remove archive from browser edit (#18854)
* removing archive btns from browser edit form footer, remove archive items from showing in expired premium users vault
2026-02-11 09:46:21 -05:00
Bernd Schoolmann
952996099a Remove duplicate import of VaultComponent (#18904) 2026-02-11 08:36:40 -06:00
Jackson Engstrom
8f6cf67f8d [PM-29116] UI Text cut off on default size extension for Download Bitwarden (#18789)
* updates settings buttons to wrap instead of truncate

* adds new download copy
2026-02-10 15:32:36 -08:00
Jordan Aasen
cc03df4950 [PM-17735] - remove v2 suffix from browser vault components (#18108)
* remove v2 suffix

* fix test

* fix path

* fix test

* Fix missed -v2 import path

* fix test

---------

Co-authored-by: Shane <smelton@bitwarden.com>
2026-02-10 13:39:53 -08:00
Andreas Coroiu
b3cb990037 [PM-29313] [Defect] TDE JIT Provisioning - Extension showing locked icon even if user already logged in (#18672)
* fix: add better error handling to badge service

* fix: lint
2026-02-10 15:11:12 +01:00
Jason Ng
322ff6b70b [PM-31675] remove archive from web edit (#18764)
* refactor default cipher archive service, update archive/unarchive in vault-item-dialog, remove archive/unarchive items in edit form
2026-02-09 16:17:46 -05:00
Daniel Riera
e92817011b [PM 29531]Remove ts strict ignore in list autofill inline menu list ts (#18738)
* fix(autofill): type throttle to preserve handler this/args and return void

* fix(autofill): strict TS and defaults for inline menu list, throttle typing, TOTP interval

* update snapshots

* swap mouse event for event

* prevent default does nothing on event
2026-02-09 15:05:19 -06:00
Alex Dragovich
e485623ed8 [PM-31685] Removing email hashes (#18744)
* [PM-31685] Removing email hashes

* [PM-31685] fixing tests, which are now passing

* [PM-31685] removing anon access emails field and reusing emails field

* [PM-31685] fixing missed tests

* [PM-31685] fixing missed tests

* [PM-31685] code review changes

* [PM-31685] do not encrypt emails by use of domain functionality

* [PM-31685] test fixes
2026-02-09 12:59:17 -08:00
Jonathan Prusik
62f5929ebb fix processMutations debouncing (#18615) 2026-02-09 09:21:33 -05:00
Bernd Schoolmann
f7a5ad712f [PM-29208] Remove individual cryptographic-key states & migrate key service (#18164)
* Remove inividual user key states and migrate to account cryptographic state

* Fix browser

* Fix tests

* Clean up migration

* Remove key-pair creation from login strategy

* Add clearing for the account cryptographic state

* Add migration

* Cleanup

* Fix linting
2026-02-09 12:39:55 +01:00
bw-ghapp[bot]
2807bb089b Autosync the updated translations (#18836)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-09 11:26:10 +00:00
Mike Amirault
eb402a7ee8 [PM-30881] Add lock icon to browser Sends list for protected Sends (#18635)
* [PM-30881] Add lock icon to browser Sends list for protected Sends

* Trigger AI PR review

* [PM-30881] Add missing i18n key to browser file
2026-02-06 10:42:16 -05:00
bw-ghapp[bot]
60f75062b0 Autosync the updated translations (#18804)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-06 11:01:26 +01:00