bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 05:13:29 +00:00
Code Issues Releases Wiki Activity
17,761 Commits 1,211 Branches 568 Tags
4d68952ef39255e2a252137add77c0082cd20944
Commit Graph

2221 Commits

Author SHA1 Message Date
Brandon Treston
4d68952ef3 [PM-18089] Update cipher permissions model and consumers (#13606) 
* update cipher permissions model and consumers

* add new property to tests

* fix test, add property to toCipherData()

* add missing ConfigService

* fix story

* refactor

* fix error, cleanup

* revert refactor

* refactor

* remove uneeded test

* cleanup

* fix build error

* refactor

* clean up

* add tests

* move validation check to after featrue flagged logic

* iterate on feedback

* feedback
 2025-03-14 09:51:40 -04:00
Thomas Rittson
0c507f54f6 [PM-13323] Move remaining collection code to AC Team (#13731) 2025-03-13 17:18:47 -04:00
Jason Ng
45df8ff825 [PM-19025] update icon, add href for a11y nav (#13818) 2025-03-13 17:13:38 -04:00
Alec Rippberger
e9c7cd11a3 refactor(auth): [PM-9722] remove deprecated LoginDecryptionOptionsComponent 
- Remove LoginDecryptionOptionsComponentV1
- Clean up orphaned translation messages
- Remove unused styles
- Clean up related dependencies

Closes PM-9722
 2025-03-13 15:37:52 -05:00
Ike
31b1ee4f84 [PM-19209] Update New device verification error 
fix : updating error string for new device response from server to match comparison.
 2025-03-13 14:48:16 -04:00
Shane Melton
4687120618 [PM-18946] Improve Vault loading experience (#13714) 
* [PM-18946] Refactor loading$ in vault-v2. Update icon-component, and build-cipher-icon
 2025-03-13 14:38:29 -04:00
Thomas Avery
81335978d8 [PM-17669] Move MasterPasswordService to KM (#13148) 
* Move MasterPasswordService to KM
 2025-03-13 13:29:27 -05:00
Alec Rippberger
4f724974e9 refactor(auth): [PM-9725] remove deprecated EnvironmentComponent and self-hosted setup modal 
* Remove EnvironmentComponent
* Cleanup unused translation messages

Closes PM-9725
 2025-03-13 12:23:37 -05:00
Daniel James Smith
26fb3220fe Introduce export-attachments feature-flag (#13827) 
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-03-13 16:52:36 +00:00
Alec Rippberger
1d1358407e refactor(components): remove deprecated HintComponent and related code 
- Remove HintComponent
- Clean up orphaned functionality
- Remove unused translation messages

Closes PM-9727
 2025-03-13 09:56:50 -05:00
Thomas Avery
7e96b7a9a6 [PM-17670] Move KeyConnectorService to KM ownership (#13277) 
* Move KeyConnectorService to KM ownership

* Add to codecov

* Move key connector request models
 2025-03-13 09:46:01 -05:00
Jared Snider
cff14ffea3 fix(Extension2FAWebAuthn): [Auth/PM-19086] Read webauthn response off correct property (#13796) 2025-03-13 09:39:04 -04:00
Jordan Aasen
6c2d7e92e6 allow item history to be selectable (#13708) 2025-03-12 15:19:06 -07:00
Alec Rippberger
942b80e5d2 refactor(auth): [PM-9724] remove LoginViaAuthRequestComponentV1 and related functionality 
- Remove deprecated LoginViaAuthRequestComponentV1 component
- Clean up related ApiService functionality
- Remove orphaned translation messages
- Remove unused CSS styles

Jira PM-9724
 2025-03-12 16:40:05 -05:00
Vincent Salucci
ae47c12b0e chore: organize feature flags (#13809) 2025-03-12 15:34:04 -05:00
Alec Rippberger
4308cd8a9f refactor(auth): [PM-9678] remove deprecated login components 
Removes the V1 Login components and related UnauthenticatedExtensionUIRefresh
feature flag functions. Part of the authentication UI modernization efforts.

Closes PM-9678
 2025-03-12 14:36:05 -05:00
rr-bw
e268055dc1 feature(set-change-password): [Auth/PM-17648] Create MasterPasswordApiService (#13552) 
Creates a MasterPasswordApiService to house our API calls related to setting and changing a master password.
 2025-03-12 11:33:44 -07:00
Jason Ng
0356f4c1af [PM-19106] view-item folder bug fix (#13808) 
added security task flag check to task api call in cipher-view
 2025-03-12 12:58:30 -04:00
Bernd Schoolmann
83de125ae9 [PM-15149] Remove ssh feature flag (#13506) 
* Remove ssh feature flag

* Remove isSshKeyENabled in type-filter.component
 2025-03-12 14:19:49 +01:00
Jason Ng
15fa3cf08d [PM-10613] End User Notification Service (#13721) 
* new end user notification service to retrieve and update notifications from API
 2025-03-12 08:02:18 +01:00
Daniel Riera
b988993a88 PM-18963 removed flag and updated relevant tests (#13767) 2025-03-11 16:06:03 -04:00
Conner Turnbull
00e822fb13 [PM-16937] Remove Billing Circular Dependency (#13085) 
* Remove circular dependency between billing services and components

* Removed `logService` from `billing-api.service.ts`

* Resolved failed test

* Removed @bitwarden/ui-common

* Added optional `title` parameter to `BillingNotificationService` functions

* Removed @bitwarden/platform from libs/common/tsconfig.json

* Update apps/web/src/app/billing/services/billing-notification.service.spec.ts

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Update apps/web/src/app/billing/services/billing-notification.service.spec.ts

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Resolved build errors

* Resolved issue where free trial banner wouldn't display if missing a payment method

---------

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
 2025-03-11 13:43:19 -04:00
Daniel James Smith
f7440c1cf2 Ensure the SendType is always set when building a SendFormConfig (#13786) 
Includes a fallback to SendType.Text when non other path worked.

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-03-11 10:28:50 -04:00
Daniel James Smith
6188013b9d Introduce desktop-send-ui-refresh feature-flag (#13787) 
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-03-11 08:50:24 -05:00
Bernd Schoolmann
9683779dbf [PM-17984] Remove AES128CBC-HMAC encryption (#13304) 
* Remove AES128CBC-HMAC encryption

* Increase test coverage
 2025-03-11 14:20:02 +01:00
Maciej Zieniuk
5cd47ac907 [PM-18243] Improve type safety in decryption (#12885) 
* Improve decrypt failure logging

* Rename decryptcontext to decrypttrace

* Improve docs

* PM-16984: Improving type safety of decryption

* Improving type safety of decryption

---------

Co-authored-by: Bernd Schoolmann <mail@quexten.com>
 2025-03-11 14:06:44 +01:00
Patrick-Pimentel-Bitwarden
3b9be21fd7 fix(auth-routing): [PM-19018] SSO TDE Routing Fix - Fixed routing logic. (#13778) 
* fix(auth-routing): [PM-19018] SSO TDE Routing Fix - Fixed routing logic.

* PM-19018 - TwoFactorAuthTests - remove tests that are no longer applicable as 2FA comp isn't responsible for setting admin account recovery flag into state.

* PM-19018 - LoginStrategyTests - add test for processing forcePasswordReset response

---------

Co-authored-by: Jared Snider <jsnider@bitwarden.com>
 2025-03-10 21:20:11 -04:00
Jordan Aasen
992be1d054 [PM-13991] - Edit login - reorder website URIs (#13595) 
* WIP - sortable website uri

* add specs

* fix type errors in tests
 2025-03-10 12:57:02 -07:00
Vijay Oommen
a877450e0a PM-2630 virtual scroll on tables (#13725) 
Tested by QA and passed.
 2025-03-10 15:52:52 -04:00
rr-bw
0568a09212 refactor(device-trust-toasts): [Auth/PM-11225] Refactor Toasts from Auth Services (#13665) 
Refactor toast calls out of auth services. Toasts are now triggered by an observable emission that gets picked up by an observable pipeline in a new `DeviceTrustToastService` (libs/angular). That observable pipeline is then subscribed by by consuming the `AppComponent` for each client.
 2025-03-10 12:17:46 -07:00
rr-bw
d943f53477 refactor(routing): [Auth/PM-18783] Remove Unauth UI route swapping for all components except 2FA (#13645) 
Removes `unauthUiRefreshSwap()` from all routing modules for all refreshed components except for 2FA. This does not remove the legacy components themselves, just the routing to them.

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
 2025-03-10 11:12:02 -07:00
Jordan Aasen
a19bf1687e [PM-12557] - center align custom field buttons (#13670) 
* center align custom field buttons

* add margin
 2025-03-10 11:07:22 -07:00
Jordan Aasen
985942ac05 collapse collections initially (#13646) 2025-03-10 11:07:04 -07:00
Bernd Schoolmann
01f6fd7ee3 [PM-16227] Move import to sdk and enable it in browser/web (#12479) 
* Move import to sdk and enable it in browser/web

* Add uncomitted files

* Update package lock

* Fix prettier formatting

* Fix build

* Rewrite import logic

* Update ssh import logic for cipher form component

* Fix build on browser

* Break early in retry logic

* Fix build

* Fix build

* Fix build errors

* Update paste icons and throw error on wrong import

* Fix tests

* Fix build for cli

* Undo change to jest config

* Undo change to feature flag enum

* Remove unneeded lifetime

* Fix browser build

* Refactor control flow

* Fix i18n key and improve import behavior

* Remove for loop limit

* Clean up tests

* Remove unused code

* Update libs/vault/src/cipher-form/components/sshkey-section/sshkey-section.component.ts

Co-authored-by: SmithThe4th <gsmith@bitwarden.com>

* Move import logic to service and add tests

* Fix linting

* Remove erroneous includes

* Attempt to fix storybook

* Fix storybook, explicitly implement ssh-import-prompt service abstraction

* Fix eslint

* Update libs/importer/src/importers/bitwarden/bitwarden-json-importer.ts

Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>

* Fix services module

* Remove ssh import sdk init code

* Add tests for errors

* Fix import

* Fix import

* Fix pkcs8 encrypted key not parsing

* Fix import button showing on web

---------

Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
 2025-03-10 18:41:47 +01:00
Nick Krantz
85a5aea897 [PM-18859] Mobile Viewports - Extension Prompt (#13703) 
* remove min-width on body element for extension prompt page

* reset meta viewport content for extension prompt page

* set max width of svg to avoid any overflow on mobile devices

* use inline display to avoid icon  overflow on mobile devices

* use max width on the icon to fix overflow rather than editing the anon layout
 2025-03-10 10:33:56 -05:00
Oscar Hinton
a569dd9ad6 [PM-15892] [PM-12250]Remove nord and remnants from solarizedark (#13449) 
* Remove nord and remnants from solarizedark

* Update window reload color

* Remove extension-refresh feature flag from clients (#13450)

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>

* Remove usage of nord and solarized themes within DarkImageDirective

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-03-10 15:33:55 +01:00
Thomas Rittson
ef72f513b1 eslint: report unused disable directives (#13463) 
Remove any unused disable directives and FIXMEs in our code
 2025-03-10 09:33:08 -04:00
Todd Martin
895b36a3d8 [PM-18945] Add CLI as valid SSO client (#13723) 
* Added CLI as valid SSO client.

* Updated SsoClientType
 2025-03-07 18:30:28 -05:00
Ike
c739a884b4 [PM-15015] Adding Request Country Name to auth requests approval dialog (#13718) 
* feat(pm-15015) : 
  - Adding `requestCountryName` to auth requests dialogs, and response models. 
  - Updated i18n messages.json in Web, Browser, and Desktop to include "Location" translation.
 2025-03-07 18:03:13 -05:00
Vijay Oommen
f1b69ad65d [PM-16690] Bitwarden CSV Import - collections not created (#13636) 2025-03-07 16:58:43 -06:00
Jared Snider
264ceaa82a fix(NewDeviceVerification): [Auth/PM-18641] Show translated invalid code error on enter keypress (#13740) 2025-03-07 12:56:21 -05:00
Merissa Weinstein
d4c74287fc [CL-281] Override tailwind text-3xl style (#13710) 
* override tailwind text-3xl style

* convert px to rem
 2025-03-07 10:02:17 -06:00
✨ Audrey ✨
dcf15b496b [PM-17590] fix chrome translation bug by escaping $ (#13103) 
replaces translation with hard-coded text for cross-platform compatibility
 2025-03-06 20:13:04 +00:00
Jared Snider
5588e1a1a1 fix(auth): Auth/pm 18836 - UI Refresh - Chrome extension - WebAuthn 2FA revert inline iframe for chromium (#13709) 
* PM-18836 - (1) Extension Two Factor Webauthn - revert supporting inline webauthn 2fa as it doesn't work outside of local still (2) Extension 2FA Webauthn comp - add log of webauthn errors to help diagnose future issues

* PM-18836 - Extension - Services module - ExtensionTwoFactorAuthWebAuthnComponentService - remove unused dep
 2025-03-06 11:49:49 -08:00
SmithThe4th
e327816bc4 [PM-11941] Migrate TOTP Generator to use SDK (#12987) 
* Refactored totp service to use sdk

Fixed strict typescript issues

* Fixed dependency issues

* Returned object that contains code and period, removed get interval function

* removed dependencies

* Updated to use refactored totp service

* removed sdk service undefined check

* removed undefined as an input from the getCode function

* Made getcode$ an observable

* refactored to use getcodee$

* Filter out emmissions

* updated sdk version

* Fixed readability nit

* log error on overlay if totp response does not return a code

* fix(totpGeneration): [PM-11941] Totp countdown not working on clients

* Used optional chaining if totpresponse returns null or undefined
 2025-03-06 14:01:07 -05:00
Jason Ng
f65daf7284 [PM-12045] search service activeuserstate (#13035) 
* removing activeuserstate from search service
 2025-03-06 12:26:24 -05:00
✨ Audrey ✨
9761588a2a [PM-16790] introduce extension service (#13590) 2025-03-06 11:32:42 -05:00
cyprain-okeke
96fa9e2ea7 Resolve the Tailwind CSS class error (#13700) 2025-03-06 14:47:03 +01:00
Jonas Hendrickx
ed83b6a445 [PM-18163] Remove feature flag 'AC-1795_updated-subscription-status-section' (#13456) 2025-03-06 13:19:08 +01:00
Shane Melton
a7643ebab0 [PM-18650] [PM-18640] Fix change login password service defects (#13596) 
* [PM-18650] Ensure http url is returned if well-known cannot be confirmed

* [PM-18650] Modify getChangePasswordUrl logic to check each cipher URL until a valid well-known url is found
 2025-03-05 11:49:54 -08:00