1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Commit Graph

19088 Commits

Author SHA1 Message Date
Alex
4dd7e0cafa Messages: unmark critical (#16146)
* Unmark as critical

* Revert "Unmark as critical"

This reverts commit 3fa79fc498.

* rename unmarkAsCriticalApp -> unmarkAsCritical
2025-08-27 09:41:42 -07:00
Vicki League
38f62a0149 [PM-25222] Fix svg alignment issues caused by new preflight defaults (#16181) 2025-08-27 12:40:16 -04:00
Addison Beck
5f7c0ae999 build: ensure new libraries are added to the root jest.config (#16166)
* Add missing libs to jest.config.js

Added 15 missing libraries to the jest projects array:
- libs/assets
- libs/client-type
- libs/core-test-utils
- libs/dirt/card
- libs/guid
- libs/logging
- libs/messaging-internal
- libs/messaging
- libs/serialization
- libs/state-test-utils
- libs/state
- libs/storage-core
- libs/storage-test-utils
- libs/tools/export/vault-export/vault-export-ui
- libs/user-core

This ensures all existing libraries with jest.config.js files are included in CI test runs.

* Update basic-lib generator to add new libs to jest.config.js

- Added updateJestConfig function that automatically adds new libraries to jest.config.js
- Function finds the appropriate alphabetical position for the new library
- Added comprehensive tests for the new functionality
- Ensures new libraries are included in CI test runs from creation

This prevents the issue where new libraries are created but their tests
are not run in CI because they are missing from the jest configuration.

* Fix import statements in state-definitions and deserialization-helpers tests

- Fixed ClientLocations import in state-definitions.spec.ts to use @bitwarden/storage-core instead of relative import
- Simplified deserialization-helpers.spec.ts import to use library root @bitwarden/serialization
2025-08-27 11:56:42 -04:00
Maciej Zieniuk
4c960906fa Account Recovery with Key Connector enabled not working prior to removal of Master Password (#15616) 2025-08-27 16:32:18 +02:00
Nick Krantz
fcc2bc96d1 [PM-21024] Use Server for Password Change URLs (#14912)
* migrate change login password service to use bitwarden server rather than fetch directly

- avoids CSP entirely

* add `HelpUsersUpdatePasswords` policy to policy type

* add `HelpUsersUpdatePasswordsPolicy` components

* allow list description override for policy description

* add `HelpUsersUpdatePasswordsPolicy` when the feature flag is enabled

* apply `HelpUsersUpdatePasswords` to everyone in an org

* use policy to guard the well known password API

* fix tests

* refactor to use `policyAppliesToUser$`

* remove policy work for change password - this was removed from scope

* update copy for show favicon setting - it now handles both favicons and change password urls

* remove favicon setting description - no longer needed

* only call change password service when the setting is enabled

* add popover for permitting cipher details

* import permit popover directly into the settings component

* replace `nativeFetch` with `fetch`

* use string literal to construct URL rather than `URL` class
- The `getIconsUrl` can return with an appended path which the new URL constructor will strip when passed as the base parameter

* use string literal to construct URL rather than `URL` class instance (#16045)

- The `getIconsUrl` can return with an appended path which the new URL constructor will strip when passed as the base parameter

* [PM-24716] UI changes for Change URI work (#16043)

* use platform service to launch the URI
- this allows desktop to open a separate browser instance rather than use electron

* fix spacing on web app

* add bitLink for focus/hover states

* remove spacing around links
2025-08-27 09:03:44 -05:00
Brandon Treston
7ccb94d0a2 fix missing null check (#16180) 2025-08-27 13:25:36 +00:00
Thomas Rittson
4f09ae52ab [PM-25203] Resolve circular dependencies through LooseComponentsModule (#16157)
* Update modules to not import loose-components

Instead they should import their dependencies directly.
Only OssModule imports loose-components.module.ts.

* Remove unused imports and exports
2025-08-27 17:40:32 +05:30
Github Actions
c72fdebfd9 Bumped Desktop client to 2025.8.2 2025-08-26 22:55:29 +00:00
neuronull
34cd41988a Remove EnableNewCardCombinedExpiryAutofill feature flag (#16131) 2025-08-26 12:44:08 -06:00
Brandon Treston
28b5a2bb5e [PM-22717] Expose DefaultUserCollectionEmail to clients (#15643)
* enforce restrictions based on collection type, set default collection type

* fix ts strict errors

* fix default collection enforcement in vault header

* enforce default collection restrictions in vault collection row

* enforce default collection restrictions in AC vault header

* enforce default collection restriction for select all

* fix ts strict error

* switch to signal, fix feature flag

* fix story

* clean up

* remove feature flag, move check for defaultCollecion to CollecitonView

* fix test

* remove unused configService

* fix test: coerce null to undefined for collection Id

* clean up leaky abstraction for default collection

* fix ts-strict error

* fix parens

* add new property to models, update logic, refactor for ts-strict

* fix type

* rename defaultCollection getter

* clean up

* clean up

* clean up, add comment, fix submit

* add comment

* add feature flag

* check model for name

* cleanup readonly logic, remove featureflag logic

* wip

* refactor CollectionRequest into Create and Update models

* fix readonly logic

* cleanup

* set defaultUserCollectionEmail in decryption from Collection

* split save into update/create methods

* fix readonly logic

* fix collections post and put requests

* add defaultUserCollection email to model when submitting collection dialog
2025-08-26 11:42:52 -04:00
Todd Martin
ad2dfe1e99 feat(notifications): [PM-19388] Enable push notifications on locked clients
* Add back notifications connection on locked accounts

* Updated tests.

* Make sure web push connection service is started synchronously

* Fixed merge conflicts.

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2025-08-26 11:41:15 -04:00
Miles Blackwood
fb4f87958d Uses setTimeout to shim requestIdleCallback (#16143)
* Makes inline menu handler async to resolve Safari issue.

* Don't use idle callback deadline as timeout delay.

* Revert "Makes inline menu handler async to resolve Safari issue."

This reverts commit d3f7461cfaae440f33d5be48278c01e5d6f74dde.

---------

Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
2025-08-26 11:35:23 -04:00
Oscar Hinton
492e2b8d06 Enable the angular check (#15210)
Enables the angular check introduced by #15168.
2025-08-26 17:27:41 +02:00
renovate[bot]
684299f054 [deps] AC: Update core-js to v3.45.0 (#16048)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jimmy Vo <huynhmaivo82@gmail.com>
2025-08-26 11:18:52 -04:00
bw-ghapp[bot]
cfa8615c28 Autosync the updated translations (#16158)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-26 13:51:31 +00:00
bw-ghapp[bot]
ebe133f579 Autosync the updated translations (#16159)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-26 13:50:35 +00:00
aj-bw
00dc170231 add shadow package, restore entrypoint functionality (#16124) 2025-08-26 08:47:19 -04:00
bw-ghapp[bot]
d4e2e73d13 Autosync the updated translations (#16160)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-26 10:09:06 +00:00
Vince Grassia
c7b2e3f9c2 Fix typo (#16152) 2025-08-26 11:09:09 +02:00
Jordan Aasen
9ed69ef4b8 [PM-24304][PM-24305] - [Defect] Some fields are not disabled when editing an item from My Vault (#15982)
* disable all remaining form fields for editing personally owned My Items

* fix failing tests

* ensure collection field is also properly disabled

* clean up logic

* fix failing test

* fix test

* refactor variable to avoid using `is` prefix

* directly reference parent form for status rather than subscribe to it

* refactor subscription for form status changes

* use observable as an Output

* disable attachment button on desktop vault when the form

* disable custom field components when custom fields already exist and parent form is disabled

* disable attachments button in the browser when the edit form is disabled

* grab icon button instance for disabled state

---------

Co-authored-by: Nick Krantz <nick@livefront.com>
2025-08-25 15:48:00 -07:00
Shane Melton
e10d13faa8 [PM-22695] Remove unused vault service (#16134)
* [PM-22695] Remove obsolete browser vault filter service

* [PM-22695] Remove obsolete vault browser state service
2025-08-25 14:50:54 -07:00
Jordan Aasen
ae2259db2f [PM-17723] - [Web | Browser | Desktop] Cannot search for port in vault login item URI (#15962)
* add port search in uriExtractor

* revert to original check
2025-08-25 14:07:22 -07:00
Brandon Treston
0fbebdc6c4 fix permission order (#16148) 2025-08-25 16:24:50 -04:00
Brandon Treston
0736e61ad8 fix icon spacing (#16147) 2025-08-25 15:37:09 -04:00
Justin Baur
5f7f1d1924 Resolve state <-> state-test-utils circular dependency (#16093)
* Resolve state <-> state-test-utils circular dependency

* Fix type errors
2025-08-25 12:38:28 -04:00
Vicki League
777b92660a [CL-706] Display all svg icons in Storybook (#16111) 2025-08-25 12:09:20 -04:00
bw-ghapp[bot]
85dccf2a44 Autosync the updated translations (#16119)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-25 12:10:03 +00:00
bw-ghapp[bot]
dfcfe52d1e Autosync the updated translations (#16141)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-25 11:17:27 +00:00
Github Actions
825a9b2ccc Bumped client version(s) 2025-08-25 11:02:35 +00:00
bw-ghapp[bot]
60762b728c Autosync the updated translations (#16117)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-25 10:58:42 +00:00
bw-ghapp[bot]
1674709a58 Autosync the updated translations (#16118)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-25 12:47:31 +02:00
Maciej Zieniuk
5b402d9c38 cleanup remove password on start for desktop (#15957) 2025-08-22 23:14:02 +02:00
Shane Melton
65230a9c3e [PM-24229] Preserve existing cipher date fields when using CipherExport.toView (#15993)
* [PM-24229] Ensure existing dates are persisted when using CipherExport.toView

* [PM-24229] Test both null and undefined

* [PM-24229] Add test for copied date values
2025-08-22 12:21:23 -07:00
Vicki League
dd4ec9c5d9 [CL-735][CL-743] Finish migrating form control components to signals (#15927) 2025-08-22 15:17:14 -04:00
Robyn MacCallum
7bcd85314e Revert "Bumped client version(s)" (#16128)
This reverts commit a3f729ef8d.
2025-08-22 14:57:31 -04:00
Nick Krantz
9ecf2686e5 [PM-22987] Hide download for corrupt attachments (#16023)
* spelling fix

* hide download button for corrupt attachments

* add missing translations for desktop
2025-08-22 12:38:35 -05:00
Github Actions
a3f729ef8d Bumped client version(s) 2025-08-22 17:21:03 +00:00
Jason Ng
6e9da95230 [PM-22371] remove end user activation flag (#16067) 2025-08-22 12:56:16 -04:00
Shane Melton
4676a122da [PM-24143] Search performance improvements (#16070)
* [PM-24143] Add perUserCache$ to SearchService index$

* [PM-24143] Cleanup and optimize isSearchable

* [PM-24143] Remove unused search flags and subscription from the vault-items component

* [PM-24143] Add search text for desktop vault items. Consolidate SearchTextDebounceInterval constant to SearchService

* [PM-24143] Ensure cipher search indexing is non-blocking

* [PM-24143] Remove redundant index ciphers operation

* [PM-24143] Add search performance measurements

* [PM-24143] Remove artificial delay

* [PM-24143] Remove startWith from index$ to avoid basic search with lunr queries

* [PM-24143] Re-organize isSearchable to check long lunr queries for index existence
2025-08-22 09:32:36 -07:00
Github Actions
ba7e5fdcde Bumped client version(s) 2025-08-22 16:21:49 +00:00
Jonathan Prusik
b87cb2ba24 [PM-25025] Additional defense against top-layer content (#16101)
* additional defense against top-layer content

* fix error and update tests
2025-08-22 11:09:00 -04:00
Dave
6c173c4565 feat(two-factor-setup-webauthn): [Auth/PM-4093] Remove warning callout from WebAuthn 2FA modal (#16011)
* feat(two-factor-setup-webauthn): [PM-4093] WebAuthn Support Warning - Remove platform limitation warning from web.

* feat(two-factor-setup-authn):  [PM-4093] WebAuthn Support Warning - Remove translations for support warning.
2025-08-22 10:19:58 -04:00
Bryan Cunningham
eb84faaf99 [CL-825] Provide dimensions to checkbox to fix ios rendering bug (#16109)
* absolutely position checkbox to fix ios rendering bug

* remove absolute positioning. Dimensions fix it
2025-08-22 10:01:23 -04:00
Daniel García
92c9aa7b3e Use FakeStateProvider in SdkService tests (#16126) 2025-08-22 15:19:18 +02:00
Daniel García
12df7def61 [PM-19479] Client-Managed SDK state definition (#14839)
* [PM-19479] Client-Managed SDK state definition

* Remove test code

* Update based on latest sdk

* Add DB config

* Remove uuid conversion step

* Move mapper into separate file

* Revert to client managed state

* Move mapper to Cipher

* Typo

---------

Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
2025-08-22 14:21:52 +02:00
Justin Baur
7aca0cdbd7 Fix AppComponent.ngOnInit throwing an error (#16115) 2025-08-21 17:28:03 -04:00
Thomas Avery
a6e7efddeb [PM-23627] Require publicKey for keyService getFingerprint (#15933)
* require public key on keyService getFingerprint

* Update consumers and add error handling & logging
2025-08-21 15:49:19 -05:00
Vicki League
805b6fe7aa [CL-573] Move all svg icons to new libs/assets (#16020)
* create libs/assets

* treeshake lib and filter out non-icons from icon story

* update docs

* fix icon colors in browser and desktop

* better name for vault icon

* move illustrations
2025-08-21 11:35:59 -05:00
Kyle Denney
f07518084f [PM-24554] remove code for feature flag (#16092) 2025-08-21 09:36:57 -05:00
Bryan Cunningham
b0f46004ff [CL-796] unrevert aria disabled buttons (#15924)
* Use aria-disabled for button disabled state

* remove import from testing story

* use aria-disabled attr on bitLink button

* remove unnecessary story attrs

* remove disabled attr if on button element

* create caprture click util

* use caprture click util and fix tests

* fix lint errors

* fix event type

* combine click capture and attr modification

* fix lint error. Commit spec changes left out of last commit in error

* inject element ref

* move aria-disabled styles to common

* move disabled logic into util

* fix broken async actions stories

* fix broken tests asserting disabled attr

* have test check for string true vlalue

* fix Signal type

* fix form-field story import

* remove injector left in error

* aria-disable icon buttons

* update form component css selector to look for aria-disabled buttons

* use correct types. pass nativeElement directly

* add JSDoc comment for util function

* WIP

* WIP

* inject service in directive

* remove console log

* remove disabled attr left in error

* update comments

* remove unnecessary logic

* remove :disabled psuedo selector as its apparently not needed

* fix event type

* coerce disabled attr to boolean

* remove duplicate style concat left by conflict resolution

* add back buttonStyles default

* move reactive logic back to helper

* add test to ensure menu button doesn't open when trigger is disabled

* remove menu toggle to fix tests

* remove disabled menu story

* Fix usage of bitLink in verify email component

* Update varaible name

* no longer pass destroyRef
2025-08-21 09:14:08 -04:00