1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-18 18:33:50 +00:00
Commit Graph

20371 Commits

Author SHA1 Message Date
Addison Beck
54ac73f53a fix(desktop): restore explicit target to Linux builds (#18169)
Commit a3e654d (https://github.com/bitwarden/clients/pull/16053) removed explicit --target flags from the Linux desktop build workflow when removing musl support. This change inadvertently broke the build.js binary distribution logic, which only copies the desktop_proxy binary to the dist directory when an explicit target is specified. Without this binary in the expected location (/opt/Bitwarden/desktop_proxy), browser integration fails on Linux.

This fix restores explicit --target flags using gnu triplets instead of the previously removed musl triplets. The x64 build now uses --target=x86_64-unknown-linux-gnu and the arm64 build uses --target=aarch64-unknown-linux-gnu, ensuring build.js properly distributes the desktop_proxy binary and restoring browser integration functionality on Linux desktop.
2026-02-17 09:25:44 -08:00
Todd Martin
e7afbac596 chore(deps): Include Cargo dependencies in dep-ownership lint check
* Added Cardo dep ownership.

* Fixed file paths.

* Moved aes-gcm from KM to Tools.
2026-02-17 09:25:43 -08:00
Thomas Avery
e6cb6ee38f [PM-29928] Fix biometrics status check when native messaging permission is missing (#18154)
* Dont check biometrics status when nativeMessaging permission isn't granted

* Increase polling interval and add unit tests
2026-02-17 09:25:43 -08:00
Mick Letofsky
e4323691a4 Revert review Code Triggered by labeled event (#18165) 2026-02-17 09:25:43 -08:00
Maciej Zieniuk
b0000476b1 [PM-27236] account registration v2 for key connector (#17951)
* account registration v2 for key connector

* explicit naming

* test coverage

* missing AccountCryptographicStateService and DI dependencies

* redundant SdkLoadService.Ready

* update sdk version
2026-02-17 09:25:43 -08:00
Maciej Zieniuk
a3e5b94ba9 incorrectly serialized symmetric crypto key in session storage (#18150) 2026-02-17 09:25:42 -08:00
Alex Morask
7fa89cd889 Remove circular invocation / have Account menu use new premium dialog (#17980) 2026-02-17 09:25:42 -08:00
Mick Letofsky
9cf3f601ec Review Code Triggered by labeled event (#18151) 2026-02-17 09:25:42 -08:00
Leslie Tilton
5cf904d819 [PM-28548] Phishing Blocker support links (#18070)
* Change domain terminology to web addresses

* Added phishing resource file

* Finish renaming and adding runtime configuration for domains vs links setting

* Update reference

* Add matching functions per resource

* correct URL matching logic for links-based detection

Problem:
The phishing link matcher was failing to detect known phishing URLs due to
two issues:

1. Protocol mismatch: Entries in the phishing list use `http://` but users
   typically visit `https://` versions. The matcher was comparing full URLs
   including protocol, causing legitimate matches to fail.
   - List entry: `http://smartdapptradxx.pages.dev`
   - User visits: `https://smartdapptradxx.pages.dev/`
   - Result: No match (incorrect)

2. Hostname-only matching would have caused false positives: An earlier
   attempt to fix #1 included hostname-only comparison, which defeats the
   purpose of links-based detection. The goal of PM-28548 is precise URL
   matching to avoid blocking entire domains (like pages.dev, github.io)
   when only specific paths are malicious.

Solution:
- Always strip protocol (http:// or https://) from both entry and URL
  before comparison, treating them as equivalent
- Remove hostname-only matching to maintain precision
- Keep prefix matching for subpaths, query strings, and fragments

---------

Co-authored-by: Alex <adewitt@bitwarden.com>
2026-02-17 09:25:42 -08:00
Ben Brooks
d8fcc0e1af [pm-28077] Add input types to ignoredInputTypes (#17870)
* [pm-28077] Add input types to ignoredInputTypes

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* Merge branch 'main' of github.com:bitwarden/clients into pm-28077-more-ignoredInputTypes-in-CollectAutofillContentService

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* [pm-28077] Remove month input type from ignored types

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* [pm-28077] Remove month radio and checkbox types from ignored types

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* Merge branch 'main' of github.com:bitwarden/clients into pm-28077-more-ignoredInputTypes-in-CollectAutofillContentService

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* [pm-28077] Fix prettier issues/conflicts

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* [pm-28077] Add comment regarding datetime depcrecation

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

---------

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
2026-02-17 09:25:41 -08:00
Daniel Riera
00f265b262 [PM-29515] Remove ts strict ignore in overlay inline menu iframe content autofill inline menu iframe service (#18030)
* use optional chaining and make portkey optional to match the AutofillInlineMenuIframeExtensionMessage

* make ariaAlertElement optional

* tiemouts are set to null for clearing, updated type to match this

* border color is conditionally applied, undefined is acceptable here

* check if aria alerts exist before calling

* return early if no styles exist for updateElementStyles or no position for updateIframePosition

* initilaize timers to null

* non null assert iframe since it is initialized in initMenuIframe which makes it safe to assert non null by lifecycle

* remove optional chainning
2026-02-17 09:25:41 -08:00
aj-bw
4ba75c8cbb replace inline removal with reusable workflow (#18144) 2026-02-17 09:25:41 -08:00
Shane Melton
84e6e01b12 [PM-29209] Fix persistent browser settings berry (#18113)
* [PM-29209] Introduce new autofill nudge service specific to the Browser client

* [PM-29209] Cleanup redundant browser setting checks

* [PM-29209] Ensure nudge is dismissed on nudge button click

* [PM-29209] Add spec file for browser autofill nudge service

* [PM-29209] Cleanup settings-v2 spec file
2026-02-17 09:25:41 -08:00
Daniel Riera
b2acd373cd PM-29509 [LO IMPACT] Remove @ts-strict-ignore in fido2/content/messaging/messenger.ts (#17913)
* PM-29509   [LO IMPACT] Remove @ts-strict-ignore in fido2/content/messaging/messenger.ts - 1 err, 137 LOC, 11.4

* strip metadata from message

* preserve one way handler
2026-02-17 09:25:41 -08:00
Daniel James Smith
2fd29068b9 [BEEEP][PM-29441] Introduce bitwarden-encrypted-json-importer (#17651)
* Introduce bitwarden-encrypted-json-importer

An effort to introduce type guards and split the logic between the differently protected bitwarden-json import-formats

* Improved stricter types, but not quite ts-strict yet

* Add guard to prevent passing password-protected exports to the wrong importer.

* Only create one return object instead of multiple

* Updated changes afer npm ci and npm run prettier

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-02-17 09:25:40 -08:00
Daniel Riera
364cd93b24 [PM-29514] Remove ts strict ignore in overlay notifications content overlay notifications content service (#17947)
* early return on typedata if it is not present

* use optional chaining on null checks

* nullish coallescing operator on potentially undefined type

* optional chaining to check both that the element exists and that contentWindow is not null before calling postMessage

* add null check for this.currentNotificationBarType before calling

* add a null check before appending notificationBarRootElement, ts cant track we set the iframe across method calls

* added null checks before calling setElementStyles
2026-02-17 09:25:40 -08:00
Mark Youssef
4a6575d463 [CL-132] Implement resizable side nav (#16533)
Co-authored-by: Vicki League <vleague@bitwarden.com>
2026-02-17 09:25:40 -08:00
Jason Ng
82014c9fbe [PM-29972] Update Vault Items List When Archiving Ciphers (#18102)
* update default cipher service to use upsert, apply optional userId parameter
2026-02-17 09:25:39 -08:00
shivam
2e400987e4 fix(ui): clean up unintended character on login page (#18101) 2026-02-17 09:25:39 -08:00
Bernd Schoolmann
58f8c7418d [PM-30285] Add soundness check to cipher and folder recovery step (#18120)
* Add soundness check to cipher and folder recovery step

* fix tests

---------

Co-authored-by: Maciej Zieniuk <mzieniuk@bitwarden.com>
2026-02-17 09:25:39 -08:00
Dave
0f826510e9 feat(2fa-webauthn) [PM-20109]: Increase 2FA WebAuthn Security Key Limit (#18040)
* feat(2fa-webauthn) [PM-20109]: Update WebAuthN credential handling.

* feat(messages) [PM-20109]: Add 'Unnamed key' translation.

* refactor(2fa-webauthn) [PM-20109]: Refactor nextId for type safety.

* refactor(2fa-webauthn) [PM-20109]: Clean up template comments.

* fix(webauthn-2fa) [PM-3611]: Key name is required.
2026-02-17 09:25:39 -08:00
renovate[bot]
e5fb63b7f3 [deps]: Update actions/checkout action to v6 (#17715)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2026-02-17 09:25:38 -08:00
Todd Martin
839444a635 chore(feature-flags): Remove notification on inactive and locked user feature flags 2026-02-17 09:25:38 -08:00
Jason Ng
032b6e9fa0 [PM29951] add archive flag check to desktop vault-v2 (#18056) 2026-02-17 09:25:38 -08:00
Daniel James Smith
a54a4b0dad Bump year in copyright (#18132)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-02-17 09:25:37 -08:00
neuronull
282ab77318 Desktop Autotype introduce strict type for keyboard input (#17141)
* Desktop Autotype introduce strict type for keyboard input

* cleanup

* fix doc typo

* unecessary into()

* use str

* propagate error

* better var name

* pass a slice

* doc comment

* napi fix

* add ownership renovate for new dep

* add code comment about modifier keys being released

* fmt

* remove keytar

* fix input struct size compute

* improve debug comment
2026-02-17 09:25:37 -08:00
Github Actions
54e4101d9d Bumped client version(s) 2026-02-17 09:25:37 -08:00
bw-ghapp[bot]
4aaf6f019d Autosync the updated translations (#18130)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-17 09:25:37 -08:00
bw-ghapp[bot]
b37c356852 Autosync the updated translations (#18129)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-17 09:25:37 -08:00
bw-ghapp[bot]
7f26244a9b Autosync the updated translations (#18128)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-17 09:25:36 -08:00
bw-ghapp[bot]
eec6f4c67a Autosync the updated translations (#18118)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-17 09:25:36 -08:00
Alex
06d60525d6 correct virtual scroll rowSize for password reports (#18058)
The Exposed Passwords and Weak Passwords reports were using an incorrect
rowSize value (53px instead of 75px) for their virtual scroll tables.
This caused the \"Back to reports\" button to collide with table entries.

The issue was cumulative - more items meant more visible collision. This
fix aligns both reports with the Reused Passwords report which correctly
uses 75px for identical row structures.
2026-02-17 09:25:36 -08:00
Bryan Cunningham
4d927bc365 [CL-913] add new color palette to theme and tailwind config (#17998)
* add new color palette to theme and tailwind config

* updated docs color names

* remove safelist changes

* add missing accent colors to docs

* updated color mappings

* combined docs in colors.mdx and reference in Claude.md

* add variables for white and black

* updated docs

* updated list rendering style

* more specific docs instructions

* revert to simpler colors docs reference

* remove changes to claude.md

* use rgb color variables to compose semantic
2026-02-17 09:25:36 -08:00
Todd Martin
a5e70e1d1b chore(merge): Fixed date initialization on test 2026-02-17 09:25:35 -08:00
Todd Martin
b09d24155d feat(account): [PM-29545] Update AccountInfo creationDate to use Date instead of string
* Add creationDate of account to AccountInfo

* Added initialization of creationDate.

* Removed extra changes.

* Fixed tests to initialize creation date

* Added helper method to abstract account initialization in tests.

* More test updates.

* Linting

* Additional test fixes.

* Fixed spec reference

* Fixed imports

* Linting.

* Fixed browser test.

* Modified tsconfig to reference spec file.

* Fixed import.

* Removed dependency on os.  This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node.

* Revert "Removed dependency on os.  This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node."

This reverts commit 669f6557b6.

* Updated stories to hard-code new field.

* Removed changes to tsconfig

* Revert "Removed changes to tsconfig"

This reverts commit b7d916e8dc.

* Updated to use Date

* Updated to use Date on sync.

* Changes to tests that can't use mock function

* Prettier updates

* Update equality to handle Date type.

* Change to type comparison.

* Simplified equality comparison to just use properties.

* Added comment.

* Updated comment to reference Date.

* Added back in internal method tests.
2026-02-17 09:25:35 -08:00
Jordan Aasen
c2d6ce5cd0 only pass strings to i18n pipe (#17978) 2026-02-17 09:25:35 -08:00
Jordan Aasen
014778ec3f [PM-26656] - remove AutofillConfirmation feature flag (#18074)
* remove AutofillConfirmation feature flag

* fix tests. remove feature flag tests
2026-02-17 09:25:35 -08:00
Vicki League
21bdfabda4 [PM-30141] Fix page height and a11y by removing extra <main> (#18099) 2026-02-17 09:25:34 -08:00
Bernd Schoolmann
d28019c195 [PM-27239] Tde registration encryption v2 (#17831)
* tmp

* Implement TDE v2 registration via SDK

* Undo encstring test string change

* Add feature flag

* Add tests

* Continue tests

* Cleanup

* Cleanup

* run prettier

* Update to apply new sdk changes

* Fix build

* Update package lock

* Fix tests

---------

Co-authored-by: Bernd Schoolmann <quexten@fedora-2.fritz.box>
2026-02-17 09:25:34 -08:00
Vicki League
505d2fff00 [PM-29819][CL-806] Fix focus mgmt on search and filter page navigations (#18007) 2026-02-17 09:25:34 -08:00
Jared Snider
da5dd1f5f1 PM-30125 - IdentityTokenResponse - mark deprecated properties as such (#18092) 2026-02-17 09:25:34 -08:00
gitclonebrian
684cfd3005 bumped cargo deny version to fix CVSS error (#18091) 2026-02-17 09:25:33 -08:00
Alex Morask
f5bc83c5f7 Remove FF: pm-22415-tax-id-warnings (#17871) 2026-02-17 09:25:33 -08:00
Anders Åberg
ac3d9ce392 chore: move @nx packages to devDependencies (#18062)
These packages are build/tooling dependencies and should not be in
production dependencies.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-17 09:25:33 -08:00
Mike Amirault
a7cdab3c74 [PM-24015] Handle Send form empty password field properly (#17911) 2026-02-17 09:25:33 -08:00
bw-ghapp[bot]
338533eb37 Autosync the updated translations (#18089)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-17 09:25:33 -08:00
bw-ghapp[bot]
9a4d1a5d17 Autosync the updated translations (#18088)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-17 09:25:32 -08:00
bw-ghapp[bot]
cdc74947d3 Autosync the updated translations (#18087)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-02-17 09:25:32 -08:00
Bernd Schoolmann
b4f273edf6 [PM-29929] Exclude organization vault items in data recovery tool (#18044)
* Exclude organization vault items in data recovery tool

* Allow undefined organization id
2026-02-17 09:25:32 -08:00
renovate[bot]
521f4cef8c [deps] Platform: Update electron to v39 (#17301)
* [deps] Platform: Update electron to v39

* Update and change builder

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2026-02-17 09:25:32 -08:00