1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-21 03:43:58 +00:00
Commit Graph

6042 Commits

Author SHA1 Message Date
Anders Åberg
56700b5e7c fix(desktop): remove hardcoded MAS signing identity
The hardcoded SHA1 fingerprint (588E3F1724AE018EBA762E42279DAE85B313E3ED) was
added to fix MAS signing with pnpm, but it doesn't match CI's certificate.
When electron-builder can't find the certificate by hash, it falls back to
ad-hoc signing and incorrectly inherits mac.provisioningProfile instead of
mas.provisioningProfile, causing the build to fail.

Removing the identity field entirely to match main branch behavior:
- electron-builder will auto-discover the correct certificate
- Works in CI where proper certificates are installed
- electron-builder 26.3.6 may have fixed the original pnpm signing issue

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-06 15:50:10 +01:00
Anders Åberg
63205fdfb4 Attempt 200 2025-12-19 23:42:14 +01:00
Anders Åberg
2b8ccac44e Build works? 2025-12-19 20:13:10 +01:00
Anders Åberg
1bcdf79f16 Test excluding pnpm from the store 2025-12-19 13:25:09 +01:00
Anders Åberg
1101a6fce0 Ignore more build deps 2025-12-19 13:09:57 +01:00
Anders Åberg
c3004e1e4b Exclude @nx packages from electron-builder bundle
The @nx packages contain native .node binaries that cause universal
macOS builds to fail. These are build tools that should not be
included in the production bundle.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-19 12:06:13 +01:00
Anders Åberg
cd5c08bf85 try hardcoding the hash of the identity 2025-12-19 11:30:55 +01:00
Anders Åberg
91150b5b87 Just try setting packcage.json in apps/desktop too 2025-12-19 11:21:43 +01:00
Anders Åberg
6b0f876d2d Use pnpm in packacges.json 2025-12-19 10:59:18 +01:00
Anders Åberg
d94574c141 fix(desktop): add explicit MAS signing identity for pnpm compatibility
electron-builder's auto-discovery works for Developer ID but fails for
"3rd Party Mac Developer Application" when running with pnpm. Adding
the explicit identity bypasses this issue.
2025-12-19 10:34:28 +01:00
Anders Åberg
d3f4dc7bdd Merge branch 'main' into anders/pnpm 2025-12-19 08:54:22 +01:00
Mike Amirault
39bc4fb789 [PM-29875] Close Send drawer on navigation (#18031) 2025-12-18 14:48:48 -05:00
neuronull
bb71390da4 Desktop Autotype fix feature triggering in settings menu (#17808) 2025-12-18 12:06:04 -07:00
Shane Melton
ff3582109c [PM-28746] Item transfer event logs (#18032)
* [PM-28746] Add item organization event types and i18n strings

* [PM-28746] Log event when transfer is accepted or declined
2025-12-18 10:20:59 -08:00
cyprain-okeke
ef7b66ad0d [PM 29079]Remove code for pm-24033-updat-premium-subscription-page (#17905)
* Remove the feature flag

* delete and rename CloudHostedPremiumVNextComponent
2025-12-18 17:35:48 +01:00
Alex Morask
2afa36f598 [PM-21421] Show current plan instead of legacy plan when resubscribing (#17949)
* Show current plan instead of legacy plan when resubscribing

* Claude / Kyle feedback
2025-12-18 09:12:23 -06:00
renovate[bot]
42e7fdf48a [deps] Platform: Update @types/node to v22.19.3 (#17991)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-18 08:02:02 -07:00
Bernd Schoolmann
a4e5c9ab37 Add .desktop file for flatpak dev build (#18018) 2025-12-18 14:35:30 +01:00
John Harrington
9db632146b PM-22836 Import popout crashes unexpectedly (#16928)
* follow existing popout guard pattern to force popout on firefox when filepicker is exposed

* move firefox guard to tools ownership & revert changes to auth owned file

* removed redundant test case
2025-12-17 14:38:18 -07:00
Bernd Schoolmann
ea45c5d3c0 [PM-27315] Add account cryptographic state service (#17589)
* Update account init and save signed public key

* Add account cryptographic state service

* Fix build

* Cleanup

* Fix build

* Fix import

* Fix build on browser

* Fix

* Fix DI

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix test

* Fix desktop build

* Fix

* Address nits

* Cleanup setting private key

* Add tests

* Add tests

* Add test coverage

* Relative imports

* Fix web build

* Cleanup setting of private key
2025-12-17 22:04:08 +01:00
cyprain-okeke
bcbf013cd9 [PM 27122] Individual subscription page for self-hosted customers (#17517)
* implement the self-host subscription changes

* Correct few ui changes

* Update to h1

* PR review changes

* Changes for the async cancel

* Resolve the two bug issues

* implement the review comments

* Resolve the Active issue

* Fix the space issues

* Remove the tabs for billing and payment

* revert the self-host changes

* Fix the subtitle issue
2025-12-17 21:13:18 +01:00
Bryan Cunningham
5504d49751 [CL-927] add popup header back to extension layout for now (#18023)
* add popup header back to extension layout for now

* conditionally add margin for now if not hiding logo
2025-12-17 15:02:37 -05:00
Alex Dragovich
930cb9ab96 [PM-29896] specify noun or verb for Import / Export terms (#18012)
* [PM-29896] specify noun or verb for Import / Export terms

* [PM-29896] adjust verb to noun
2025-12-17 11:24:44 -08:00
bw-ghapp[bot]
8087a972d5 Autosync the updated translations (#18025)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-12-17 19:09:11 +00:00
bw-ghapp[bot]
e6e54a0a77 Autosync the updated translations (#18027)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-12-17 19:08:06 +00:00
Shane Melton
a12c7a31fd Fix broken valut-settings-v2 tests (#18029) 2025-12-17 10:30:33 -08:00
Jared Snider
cbd80d0186 refactor(IdentityTokenResponse): [Auth/PM-3287] Remove deprecated resetMasterPassword property from IdentityTokenResponse (#17794)
* PM-3287 - Remove resetMasterPassword from authResult and identityTokenResponse and replace with userDecryptionOptions where relevant

* PM-3287 - (1) Move SSO code to SSO section (2) Update error scenario conditional + log user out upon error.

* PM-3287 - Fix comment per PR feedback

* PM-3287 - CLI Login with SSO - move MP validation logic back to original location to avoid putting it before 2FA rejection handling.

* PM-3287 - Update returns
2025-12-17 10:34:42 -05:00
Alex
b0fcd92f35 add padding between name and icons in health reports (#18002)
Added tw-ml-1 class to shared (bwi-collection-shared) and attachment
(bwi-paperclip) icons in report tables to add spacing between the
item name and icons.

Affected reports:
- Weak passwords
- Exposed passwords
- Reused passwords
- Unsecured websites
- Inactive two-factor
- Emergency access view

(PM-29488)
2025-12-17 07:23:33 -08:00
Leslie Tilton
78f4947d00 [PM-25884] Disable phishing detection if safari is detected (#17655)
* Disable phishing detection if safari is detected

* Apply suggestion from @claude[bot]

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Move order of safari vs account checks

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
2025-12-17 09:23:09 -06:00
Bernd Schoolmann
e6062ec84e Fix agent crashing when account switching (#17868) 2025-12-17 15:16:02 +01:00
Bernd Schoolmann
24dcbb48c6 [PM-29418] Fix SSH list not working while locked (#17866)
* Fix SSH list not working while locked

* Add tests

* Update private key to SDK test key

* Cleanup
2025-12-17 12:00:13 +01:00
Bernd Schoolmann
3114b31920 Fix slow agent operations (#17867) 2025-12-17 11:59:40 +01:00
Bernd Schoolmann
4846d217a9 [PM-28901] Fix master key not being set to state after kdf update (#17990)
* Fix master key not being set to state after kdf update

* Fix cli build

* Fix test error

* Fix hash purpose

* Add test for master key being set

* Fix incorrect variable name
2025-12-17 10:57:24 +01:00
Maciej Zieniuk
ced97a4467 cli status command shows locked status when unlocked (#17708) 2025-12-17 10:19:11 +01:00
Jason Ng
ba1c74b905 [PM-29286] clear selected items when filter is changed (#17929)
* check filter inside vault-items and clear on change
2025-12-16 18:04:54 -05:00
Shane Melton
06d15e9681 [PM-27675] Browser item transfer integration (#17918)
* [PM-27675] Integrate dialogs into VaultItemTransferService

* [PM-27675] Update tests for new dialogs

* [PM-27675] Center dialogs and prevent closing with escape or pointer events

* [PM-27675] Add transferInProgress$ observable to VaultItemsTransferService

* [PM-27675] Hook vault item transfer service into browser vault component

* [PM-27675] Move defaultUserCollection$ to collection service

* [PM-27675] Cleanup dialog styles

* [PM-27675] Introduce readySubject to popup vault component to keep prevent flashing content while item transfer is in progress

* [PM-27675] Fix vault-v2 tests
2025-12-16 15:03:48 -08:00
Nick Krantz
3049cfad7d [PM-29103] Premium Prompt for Archive (#17800)
* prompt for premium using badge workflow rather than premium page

* update test

* address claude feedback
2025-12-16 15:47:58 -06:00
neuronull
ac0a0fd219 Desktop Autotype toggle on vault lock/unlock (#17062)
* Desktop Autotype toggle on vault lock/unlock

* lint

* add back disable on will-quit signal

* improve IPC message args

* claude: takeUntilDestroyed

* claude: try/catch

* claude: multiple listeners

* claude: ===

* claude: concatMap

* claude: IPC Handler Registration in Constructor

* claude: helper function

* claude: Type Safety for IPC Messages

* fix claude suggestion?

* bit by commit hook file write again

* remove the type qualifier

* add log svc dep

* move the initialized ipcs back to constructor

* frageele?

* try disable premium check

* replace takeUntilDestroy with takeUntil(destroy)

* add import

* create separate observable for premium check

* clean up and remove distinctUntilChanged

* re-add distinctUntilChanged

* ipc handlers in init

* check double initialization

* Revert "check double initialization"

This reverts commit 8488b8a613.

* Revert "ipc handlers in init"

This reverts commit a23999edcf.

* ipc out of constructor

* claude suggestion does not compile, awesome

* add a dispose method for cleanup of ipc handlers

* claude: remove of(false) on observable initializing

* claude: remove the init/init'd

* claude: remove takeUntil on isPremiumAccount

* Revert "claude: remove takeUntil on isPremiumAccount"

This reverts commit 9fc32c5fcf.

* align models file name with interface name

* rename ipc listeners function

* improve debug log message

* improve debug log message

* remove reference to not present observable in unit test

* add function comment

* make `autotypeKeyboardShortcut` private
2025-12-16 13:00:56 -07:00
Mike Amirault
b63e1cb26c [PM-28181] Open send dialog in drawer instead of popup in refreshed UI (#17666)
* [PM-28181] Open send dialog in drawer instead of popup in refreshed UI

* Fix types

* [PM-28181] Use drawer to edit sends with refreshed UI

* [PM-28181] Address bug where multiple Sends could not be navigated between
2025-12-16 13:34:31 -05:00
bw-ghapp[bot]
78784f509d Autosync the updated translations (#17935)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-12-16 19:11:06 +01:00
Nick Krantz
25bd2a4c34 move archive check into conditional to avoid undefined error (#18000) 2025-12-16 12:08:03 -06:00
bw-ghapp[bot]
b1591da1b2 Autosync the updated translations (#17936)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-12-16 16:46:31 +01:00
renovate[bot]
d2b48df9c0 [deps] AC: Update core-js to v3.47.0 (#17032)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-16 09:18:02 -06:00
cyprain-okeke
d7a7f19abd [PM-29633]Discount badge misaligned on Subscription page for Organizations and MSP/BUP (#17924)
* Fix the discount

* Fix the spacing and alignment issue

* reverted unneeded change

* Changes for provider discount badge
2025-12-16 14:55:40 +01:00
Anders Åberg
9d7c8efb73 Try running it via node 2025-12-16 11:43:57 +01:00
Anders Åberg
a1f015e858 Also try pnpm exec instead 2025-12-16 11:39:32 +01:00
Anders Åberg
76316927cf just try running from node_modules 2025-12-16 11:39:03 +01:00
Anders Åberg
d96639db8d use @electron/rebuild 2025-12-16 11:33:44 +01:00
Anders Åberg
aa5fb77427 Use npx
pnpm runs the postinstall script for apps/desktop, the electron-rebuild
binary isn't in PATH. The binary is at root node_modules/.bin/, but the
script runs from apps/desktop/.
2025-12-16 11:09:04 +01:00
Anders Åberg
cb619ddb84 Pin open at 8.4.2 instead 2025-12-16 11:05:18 +01:00