1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-02 17:53:41 +00:00
Commit Graph

5801 Commits

Author SHA1 Message Date
rr-bw
58372116cf remove validationService and update logService messages 2025-11-12 12:10:02 -08:00
rr-bw
23af699b98 Merge branch 'main' into auth/pm-26209/bugfix-desktop-error-on-auth-request-approval 2025-11-12 11:34:58 -08:00
rr-bw
8e81218313 update variable name 2025-11-12 11:03:13 -08:00
rr-bw
6c49612fd9 address PR feedback: 'Consider error handling in do/while loop' and prevent an infinite loop 2025-11-12 10:42:40 -08:00
Github Actions
9852027e98 Bumped client version(s) 2025-11-12 16:45:12 +00:00
Github Actions
338ea95535 Bumped client version(s) 2025-11-12 16:18:17 +00:00
Bernd Schoolmann
f2e485ec8e [PM-27847] Enable biometric IPC on mac dmg (#16247)
* Enable biometric IPC on mac dmg

* Remove i18n string
2025-11-12 15:00:46 +00:00
Nick Krantz
d71add85e8 [PM-25084] Vault Skeleton loading (#17321)
* add import to overflow styles to override the overflow applied by virtual scrolling

* add position relative so absolute children display in scrolling context rather over the entire page

* add fade in skeleton to vault page

* refactor vault loading state to shared service

* disable search while loading

* add live announcement when vault is loading / loaded

* simplify announcement

* resolve CI issues

* add feature flag for skeletons

* add feature flag observables for loading state

* update component naming
2025-11-12 08:31:25 -06:00
rr-bw
859494fb4e merge main 2025-11-11 15:38:39 -08:00
rr-bw
b9d9e30801 address PR feedback 'Race condition with concurrent auth requests' 2025-11-11 15:31:39 -08:00
Stephon Brown
421edfb020 [PM-28034] Pre-Launch Payment Defect Solution (#17331)
* fix(billing): update to password manager to signal

* fix(billing): take first value so the dialog doesn't show again

* fix(billing): add families plan to request builder

* fix(billing): feedback and type update

* fix(billing): fix selectedplan call
2025-11-11 15:51:01 -05:00
rr-bw
3683c213b2 update service test descriptions for clarity 2025-11-11 10:17:21 -08:00
Alex
089caf57c2 [PM-27757] init new apps state (#17200)
* feat(dirt): add "needs review" state for applications needing initial review

- Add showNeedsReviewState to display warning when all apps lack review dates
- Track noAppsHaveReviewDate flag to identify unreviewed applications
- Add i18n strings for organization items count and review prompt
- Update activity card to show 3 states: all caught up, needs review, new apps
- Apply tw-col-span-2 to needs review card for better visibility

* refactor: split activity card states into separate @if blocks for readability

* fix: set hasLoadedApplicationData when summary data arrives

Previously, hasLoadedApplicationData was only set in the enrichedReportData$
subscription, which fired after reportSummary$ and newApplications$. This
caused a timing issue where showNeedsReviewState would remain false even when
newApplicationsCount === totalApplicationCount because the flag wasn't set yet.

Now we set hasLoadedApplicationData=true as soon as reportSummary$ arrives
with totalApplicationCount > 0, ensuring proper synchronization.

---------

Co-authored-by: Tom <ttalty@bitwarden.com>
2025-11-11 13:11:33 -05:00
rr-bw
458227cec3 update activeUserMeetsConditionsToShowApprovalDialog() and param name for clarity 2025-11-11 09:52:22 -08:00
Jordan Aasen
b05abdb99c [PM-24066] - handle unknown ciphers in individual vault (#17323)
* handle unknown ciphers in individual vault

* handle in edit
2025-11-11 09:26:57 -08:00
Alex Morask
09b6c35d9f [PM-279699] Clear premium interest when user subscribes or closes dialog (#17221)
* Clear premium interest when user subscribes to premium or backs out of dialog

* Kyle's feedback
2025-11-11 10:51:46 -06:00
Kyle Denney
3c1262c999 [PM-27854] close dialog when redirecting to premium page (#17243) 2025-11-11 10:32:07 -06:00
Maciej Zieniuk
021d3e53aa [PM-26056] Consolidated session timeout component (#16988)
* consolidated session timeout settings component

* rename preferences to appearance

* race condition bug on computed signal

* outdated header for browser

* unnecessary padding

* remove required on action, fix build

* rename localization key

* missing user id

* required

* cleanup task

* eslint fix signals rollback

* takeUntilDestroyed, null checks

* move browser specific logic outside shared component

* explicit input type

* input name

* takeUntilDestroyed, no toast

* unit tests

* cleanup

* cleanup, correct link to deprecation jira

* tech debt todo with jira

* missing web localization key when policy is on

* relative import

* extracting timeout options to component service

* duplicate localization key

* fix failing test

* subsequent timeout action selecting opening without dialog on first dialog cancellation

* default locale can be null

* unit tests failing

* rename, simplifications

* one if else feature flag

* timeout input component rendering before async pipe completion
2025-11-11 08:15:36 -06:00
rr-bw
5b23ff60bf address PR feedback: 'missing null safety check' 2025-11-10 15:08:43 -08:00
Vicki League
c22cba76ec [PM-26984] Use medium instead of semibold or bold, and for headings (#17184) 2025-11-10 17:11:35 -05:00
SmithThe4th
1cfeef2395 Removed unused dependency (#17319) 2025-11-10 20:06:12 +00:00
Kyle Denney
e3acd27dec [PM-24284] - milestone 3 (#17230)
* first draft

# Conflicts:
#	apps/web/src/app/billing/individual/upgrade/upgrade-payment/services/upgrade-payment.service.ts
#	apps/web/src/app/billing/organizations/organization-plans.component.ts
#	libs/common/src/billing/services/subscription-pricing.service.ts
#	libs/common/src/enums/feature-flag.enum.ts

* more filtering for pricing cards

* prettier

* tests

* tests v2
2025-11-10 11:50:49 -06:00
bw-ghapp[bot]
f4e1e5982a Autosync the updated translations (#17272)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-11-10 18:26:08 +01:00
bw-ghapp[bot]
c47e7c3acb Autosync the updated translations (#17270)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-11-10 10:47:17 -06:00
Patrick-Pimentel-Bitwarden
e9e731ecba fix(beta-tag-removal): [PM-26457] Remove Beta Tag Passkey Login (#17226)
* fix(beta-tag-removal): [PM-26457] Remove Beta Tag Passkey Login - Removed beta tag and locale string for login with passkey.
2025-11-10 11:01:24 -05:00
Alex
2f3f2c2105 [PM-27737] text and triangle color (#17198) 2025-11-10 10:33:43 -05:00
rr-bw
8f79c924d5 update abstraction 2025-11-10 07:33:37 -08:00
renovate[bot]
e7995256cd [deps] Platform: Update @types/node to v22.19.0 (#17297)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-11-10 10:29:58 -05:00
Rui Tomé
cb863b44d5 [PM-26430] Remove Type property from PolicyRequestModel to use route parameter only (#16960)
* Remove Type property from PolicyRequestModel to use route parameter only

* Remove PolicyType property from policy update request in auto-confirm edit policy dialog

* Run prettier
2025-11-10 15:27:48 +00:00
rr-bw
5308685494 Merge branch 'main' into auth/pm-26209/bugfix-desktop-error-on-auth-request-approval 2025-11-10 06:53:41 -08:00
Oscar Hinton
ed53ef19d9 [PM-27897] Fix release before use in chromium importer (#17276)
We ran into some weird issues where the memory was corrupted on certain architectures. It turns out we free'd memory before using it.

This ensures we make a copy of the data before freeing it, and extracts a common function for both crates to use.
2025-11-10 14:15:15 +01:00
bw-ghapp[bot]
275c6a93b4 Autosync the updated translations (#17271)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-11-10 08:40:12 +01:00
rr-bw
ed72ea4284 update tests for DefaultAuthRequestAnsweringService 2025-11-08 07:45:03 -08:00
rr-bw
62d9cad5e9 update desktop service tests 2025-11-07 16:42:21 -08:00
rr-bw
84df82efac restructure service architecture 2025-11-07 16:39:46 -08:00
Brandon Treston
19626d1b3e [PM-26363] Add one time setup dialog for auto confirm (#17104)
* add one time setup dialog for auto confirm

* add one time setup dialog for auto confirm

* fix copy, padding, cleanup observable logic

* cleanup

* cleanup

* refactor

* clean up

* more cleanup

* Fix deleted files

This reverts commit 7c18a5e512.
2025-11-07 15:58:39 -05:00
rr-bw
6f1179cde3 Merge branch 'main' into auth/pm-26209/bugfix-desktop-error-on-auth-request-approval 2025-11-07 11:22:14 -08:00
rr-bw
d50f06aece update test in ExtensionAuthRequestAnsweringService 2025-11-07 11:07:36 -08:00
rr-bw
96d6046989 update Desktop VaultV2Component message sending 2025-11-07 10:46:55 -08:00
Bernd Schoolmann
4f9ae78598 [PM-27515] Fix 2fa settings not working after KDF change (#17070)
* Always derive authentication data fresh for UV

* Cleanup

* Add tests

* Fix remote UV

* Fix test

* Fix test

* Address feedback

* Fix build

* Update libs/common/src/auth/types/verification.ts

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Remove unused var

* Fix relative import

* Fix types

---------

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
2025-11-07 18:36:02 +01:00
Matt Gibson
40ec682b78 [PM-27888] [PM-27889][PM-27914][PM-27820] Use frame Id as test for internal source. (#17266)
* Use frame Id as test for internal source.

* prefer strong equality

* Fix tests
2025-11-07 11:58:35 -05:00
Jonathan Prusik
0ef4964b2e [PM-27569] Typing cleanup (#17087)
* typing cleanup

* additional cleanup

* more typing fixes

* revert notification background changes

* fix DOM query service breakage

* do not run a fill_by_opid action if there is a nullish or empty value attribute

* type cleanup

* cleanup per review suggestions

* remove unused flag check

* add non-null assertion signposts

* additional cleanup
2025-11-07 11:34:08 -05:00
neuronull
146f612fbd Fix Desktop app tokio thread panic autofill service on unsupported platforms (#17218) 2025-11-07 09:27:17 -07:00
aj-bw
f992b80161 [bre-1149] linux desktop arm builds - continuation of community PR#16096 (#17254)
* adding arm64 snap, flatpak and tar variant to releases now for future flatpak consumption
* adding arm64 snap, flatpak and tar build process

---------

Co-authored-by: fredrmb <69513590+fredrmb@users.noreply.github.com>
2025-11-07 10:31:53 -05:00
Maximilian Power
a0bba3957b Add progress tracking to risk insights report generation (#17199)
* Add progress tracking to risk insights report generation

* added skeleton page loader
2025-11-07 09:03:58 -05:00
Jordan Aasen
4bf90b0fb3 [PM-27754] - [Defect] MP prompt is missing before "Cannot autofill" modal when trying to autofill a login with "Exact" default matching set (#17247)
* add persistent callout in settings for non-premium users

* always call password reprompt in doAutofill

* ensure password reprompt is checked in all instances

* Revert "add persistent callout in settings for non-premium users"

This reverts commit d206832cd3.
2025-11-06 15:55:31 -08:00
Daniel James Smith
3c2f44095a [PM-27656] Show error message when detecting Chromium v3 encryption, which isn't supported yet (#17156)
* Replace any-returns with types

* Show an error message when a failure from the native call is returned

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2025-11-06 20:53:13 +01:00
Will Martin
1be9e19fad [PM-26944] fix(browser/phishing-detection): fix various issues (#17197) 2025-11-06 12:55:18 -06:00
Maximilian Power
e9a25d4e8c [PM-27722] Deprecate risk insights terminology and rename to access intelligence (#17170)
* Deprecate risk insights terminology and rename to access intelligence
2025-11-06 18:53:32 +00:00
Maciej Zieniuk
ff12e672e6 [PM-23614] Remove activeUserOrgKeys$ from the key service (#17045)
* Remove activeUserOrgKeys$ from the key service

* test leftover

* test leftover
2025-11-06 19:27:13 +01:00