1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Commit Graph

19858 Commits

Author SHA1 Message Date
cyprain-okeke
7989ad7b7c [PM-26682] [Milestone 2d] Display discount on subscription page (#17229)
* The discount badge implementation

* Use existing flag

* Added the top spaces as requested

* refactor: move discount-badge to pricing library and consolidate discount classes

* fix: add CommonModule import to discount-badge component and simplify discounted amount calculation

- Add CommonModule import to discount-badge component for *ngIf directive
- Simplify discountedSubscriptionAmount to use upcomingInvoice.amount from server instead of manual calculation

* Fix the lint errors

* Story update

---------

Co-authored-by: Alex Morask <amorask@bitwarden.com>
2025-11-12 20:38:13 +01:00
renovate[bot]
9786594df3 [deps]: Update Minor github-actions updates (#14923)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-12 13:18:42 -05:00
Github Actions
9852027e98 Bumped client version(s) 2025-11-12 16:45:12 +00:00
Github Actions
338ea95535 Bumped client version(s) 2025-11-12 16:18:17 +00:00
Mick Letofsky
1cc1a79e09 Refactor the review code prompt to precisely target our clients repo (#17329)
* Refactor the review code prompt to precisely target our clients repo
* Implement wording refactoring away from "migration" terminology
2025-11-12 17:05:13 +01:00
Bernd Schoolmann
f2e485ec8e [PM-27847] Enable biometric IPC on mac dmg (#16247)
* Enable biometric IPC on mac dmg

* Remove i18n string
2025-11-12 15:00:46 +00:00
Nick Krantz
d71add85e8 [PM-25084] Vault Skeleton loading (#17321)
* add import to overflow styles to override the overflow applied by virtual scrolling

* add position relative so absolute children display in scrolling context rather over the entire page

* add fade in skeleton to vault page

* refactor vault loading state to shared service

* disable search while loading

* add live announcement when vault is loading / loaded

* simplify announcement

* resolve CI issues

* add feature flag for skeletons

* add feature flag observables for loading state

* update component naming
2025-11-12 08:31:25 -06:00
Vicki League
2762d46c34 [CL-806] Use header as autofocus target for dialog component (#17336) 2025-11-12 09:20:25 -05:00
Graham Walker
6aff1c4998 PM-23810 [error: cannot decrypt] shows in Member Access Report (#17103)
* PM-23810 fixing ux issue for member access report export csv

* PM-23810 merged in new KM changes and filter nulls within the collectionName array

* PM-23810 fixing type error

* PM-23810 removing unit test as it was based on a previous solution.
2025-11-12 07:42:25 -06:00
Daniel James Smith
7bac09503d Remove team-tools-dev from owning localization (#17308)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-11-12 11:02:13 +01:00
Stephon Brown
421edfb020 [PM-28034] Pre-Launch Payment Defect Solution (#17331)
* fix(billing): update to password manager to signal

* fix(billing): take first value so the dialog doesn't show again

* fix(billing): add families plan to request builder

* fix(billing): feedback and type update

* fix(billing): fix selectedplan call
2025-11-11 15:51:01 -05:00
Nick Krantz
785b1cfdd2 add skeleton loader feature flag (#17337) 2025-11-11 14:20:53 -06:00
Alex
089caf57c2 [PM-27757] init new apps state (#17200)
* feat(dirt): add "needs review" state for applications needing initial review

- Add showNeedsReviewState to display warning when all apps lack review dates
- Track noAppsHaveReviewDate flag to identify unreviewed applications
- Add i18n strings for organization items count and review prompt
- Update activity card to show 3 states: all caught up, needs review, new apps
- Apply tw-col-span-2 to needs review card for better visibility

* refactor: split activity card states into separate @if blocks for readability

* fix: set hasLoadedApplicationData when summary data arrives

Previously, hasLoadedApplicationData was only set in the enrichedReportData$
subscription, which fired after reportSummary$ and newApplications$. This
caused a timing issue where showNeedsReviewState would remain false even when
newApplicationsCount === totalApplicationCount because the flag wasn't set yet.

Now we set hasLoadedApplicationData=true as soon as reportSummary$ arrives
with totalApplicationCount > 0, ensuring proper synchronization.

---------

Co-authored-by: Tom <ttalty@bitwarden.com>
2025-11-11 13:11:33 -05:00
Jordan Aasen
b05abdb99c [PM-24066] - handle unknown ciphers in individual vault (#17323)
* handle unknown ciphers in individual vault

* handle in edit
2025-11-11 09:26:57 -08:00
Alex Morask
09b6c35d9f [PM-279699] Clear premium interest when user subscribes or closes dialog (#17221)
* Clear premium interest when user subscribes to premium or backs out of dialog

* Kyle's feedback
2025-11-11 10:51:46 -06:00
Kyle Denney
3c1262c999 [PM-27854] close dialog when redirecting to premium page (#17243) 2025-11-11 10:32:07 -06:00
Oscar Hinton
84340cba5c Log actual import error (#17327) 2025-11-11 16:56:59 +01:00
renovate[bot]
a017e27890 [deps] Autofill: Update tabbable to v6.3.0 (#17296)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-11 16:43:18 +01:00
Vijay Oommen
e5775ffe7d [PM-23375] Replace drawer with dialog (#17176) 2025-11-11 09:05:38 -06:00
Matt Andreko
ec5081a7e9 Clean up workflow files for Zizmor (#17318) 2025-11-11 09:58:49 -05:00
Maciej Zieniuk
021d3e53aa [PM-26056] Consolidated session timeout component (#16988)
* consolidated session timeout settings component

* rename preferences to appearance

* race condition bug on computed signal

* outdated header for browser

* unnecessary padding

* remove required on action, fix build

* rename localization key

* missing user id

* required

* cleanup task

* eslint fix signals rollback

* takeUntilDestroyed, null checks

* move browser specific logic outside shared component

* explicit input type

* input name

* takeUntilDestroyed, no toast

* unit tests

* cleanup

* cleanup, correct link to deprecation jira

* tech debt todo with jira

* missing web localization key when policy is on

* relative import

* extracting timeout options to component service

* duplicate localization key

* fix failing test

* subsequent timeout action selecting opening without dialog on first dialog cancellation

* default locale can be null

* unit tests failing

* rename, simplifications

* one if else feature flag

* timeout input component rendering before async pipe completion
2025-11-11 08:15:36 -06:00
Andreas Coroiu
a66227638e Update sdk-internal to 374 (fix breaking changes) (#17325)
* feat: update sdk-internal

* fix: symbol.dispose breaking change

* fix: TextEncoder/Decoder breaking change

* fix: move polyfills to a global setup script

* typo
2025-11-11 15:01:03 +01:00
Addison Beck
97ce47b832 build: swap to a workflow_dispatch trigger for sdk breaking change detection (#17314)
* swap to repository dispatch

Introduces GitHub Actions workflow that detects TypeScript breaking changes when SDK artifacts are updated. Workflow is triggered via repository_dispatch from SDK repository and runs npm test:types with newly built SDK artifacts.

The workflow downloads SDK build artifacts, installs them locally, and executes the existing TypeScript type checking process. Exit codes determine success/failure for SDK repository monitoring via gh run watch.

Addresses issue where breaking changes in SDK are discovered only when clients attempt SDK version updates, rather than during SDK development.

* review: claude fixes
2025-11-11 07:57:58 -05:00
Andreas Coroiu
dcabc0165a lint: apply zizmor auto-fixes (#17306) 2025-11-11 09:33:27 +01:00
Vicki League
c22cba76ec [PM-26984] Use medium instead of semibold or bold, and for headings (#17184) 2025-11-10 17:11:35 -05:00
Bryan Cunningham
c25cd63022 [CL-924] fix nested nav indentation (#17317)
* fix nav indentation

* move padding logic to component

* add jsdoc for padding calculation

* access open value correctly
2025-11-10 16:27:35 -05:00
brandonbiete
c3f4e9b12c [BRE-1302] Update deprecated macos 13 runners (#17312)
* [BRE-1302] Update runner to macos-15 for build-browser workflow on build-safari job

* [BRE-1302] Remove macos-13 and 14, add macos-15 to os matrix for build-cli

* [BRE-1302] Update macos runner to 15 and add python setup step before setuptools install

* [BRE-1302] Update macos runner to 15 for 2 additional jobs and add python setup step
2025-11-10 15:41:49 -05:00
SmithThe4th
1cfeef2395 Removed unused dependency (#17319) 2025-11-10 20:06:12 +00:00
Kyle Denney
e3acd27dec [PM-24284] - milestone 3 (#17230)
* first draft

# Conflicts:
#	apps/web/src/app/billing/individual/upgrade/upgrade-payment/services/upgrade-payment.service.ts
#	apps/web/src/app/billing/organizations/organization-plans.component.ts
#	libs/common/src/billing/services/subscription-pricing.service.ts
#	libs/common/src/enums/feature-flag.enum.ts

* more filtering for pricing cards

* prettier

* tests

* tests v2
2025-11-10 11:50:49 -06:00
Bryan Cunningham
c8281a079b skip tooltip stories in chromatic (#17315) 2025-11-10 12:49:14 -05:00
bw-ghapp[bot]
f4e1e5982a Autosync the updated translations (#17272)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-11-10 18:26:08 +01:00
bw-ghapp[bot]
c47e7c3acb Autosync the updated translations (#17270)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-11-10 10:47:17 -06:00
Patrick-Pimentel-Bitwarden
e9e731ecba fix(beta-tag-removal): [PM-26457] Remove Beta Tag Passkey Login (#17226)
* fix(beta-tag-removal): [PM-26457] Remove Beta Tag Passkey Login - Removed beta tag and locale string for login with passkey.
2025-11-10 11:01:24 -05:00
Patrick-Pimentel-Bitwarden
5aa6d38d80 feat(prelogin): [Auth/PM-23801] Move Prelogin Request (#17080)
* feat(prelogin): [PM-23801] Move Prelogin Request - Initial implementation.

* test(prelogin): [PM-23801] Move Prelogin Request - Removed unneeded test.
2025-11-10 10:54:25 -05:00
Kyle Denney
f7899991a0 [PM-23713] always append query param to premium redirect (#17240) 2025-11-10 09:51:51 -06:00
Alex
2f3f2c2105 [PM-27737] text and triangle color (#17198) 2025-11-10 10:33:43 -05:00
renovate[bot]
e7995256cd [deps] Platform: Update @types/node to v22.19.0 (#17297)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-11-10 10:29:58 -05:00
Rui Tomé
cb863b44d5 [PM-26430] Remove Type property from PolicyRequestModel to use route parameter only (#16960)
* Remove Type property from PolicyRequestModel to use route parameter only

* Remove PolicyType property from policy update request in auto-confirm edit policy dialog

* Run prettier
2025-11-10 15:27:48 +00:00
Oscar Hinton
ed53ef19d9 [PM-27897] Fix release before use in chromium importer (#17276)
We ran into some weird issues where the memory was corrupted on certain architectures. It turns out we free'd memory before using it.

This ensures we make a copy of the data before freeing it, and extracts a common function for both crates to use.
2025-11-10 14:15:15 +01:00
bw-ghapp[bot]
275c6a93b4 Autosync the updated translations (#17271)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-11-10 08:40:12 +01:00
Brandon Treston
19626d1b3e [PM-26363] Add one time setup dialog for auto confirm (#17104)
* add one time setup dialog for auto confirm

* add one time setup dialog for auto confirm

* fix copy, padding, cleanup observable logic

* cleanup

* cleanup

* refactor

* clean up

* more cleanup

* Fix deleted files

This reverts commit 7c18a5e512.
2025-11-07 15:58:39 -05:00
Leslie Tilton
ec07a5391a [PM-27762] Activity Tab - Password Change Progress - Assign tasks for new passwords (#17268)
* Update type guard for cipher ids on reports

* Update report model cipher id type and mock data

* Update security tasks api service to have copied getAllTasks function from the vault team

* Expose critical application at risk cipher ids

* Update cipher id type in report service. Update all activities service to move task function to task service

* Update module

* Update organization id sharing through components instead of multiple route fetchings

* Update view type of password change widget. Update variables to be signals. Refactor logic for calculations based on individual tasks

* Update usage of request password change function

* Update security tasks service to manage tasks

* Remove unused variable

* Alphabetized functions, added documentation. Removed injectable decorator

* Alphabetize constructor params for password health service

* Update providers

* Address NaN case on percentage. Address obsolete type casting to CipherID and any other claude comments

* Fix dependency array in test case
2025-11-07 12:04:05 -06:00
Bernd Schoolmann
4f9ae78598 [PM-27515] Fix 2fa settings not working after KDF change (#17070)
* Always derive authentication data fresh for UV

* Cleanup

* Add tests

* Fix remote UV

* Fix test

* Fix test

* Address feedback

* Fix build

* Update libs/common/src/auth/types/verification.ts

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Remove unused var

* Fix relative import

* Fix types

---------

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
2025-11-07 18:36:02 +01:00
Matt Gibson
40ec682b78 [PM-27888] [PM-27889][PM-27914][PM-27820] Use frame Id as test for internal source. (#17266)
* Use frame Id as test for internal source.

* prefer strong equality

* Fix tests
2025-11-07 11:58:35 -05:00
Jonathan Prusik
0ef4964b2e [PM-27569] Typing cleanup (#17087)
* typing cleanup

* additional cleanup

* more typing fixes

* revert notification background changes

* fix DOM query service breakage

* do not run a fill_by_opid action if there is a nullish or empty value attribute

* type cleanup

* cleanup per review suggestions

* remove unused flag check

* add non-null assertion signposts

* additional cleanup
2025-11-07 11:34:08 -05:00
neuronull
146f612fbd Fix Desktop app tokio thread panic autofill service on unsupported platforms (#17218) 2025-11-07 09:27:17 -07:00
Alex
c0b3cfd76e fix: show correct title/description in new applications dialog based on critical apps state (#17275)
- Show "Prioritize critical applications" when org has no critical apps
- Show "Review new applications" when org already has critical apps
- Add hasExistingCriticalApplications flag to dialog data
- Add reviewNewApplications i18n keys
2025-11-07 08:03:02 -08:00
SmithThe4th
519889f8f4 Persist ssh key changes when extension loses focus (#17267) 2025-11-07 10:54:04 -05:00
aj-bw
f992b80161 [bre-1149] linux desktop arm builds - continuation of community PR#16096 (#17254)
* adding arm64 snap, flatpak and tar variant to releases now for future flatpak consumption
* adding arm64 snap, flatpak and tar build process

---------

Co-authored-by: fredrmb <69513590+fredrmb@users.noreply.github.com>
2025-11-07 10:31:53 -05:00
Maximilian Power
a0bba3957b Add progress tracking to risk insights report generation (#17199)
* Add progress tracking to risk insights report generation

* added skeleton page loader
2025-11-07 09:03:58 -05:00