1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Commit Graph

19800 Commits

Author SHA1 Message Date
Bryan Cunningham
f865139d16 [CL-881] restore nav tree view (#17210)
* restore tree nav view

* address Claude feedback

* address feedback and fix depth calculation

* address feedback from Claude

* do not reserve space for icon
2025-11-06 11:10:17 -05:00
Oscar Hinton
29e4085986 [PM-27646] Prevent enabling logging and disabling signature (#17253)
This ensures we won't accidentally ship prod binaries that either have logging enabled or disable signature validation.
2025-11-06 17:06:59 +01:00
Robyn MacCallum
c7da24e627 Pass cipherId in bgHandleReprompt (#17256) 2025-11-06 10:53:17 -05:00
Maximilian Power
152a7ac592 [PM-26587] Add sumo logic siem integration (#17173)
* [PM-26587] Add sumo logic siem integration
2025-11-06 15:46:11 +00:00
Vicki League
1cc08c5968 [PM-26984] Use medium instead of semibold or bold (#17189) 2025-11-06 07:45:36 -08:00
Maximilian Power
87dceff0c8 add CSV download buttons to at risk members and applications drawers (#17172)
* add CSV download buttons to at risk members and applications drawers

---------

Co-authored-by: Alex <55413326+AlexRubik@users.noreply.github.com>
2025-11-06 16:32:51 +01:00
Vicki League
7cbfcd23a8 [PM-26984] Use medium instead of semibold or bold (#17194) 2025-11-06 09:09:17 -06:00
Oscar Hinton
78d1eb9bed Replace dbg_log with tracing::debug (#17251)
We already configure tracing to only be enabled in debug so there is no need to wrap it with a macro
2025-11-06 15:48:19 +01:00
Nick Krantz
30af9425d8 prevent form status changes from triggering a valueChanges emission (#17181)
- previous data within the cipher can be overwritten by the initial form data
2025-11-06 08:28:05 -06:00
Alex
3845ef388c only count critical apps with at-risk passwords (#17239) 2025-11-06 09:11:36 -05:00
Alex
dc56cc80eb new text new keys (#17248) 2025-11-06 09:10:25 -05:00
Dmitry Yakimenko
5c2215401c [PM-27786] Chrome application bound encryption v3 support (#17205)
* Update cargo.lock on windows

* Move ABE key decoding to helper.exe

* Safe slice operations (no panics)

* Refactor CNG code a bit

* Refactor CNG code a bit more

* Update README to match the new flow

* DRY up v1 and v2 decryption

* Remove all the crates and windows features that are not needed

* helper.exe split into a bunch of files

* Refator mod windows

* Minor cleanup

---------

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2025-11-06 10:20:23 +01:00
Matt Gibson
57b8f18cdd PM-27820 (#17245)
* limit port to internal communications

* A few more internal-only ports

* fixup tests

disabled tests that are now failing with a race condition.

* Remove autofill team review requirement
2025-11-05 20:22:34 -05:00
Matt Gibson
cbf380e023 Arch/pm 27820 (#17241)
* add storage port validation

* remove unused method

* Prefer property presence over truthyness
2025-11-05 18:09:15 -05:00
SmithThe4th
aabee1b827 Fixed incorrect toast messages on favorite (#17238) 2025-11-05 17:06:52 -05:00
neuronull
b13f1e6dcf Fix tracing/log crate dep ownership in renovate config (#17215) 2025-11-05 13:46:23 -07:00
Nick Krantz
8cd39690ed [PM-27711] Loading Skeleton page (#17224)
* convert popup page component to use inputs

* disable overflow on popup page to allow content to naturally overflow

* migrate popup-page to OnPush

* add vault-loading-skeleton component

* remove internal loading text

* hide entire skeleton from screen readers
2025-11-05 14:05:15 -06:00
brandonbiete
edae5e69c7 [BRE-1281] Strip bullets from changelog in fastlane (#17237)
* [BRE-1281] Add formatting for changelog to strip bullet points in fastlane

* [BRE-1281] Change UI message in fastlane for original and formatted changelog
2025-11-05 19:54:58 +00:00
rr-bw
b65e02977e (Vault) [PM-27543] Create PremiumSetupIntentRedirectGuard (#17143)
* add state definition

* create abstraction, no-op, and web service

* update service name to reflect file name

* create redirect guard and add to web route

* update service import

* [PM-27543] Cleanup premiumInterestRedirectGuard

* [PM-27543] Add tests for premium-interest-redirect guard

* [PM-27543] Undo change to billing docs

* [PM-27543] Add error handling to guard

* [PM-27543] Improve tests

* [PM-27543] Add callToAction query parameter

---------

Co-authored-by: Shane <smelton@bitwarden.com>
2025-11-05 11:23:14 -08:00
Alex Morask
f53f3516b7 [PM-27838] Split out self-hosted premium component (#17232)
* Split self-hosted premium component out to avoid pricing conflicts

* Claude's feedback

* Remove unnecessary isSelfHost check
2025-11-05 13:13:59 -06:00
Shane Melton
60b16a796c [PM-27848] Undo OnPush change detection strategy change for CipherViewComponent (#17235) 2025-11-05 11:02:56 -08:00
Bryan Cunningham
74889ec754 remove spacing from checkboxes. Add media query for smaller screens (#17233) 2025-11-05 13:32:41 -05:00
Bryan Cunningham
6e97927db6 Uif/export switch (#17234)
* fix private variables used in template

* remove module

* fix test import
2025-11-05 13:28:28 -05:00
Alex Morask
f76d2f36e6 [PM-27808] Save modal dismissal to state (#17227)
* Prevent modal from opening twice for same user

* Claude's feedback
2025-11-05 12:04:49 -06:00
Bernd Schoolmann
3125f679d3 [PM-25206] Inject service instead of passing as param (#16801)
* Inject service instead of passing as param

* [PM-25206] Move locking logic to LockService (#16802)

* Move locking logic to lock service

* Fix tests

* Fix CLI

* Fix test

* FIx safari build

* Update call to lock service

* Remove locked callback

* Clean up lock service logic

* Add tests

* Fix cli build

* Add extension lock service

* Fix cli build

* Fix build

* Undo ac changes

* Undo ac changes

* Run prettier

* Fix build

* Remove duplicate call

* [PM-25206] Remove VaultTimeoutService lock logic (#16804)

* Move consumers off of vaulttimeoutsettingsservice lock

* Fix build

* Fix build

* Fix build

* Fix firefox build

* Fix test

* Fix ts strict errors

* Fix ts strict error

* Undo AC changes

* Cleanup

* Fix

* Fix missing service
2025-11-05 17:11:34 +01:00
Bryan Cunningham
993637c41e use regular gap instead of column gap to fix spacing (#17228) 2025-11-05 11:05:13 -05:00
Vicki League
97aef75cb4 [PM-26984] Use medium instead of semibold or bold (#17190) 2025-11-05 13:08:55 +10:00
Szymon
05ca57d538 [PM-26821] Improve macOS fullscreen ux (#16838)
* Improve popout window UX for fullscreen macOS

Adds special handling for popout windows when the sender is in fullscreen mode on macOS. The sender window moves from fullscreen to maximized before opening the popout, and the new window is focused after creation to improve user experience.

* Add tests for fullscreen popout behavior on mac

added happy path and skip path tests

* Move popout window check before fullscreen logic

* Refactor openPopout tests for platform-specific fullscreen handling

* run prettier

---------

Co-authored-by: Addison Beck <github@addisonbeck.com>
2025-11-04 20:54:20 -05:00
John Harrington
8e8092c828 [PM-27648] [Defect] The .zip option is displayed on organizational export in Admin Console (#17140)
* consider admin console context when determining export types and callout

* checkpoint on simplified fix before swapping to signals

* Update libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Update libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

---------

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2025-11-04 22:34:22 +01:00
SmithThe4th
c42a7b2ef5 [PM-27506] CLI allows creating SSH key items with null fields (#17063)
* Added checks to on the sshkey view to prevent null fields

* Give default values to the template

* Give default values to the template

* change function signature to match ts-strct styles

* Added unit tests for the ssh key to view and replaced deafults to empty strings
2025-11-04 15:51:17 -05:00
Bryan Cunningham
203267f53c [CL-890] fix flakey tests (#17160)
* remove animations to try and fix flakey tests

* allow some diff in tootltip story

* dedicated collapsed nav story

* remove viewports and add delay

* add back animations

* add input to disable responsive behavior

* remove responsive input. open nav on lg viewports

* create story to capture collapsed nav

* remove unused import

* more explicit user preference logic
2025-11-04 15:35:23 -05:00
Dave
e6c2786dcc fix(desktop-app-component) [PM-27467]: Remove early call of updateAppMenu on logout; await broadcastService handling of loggedOut to update app menu to prevent evaluation of activeUserState. (#17219) 2025-11-04 20:32:27 +00:00
Vicki League
9bd7b58f6b [PM-26984] Use medium instead of semibold or bold (#17188) 2025-11-04 15:27:13 -05:00
Shane Melton
7e5f02f90c [PM-24469] Implement Risk Insights for Premium in Cipher view component (#17012)
* [PM-24469] Refactor CipherViewComponent to use Angular signals and computed properties for improved reactivity

* [PM-24469] Refactor CipherViewComponent to utilize Angular signals for organization data retrieval

* [PM-24469] Refactor CipherViewComponent to utilize Angular signals for folder data retrieval

* [PM-24469] Cleanup organization signal

* [PM-24469] Refactor CipherViewComponent to replace signal for card expiration with computed property

* [PM-24469] Improve collections loading in CipherViewComponent

* [PM-24469] Remove redundant loadCipherData method

* [PM-24469] Refactor CipherViewComponent to replace signal with computed property for pending change password tasks

* [PM-24469] Refactor LoginCredentialsViewComponent to rename hadPendingChangePasswordTask to showChangePasswordLink for clarity

* [PM-24469] Introduce showChangePasswordLink computed property for improved readability

* [PM-24469] Initial RI for premium logic

* [PM-24469] Refactor checkPassword risk checking logic

* [PM-24469] Cleanup premium check

* [PM-24469] Cleanup UI visuals

* [PM-24469] Fix missing typography import

* [PM-24469] Cleanup docs

* [PM-24469] Add feature flag

* [PM-24469] Ensure password risk check is only performed when the feature is enabled, and the cipher is editable by the user, and it has a password

* [PM-24469] Refactor password risk evaluation logic and add unit tests for risk assessment

* [PM-24469] Fix mismatched CipherId type

* [PM-24469] Fix test dependencies

* [PM-24469] Fix config service mock in emergency view dialog spec

* [PM-24469] Wait for decrypted vault before calculating cipher risk

* [PM-24469] startWith(false) for passwordIsAtRisk signal to avoid showing stale values when cipher changes

* [PM-24469] Exclude organization owned ciphers from JIT risk analysis

* [PM-24469] Add initial cipher-view component test boilerplate

* [PM-24469] Add passwordIsAtRisk signal tests

* [PM-24469] Ignore soft deleted items for RI for premium feature

* [PM-24469] Fix tests
2025-11-04 12:15:53 -08:00
Jordan Aasen
d364dfdda0 [PM-26182] - [Defect] [Browser] Safari - Autofill on page load default setting is missing yes or no (#16605)
* handle parenthesis translation

* add whitespace around placeholder with parentheses

* fix test

* fix label

* fix spec
2025-11-04 10:59:00 -08:00
Vicki League
92118e525d [PM-26984] Use medium instead of semibold or bold (#17185) 2025-11-04 13:56:01 -05:00
rr-bw
409dbc4c44 fix(sso-login): [PM-27674] (Auth) Make 'enter' press start sso process if ssoRequired (#17186)
If user's email is NOT in the ssoRequiredCache, pressing "enter" takes them to the MP login screen. If the user's email is in the ssoRequiredCache, pressing "enter" starts the SSO login process.

Feature Flags enabled: pm-22110-disable-alternate-login-methods
2025-11-04 10:41:00 -08:00
Tom
f556f3b000 Adding the removal from the access intelligence routing canActivate (#17216) 2025-11-04 13:22:57 -05:00
renovate[bot]
cef503ee9a [deps] SM: Update jest-diff to v30 (#15293)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cd-bitwarden <106776772+cd-bitwarden@users.noreply.github.com>
2025-11-04 18:13:10 +00:00
Daniel Riera
a71ab020c4 PM-27807 remove unused es-lint disable (#17212) 2025-11-04 12:47:26 -05:00
neuronull
7801fd3123 Desktop Autotype use managed object for IPC vault data payload (#17105)
* Desktop Autotype use managed object for IPC vault data payload

* claude feedback 1

* check for falsey values

* add unit test

* remove unecessary async

* helper result type

* dear claude
2025-11-04 09:13:08 -07:00
Vicki League
b79625def8 [PM-26984] Use medium instead of semibold or bold (#17187) 2025-11-04 08:29:31 -07:00
Vicki League
573d4219f9 [PM-26984] Use medium instead of semibold or bold (#17192) 2025-11-04 16:18:53 +01:00
Vicki League
a13a81ba81 [PM-26984] Use medium instead of semibold or bold (#17193) 2025-11-04 15:56:12 +01:00
Bernd Schoolmann
9dfc0fe14f Fix broken build on latest SDK (#17208)
* Fix broken build on latest SDK

* Fix test
2025-11-04 15:46:19 +01:00
neuronull
9803cc98b4 Desktop Native remove log deps (#17135) 2025-11-04 07:35:34 -07:00
Mick Letofsky
ff611338f9 [PM-4735] - Refactor event handling of the browser close listener (#16798) 2025-11-04 15:20:54 +01:00
Mick Letofsky
86b213aa8e [PM-25820] - Migrate cipher data model to adhere to ts-strict (#17073)
* Migrate cipher data model to adhere to ts-strict & added unit tests where applicable
2025-11-04 10:08:18 +01:00
Matt Andreko
0b65442d5e 🔧 update cargo-deny version in ci (#17174) 2025-11-03 17:54:26 -05:00
rr-bw
5c33b2dc89 (Billing) [PM-27562] Create PremiumInterestStateService (#17139)
Creates a `PremiumInterestStateService` that manages state which conveys whether or not a user intends to setup a premium subscription. Implemented in Web only. No-op for other clients.

This will apply for users who began the registration process on https://bitwarden.com/go/start-premium/, which is a marketing page designed to streamline users who intend to setup a premium subscription after registration.
2025-11-03 14:42:21 -08:00