1
0
mirror of https://github.com/bitwarden/browser synced 2026-01-23 12:53:44 +00:00
Commit Graph

3284 Commits

Author SHA1 Message Date
Jordan Aasen
f8ca91c8a7 [PM-25693] - hide import sshKey button for view-only users (#17985)
* hide import sshKey button for view-only users

* use @if

* add optional chain

* use computed property. update tests

* move comment down
2026-01-06 12:50:46 -08:00
Todd Martin
3c1e39b0fb feat(tokens): [BEEEP] Refresh access token on 401 API response
* Update to handle 401 to refresh token.

* Updated to revert changes to extract token comparison.

* Fixed tests

* Adjusted tests.

* Removed debug logging

* Test updates

* Added race condition test.

* Added clarified logout reason

* Fixed typo

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Fixed tests

* Fixed extra space

* Removed extra logout reasons to be introduced later.

* Added warning on 401 and retry

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
2026-01-06 15:24:03 -05:00
Jordan Aasen
5927f7f278 [PM-29800] - fix icon alignment in attachment view (#18112)
* fix icon alignment in attachment view

* move class to bit-item-action
2026-01-06 11:34:46 -08:00
Jordan Aasen
9c8a92c8ac [PM-29214] - update at-risk launch link (#18093)
* update at-risk launch link

* use bit-hint

* remove getter
2026-01-06 10:22:06 -08:00
Jason Ng
e344d342be [PM-30135] deleted archived items restored to archive (#18212) 2026-01-06 10:29:15 -05:00
Dubzer
78f7a31127 [PM-28648] Handle delayed availability of biometric unlock (#17603)
* Handle delayed availability of biometric unlock

* Fix linting

---------

Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2026-01-06 16:20:31 +01:00
Vincent Salucci
86764d807a [PM-22434] Remove CreateDefaultLocation feature flag references and definition (#18057)
* chore: remove ff from vault-popup-list-filters.service, refs PM-22434

* chore: remove ff from confirm.command, refs PM-22434

* chore: remove ff from bulk-confirm-dialog.component, refs PM-22434

* chore: remove ff from member-actions.service and clean up leftover imports, refs PM-22434

* chore: remove ff from policy-edit-dialog.component, refs PM-22434

* chore: remove ff from organization-data-ownership.component, refs PM-22434

* chore: remove ff from vnext-organization-data-ownership.component, refs PM-22434

* chore: remove ff from vault-filter.service, refs PM-22434

* chore: remove ff from vault-filter.service (libs), refs PM-22434

* chore: remove ff from export.component, refs PM-22434

* chore: update observeMyItemsExclusionCriteria method documentation comments, refs PM-22434

* chore: remove ff from item-details-section.component, refs PM-22434

* chore: remove ff definition, refs PM-22434

* fix: remove configService from superclasses, refs PM-22434

* chore: update injection for VaultPopupListFilters service instantiation, refs PM-22434

* chore: update ConfirmCommand instantiation, refs PM-22434

* chore: update import order in member-actions.service, refs PM-22434

* fix: constructor argument update to amend merge conflict, refs PM-22434

* chore: remove unnecessary feature flag related tests for confirm user, refs PM-22434

* fix: remove unused services from member-actions.service.spec, refs PM-22434
2026-01-05 16:25:57 -06:00
Jared
fe03052fe6 [PM-25721] Retain leading spaces in imported fields. (#16411)
* Implement cleanupCipher method in BaseImporter with tests for notes and name handling

- Added cleanupCipher method to preserve leading/trailing spaces in notes and set them to null if they contain only whitespace or are empty.
- Updated the BaseImporter class to remove trimming of notes to maintain original formatting.
- Added unit tests for cleanupCipher to verify behavior for various note and name scenarios.

* Got rid of unneeded cipher spec test

* Got rid of unneeded comment

* Fix service and importers for tests to pass

* Fix sdk.service.ts

* Refactor URL normalization in ApiService to streamline request URL construction

* Fixed PR comments

* Add back comment

---------

Co-authored-by: Mike Amirault <mamirault@bitwarden.com>
2026-01-05 11:48:10 -05:00
Isaac Ivins
cf285abd3d Feature/pm 25865 migrate send list desktop migration (#18008)
This PR moves the Desktop Send list UI into a shared library component and updates the Desktop Send v2 component to use modern Angular patterns (Signals, OnPush, no manual subscriptions)
2026-01-05 15:37:24 +01:00
Bryan Cunningham
f341b00092 [CL-947] drawer width variants (#18156)
* allow drawer to adapt to size input

* add new drawer sizes

* move logic back to dialog component

* convert width to computed signal

* fix template error and remove duplicate class

* use normal const object

* ensure dialogSize undefined is handled
2026-01-05 08:59:11 -05:00
Oscar Hinton
738df45f38 Add input for forcing active state on group & disable toggle (#18043) 2026-01-05 11:07:37 +01:00
Maciej Zieniuk
7fa1a6f07f [PM-27236] account registration v2 for key connector (#17951)
* account registration v2 for key connector

* explicit naming

* test coverage

* missing AccountCryptographicStateService and DI dependencies

* redundant SdkLoadService.Ready

* update sdk version
2025-12-31 11:04:54 +01:00
Shane Melton
696c53fac7 [PM-29209] Fix persistent browser settings berry (#18113)
* [PM-29209] Introduce new autofill nudge service specific to the Browser client

* [PM-29209] Cleanup redundant browser setting checks

* [PM-29209] Ensure nudge is dismissed on nudge button click

* [PM-29209] Add spec file for browser autofill nudge service

* [PM-29209] Cleanup settings-v2 spec file
2025-12-29 16:41:42 -08:00
Daniel James Smith
1c6a83f311 [BEEEP][PM-29441] Introduce bitwarden-encrypted-json-importer (#17651)
* Introduce bitwarden-encrypted-json-importer

An effort to introduce type guards and split the logic between the differently protected bitwarden-json import-formats

* Improved stricter types, but not quite ts-strict yet

* Add guard to prevent passing password-protected exports to the wrong importer.

* Only create one return object instead of multiple

* Updated changes afer npm ci and npm run prettier

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-12-29 21:28:33 +01:00
Mark Youssef
ccb9a0b8a1 [CL-132] Implement resizable side nav (#16533)
Co-authored-by: Vicki League <vleague@bitwarden.com>
2025-12-29 14:08:33 -05:00
Jason Ng
3beeab4414 [PM-29972] Update Vault Items List When Archiving Ciphers (#18102)
* update default cipher service to use upsert, apply optional userId parameter
2025-12-29 13:49:00 -05:00
Todd Martin
146e2c0a12 chore(feature-flags): Remove notification on inactive and locked user feature flags 2025-12-29 11:35:56 -05:00
Bryan Cunningham
2da44bb300 [CL-913] add new color palette to theme and tailwind config (#17998)
* add new color palette to theme and tailwind config

* updated docs color names

* remove safelist changes

* add missing accent colors to docs

* updated color mappings

* combined docs in colors.mdx and reference in Claude.md

* add variables for white and black

* updated docs

* updated list rendering style

* more specific docs instructions

* revert to simpler colors docs reference

* remove changes to claude.md

* use rgb color variables to compose semantic
2025-12-26 16:18:31 -05:00
Todd Martin
5c13b07366 chore(merge): Fixed date initialization on test 2025-12-26 15:28:58 -05:00
Todd Martin
91991d2da6 feat(account): [PM-29545] Update AccountInfo creationDate to use Date instead of string
* Add creationDate of account to AccountInfo

* Added initialization of creationDate.

* Removed extra changes.

* Fixed tests to initialize creation date

* Added helper method to abstract account initialization in tests.

* More test updates.

* Linting

* Additional test fixes.

* Fixed spec reference

* Fixed imports

* Linting.

* Fixed browser test.

* Modified tsconfig to reference spec file.

* Fixed import.

* Removed dependency on os.  This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node.

* Revert "Removed dependency on os.  This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node."

This reverts commit 669f6557b6.

* Updated stories to hard-code new field.

* Removed changes to tsconfig

* Revert "Removed changes to tsconfig"

This reverts commit b7d916e8dc.

* Updated to use Date

* Updated to use Date on sync.

* Changes to tests that can't use mock function

* Prettier updates

* Update equality to handle Date type.

* Change to type comparison.

* Simplified equality comparison to just use properties.

* Added comment.

* Updated comment to reference Date.

* Added back in internal method tests.
2025-12-26 14:42:19 -05:00
Jordan Aasen
77ccc3eb49 [PM-26656] - remove AutofillConfirmation feature flag (#18074)
* remove AutofillConfirmation feature flag

* fix tests. remove feature flag tests
2025-12-23 14:24:23 -08:00
Bernd Schoolmann
3fbb4aced9 [PM-27239] Tde registration encryption v2 (#17831)
* tmp

* Implement TDE v2 registration via SDK

* Undo encstring test string change

* Add feature flag

* Add tests

* Continue tests

* Cleanup

* Cleanup

* run prettier

* Update to apply new sdk changes

* Fix build

* Update package lock

* Fix tests

---------

Co-authored-by: Bernd Schoolmann <quexten@fedora-2.fritz.box>
2025-12-23 16:27:25 +01:00
Vicki League
dc1ecaaaa2 [PM-29819][CL-806] Fix focus mgmt on search and filter page navigations (#18007) 2025-12-22 16:55:20 -05:00
Jared Snider
d95739191b PM-30125 - IdentityTokenResponse - mark deprecated properties as such (#18092) 2025-12-22 15:56:12 -05:00
Alex Morask
59a1b4d79e Remove FF: pm-22415-tax-id-warnings (#17871) 2025-12-22 14:14:23 -06:00
Mike Amirault
dfb597c236 [PM-24015] Handle Send form empty password field properly (#17911) 2025-12-22 11:04:14 -05:00
Dave
0064f18ccd fix(set-initial-password) [PM-28494]: Newly created master password not accepted on unlock until after re-login on browser extension (#17930)
* fix(set-initial-password-service) [PM-28494]: Update MP data and decryption property sets to accommodate legacy and new paths for service.

* fix(set-initial-password-component) [PM-28494]: Add salt and mp data to credentials object.

* refactor(set-initial-password-service) [PM-28494]: Additional comments.

* test(set-initial-password-service) [PM-28494]: Update tests for added credential members.
2025-12-19 14:56:13 -05:00
bmbitwarden
481386218a PM-24189 improved screen reader parsing for special character checkbox (#17361)
* PM-24189 improved screen reader parsing for special character checkbox

* PM-24189 resolved voiceOver issue

* PM-24189 resolved voiceOver issue

* PM-27628 resolved pr comment re id and aria labels and comments

* PM-24189 resolved pr comment
2025-12-19 13:26:40 -05:00
Leslie Tilton
ea4666e3c1 [PM-25884] Move Phishing Detection Safari check to PhishingDetectionSettingsService (#18042)
* Move safari check to phishing detection settings to expose to all places using phishing detection

* Remove duplicate comment
2025-12-19 11:58:14 -06:00
Oscar Hinton
44b31fdade [PM-29448] Consume the new send table in web (#17923)
2nd part of PM-29448. Consumes the new send table in the web vault. Also updates the send table to contain the responsive behaviour.
2025-12-19 16:00:37 +01:00
Mike Amirault
39bc4fb789 [PM-29875] Close Send drawer on navigation (#18031) 2025-12-18 14:48:48 -05:00
Mike Amirault
0527171f3c [PM-29780] Add feature flag for Send email OTP verification (#18005)
* [PM-29780] Add feature flag for Send email OTP verification

* [PM-29780] Add default flag value
2025-12-18 14:12:52 -05:00
Shane Melton
ff3582109c [PM-28746] Item transfer event logs (#18032)
* [PM-28746] Add item organization event types and i18n strings

* [PM-28746] Log event when transfer is accepted or declined
2025-12-18 10:20:59 -08:00
cyprain-okeke
ef7b66ad0d [PM 29079]Remove code for pm-24033-updat-premium-subscription-page (#17905)
* Remove the feature flag

* delete and rename CloudHostedPremiumVNextComponent
2025-12-18 17:35:48 +01:00
Oscar Hinton
ad4b6a30a0 [UIF] Prefer static string properties (#17966) 2025-12-18 01:49:26 -05:00
Bernd Schoolmann
ea45c5d3c0 [PM-27315] Add account cryptographic state service (#17589)
* Update account init and save signed public key

* Add account cryptographic state service

* Fix build

* Cleanup

* Fix build

* Fix import

* Fix build on browser

* Fix

* Fix DI

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix test

* Fix desktop build

* Fix

* Address nits

* Cleanup setting private key

* Add tests

* Add tests

* Add test coverage

* Relative imports

* Fix web build

* Cleanup setting of private key
2025-12-17 22:04:08 +01:00
neuronull
4f0b69ab64 Desktop Autotype add GA FF (#17896) 2025-12-17 13:37:04 -07:00
Bryan Cunningham
5504d49751 [CL-927] add popup header back to extension layout for now (#18023)
* add popup header back to extension layout for now

* conditionally add margin for now if not hiding logo
2025-12-17 15:02:37 -05:00
Alex Dragovich
930cb9ab96 [PM-29896] specify noun or verb for Import / Export terms (#18012)
* [PM-29896] specify noun or verb for Import / Export terms

* [PM-29896] adjust verb to noun
2025-12-17 11:24:44 -08:00
Daniel James Smith
e4a2e72616 Update command to reset nx (#18022)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-12-17 19:09:07 +00:00
Jared Snider
cbd80d0186 refactor(IdentityTokenResponse): [Auth/PM-3287] Remove deprecated resetMasterPassword property from IdentityTokenResponse (#17794)
* PM-3287 - Remove resetMasterPassword from authResult and identityTokenResponse and replace with userDecryptionOptions where relevant

* PM-3287 - (1) Move SSO code to SSO section (2) Update error scenario conditional + log user out upon error.

* PM-3287 - Fix comment per PR feedback

* PM-3287 - CLI Login with SSO - move MP validation logic back to original location to avoid putting it before 2FA rejection handling.

* PM-3287 - Update returns
2025-12-17 10:34:42 -05:00
Bernd Schoolmann
4846d217a9 [PM-28901] Fix master key not being set to state after kdf update (#17990)
* Fix master key not being set to state after kdf update

* Fix cli build

* Fix test error

* Fix hash purpose

* Add test for master key being set

* Fix incorrect variable name
2025-12-17 10:57:24 +01:00
Shane Melton
06d15e9681 [PM-27675] Browser item transfer integration (#17918)
* [PM-27675] Integrate dialogs into VaultItemTransferService

* [PM-27675] Update tests for new dialogs

* [PM-27675] Center dialogs and prevent closing with escape or pointer events

* [PM-27675] Add transferInProgress$ observable to VaultItemsTransferService

* [PM-27675] Hook vault item transfer service into browser vault component

* [PM-27675] Move defaultUserCollection$ to collection service

* [PM-27675] Cleanup dialog styles

* [PM-27675] Introduce readySubject to popup vault component to keep prevent flashing content while item transfer is in progress

* [PM-27675] Fix vault-v2 tests
2025-12-16 15:03:48 -08:00
Mike Amirault
b63e1cb26c [PM-28181] Open send dialog in drawer instead of popup in refreshed UI (#17666)
* [PM-28181] Open send dialog in drawer instead of popup in refreshed UI

* Fix types

* [PM-28181] Use drawer to edit sends with refreshed UI

* [PM-28181] Address bug where multiple Sends could not be navigated between
2025-12-16 13:34:31 -05:00
Alex Morask
a987494300 [PM-29607] Create @bitwarden/subscription (#17997)
* Create @bitwarden/subscription

* Fix changed import in tsconfig.base.json
2025-12-16 10:13:18 -06:00
Oscar Hinton
ac23878847 [CL-934] Migrate breadcrumbs to OnPush (#17390)
Migrates BreadcrumbComponent and BreadcrumbsComponent to OnPush and changes any property to computed signals.
2025-12-16 16:15:34 +01:00
Jason Ng
d130c443b8 [PM-26514] Archive With Non Premium User (#17820)
* Add callout for archive non premium, add premium check, add archive badge to view/edit modal, update btn text
2025-12-15 18:16:04 -05:00
Todd Martin
4b93df98c8 chore(README): Update READMEs missing H1 headers
* Update READMEs missing H1 headers.

* Changed casing.
2025-12-15 16:35:44 -05:00
Bernd Schoolmann
1edff74b30 Use proof of decryption (#17903) 2025-12-15 18:36:16 +01:00
Max
721f253ef9 [PM-28536] Add phishing blocker setting to account security (#17527)
* added phishing blocker toggle

* design improvements

* Fix TypeScript strict mode errors in PhishingDetectionSettingsServiceAbstraction

* Camel case messages

* Update PhishingDetectionService.initialize parameter ordering

* Add comments to PhishingDetectionSettingsServiceAbstraction

* Change state from global to user settings

* Remove clear on logout phishing-detection-settings

* PM-28536 making a change from getActive to getUser because of method being deprecated

* Moved phishing detection services to own file

* Added new phishing detection availability service to expose complex enable logic

* Add test cases for PhishingDetectionAvailabilityService

* Remove phishing detection availability in favor of one settings service

* Extract phishing detection settings service abstraction to own file

* Update phishing detection-settings service to include availability logic. Updated dependencies

* Add test cases for phishing detection element. Added missing dependencies in testbed setup

* Update services in extension

* Switch checkbox to bit-switch component

* Remove comment

* Remove comment

* Fix prettier vs lint spacing

* Replace deprecated active user state. Updated test cases

* Fix account-security test failing

* Update comments

* Renamed variable

* Removed obsolete message

* Remove unused variable

* Removed unused import

---------

Co-authored-by: Leslie Tilton <23057410+Banrion@users.noreply.github.com>
Co-authored-by: Graham Walker <gwalker@bitwarden.com>
Co-authored-by: Tom <144813356+ttalty@users.noreply.github.com>
2025-12-15 09:51:31 -06:00