electron-builder 26.0.13 had issues with macOS code signing when using
pnpm, causing it to fall back to ad-hoc signatures. This was due to
passing identity hash instead of name to osx-sign, which prevented
TeamID extraction.
Key fixes in 26.3.6:
- PR #8908: osx-sign now receives identity name instead of hash
- PR #9392: Fix pnpm hoisted mode virtual path handling
- PR #9401: Filesystem verification for hoisted mode
- Issue #9366: Universal build fixes for pnpm monorepos
Changes:
- Upgrade electron-builder from 26.0.13 to 26.3.6
- Add electron-builder-squirrel-windows 26.3.6 (peer dependency)
- Add squirrel-windows to Renovate config with grouping rule
- Remove CSC_NAME workaround (no longer needed with identity fix)
References:
- https://github.com/electron-userland/electron-builder/issues/7995
- https://github.com/electron-userland/electron-builder/pull/8908
electron-builder auto-detects the certificate type, so just provide
the organization name without the "Developer ID Application:" or
"3rd Party Mac Developer Application:" prefix.
electron-builder 26.0.13 with pnpm falls back to ad-hoc signing when
it can't auto-discover the signing identity. Fix by explicitly setting
CSC_NAME for both Developer ID and App Store builds.
- Developer ID: "Developer ID Application: 8bit Solutions LLC"
- App Store: "3rd Party Mac Developer Application: Bitwarden Inc"
Replace shamefully-hoist with node-linker=hoisted to create a flat
node_modules structure. Maybe fixes electron-builder's code signing
which couldn't find @electron/osx-sign through pnpm's symlinked structure?
pnpm runs the postinstall script for apps/desktop, the electron-rebuild
binary isn't in PATH. The binary is at root node_modules/.bin/, but the
script runs from apps/desktop/.
* added phishing blocker toggle
* design improvements
* Fix TypeScript strict mode errors in PhishingDetectionSettingsServiceAbstraction
* Camel case messages
* Update PhishingDetectionService.initialize parameter ordering
* Add comments to PhishingDetectionSettingsServiceAbstraction
* Change state from global to user settings
* Remove clear on logout phishing-detection-settings
* PM-28536 making a change from getActive to getUser because of method being deprecated
* Moved phishing detection services to own file
* Added new phishing detection availability service to expose complex enable logic
* Add test cases for PhishingDetectionAvailabilityService
* Remove phishing detection availability in favor of one settings service
* Extract phishing detection settings service abstraction to own file
* Update phishing detection-settings service to include availability logic. Updated dependencies
* Add test cases for phishing detection element. Added missing dependencies in testbed setup
* Update services in extension
* Switch checkbox to bit-switch component
* Remove comment
* Remove comment
* Fix prettier vs lint spacing
* Replace deprecated active user state. Updated test cases
* Fix account-security test failing
* Update comments
* Renamed variable
* Removed obsolete message
* Remove unused variable
* Removed unused import
---------
Co-authored-by: Leslie Tilton <23057410+Banrion@users.noreply.github.com>
Co-authored-by: Graham Walker <gwalker@bitwarden.com>
Co-authored-by: Tom <144813356+ttalty@users.noreply.github.com>
* auto key not stored due to vault timeout race condition being null for cli
* fix unit test default state
* neglected electron key service test cleanup
* bad merge - fix formatting
* [PM-23258] changing verbiage from import data to import items
* [PM-23258] Removing vault and data from import and export titles, navs, and buttons
* [PM-23258] more verbiage changes
* [PM-23258] reverting unnecessary change
* [PM-23258] removing unused text from messages json files
* [PM-23258] small text changes from design
* [PM-23258] including secrets manager changes
* Add creationDate of account to AccountInfo
* Added initialization of creationDate.
* Removed extra changes.
* Fixed tests to initialize creation date
* Added helper method to abstract account initialization in tests.
* More test updates.
* Linting
* Additional test fixes.
* Fixed spec reference
* Fixed imports
* Linting.
* Fixed browser test.
* Modified tsconfig to reference spec file.
* Fixed import.
* Removed dependency on os. This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node.
* Revert "Removed dependency on os. This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node."
This reverts commit 669f6557b6.
* Updated stories to hard-code new field.
* Removed changes to tsconfig
* Revert "Removed changes to tsconfig"
This reverts commit b7d916e8dc.
* feat(token-service) [PM-15333]: Update Portable secure storage resolution to use disk.
* feat(token-service) [PM-15333]: Move isWindowsPortable evaluation to preload with other platform evaluations.
* Reapply "Desktop Native compile debug builds with debug log level (#17357)" (#17815)
This reverts commit 5386b58f23.
* Use release mode if workflow called from upstream
* fix bug in build script
* revert napi build command to not use --release
* forward caller's args to napi
* js things
* shell thangs
* use platform agnostic expansion
* Revert "use platform agnostic expansion"
This reverts commit 5ee629f822.
* powershell expansion
* add a slot for consumers to show user actions in anon layout header
* remove commented code
* ensure logo stays top aligned
* switch to dashed naming
* fix ngif statements
* remove empty selector
* remove unnecessary containers
* use smaller logo on smaller screens
* remove commented code from extension layout
* remove dupe slot
* only take extension screenshots on small screens
* take screenshot at 380
* take large and small screenshot
* update story to use new control flow
