4521262f2b
The newApplications field was redundant in the summary type because it can be calculated from applicationData (where reviewedDate === null). This commit: 1. **Removes newApplications from OrganizationReportSummary type** - No longer stored in encrypted summary - Reduces encryption overhead 2. **Removes all validation logic for newApplications** - Removed from type guards (isOrganizationReportSummary) - Removed from validation function (validateOrganizationReportSummary) - Removed from allowedKeys list 3. **Removes newApplications from summary calculation** - risk-insights-report.service.ts: Removed dummy data generation - all-activities.service.ts: Removed from initial state and setter - helpers/risk-insights-data-mappers.ts: Removed from createNewSummaryData() 4. **Creates newApplications$ observable in orchestrator** - Derives new applications from applicationData - Filters where reviewedDate === null - Uses distinctUntilChanged and shareReplay for efficiency 5. **Exposes newApplications$ through data service** - Added to RiskInsightsDataService - Wired up in constructor 6. **Updates component to use the observable** - all-activity.component.ts: Subscribe to dataService.newApplications$ - Removes dependency on summary.newApplications 7. **Removes all newApplications tests** - Removed backward compatibility tests (no longer needed) - Removed validation tests for newApplications - Updated mock data to exclude newApplications - Removed from risk-insights-report.service.spec.ts Benefits: - Single source of truth (derived from applicationData) - Eliminates redundant data storage - Reduces encrypted payload size - Cleaner architecture (computed vs stored data) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Bitwarden Client Applications
This repository houses all Bitwarden client applications except the mobile applications (iOS | android).
Please refer to the Clients section of the Contributing Documentation for build instructions, recommended tooling, code style tips, and lots of other great information to get you started.
Related projects:
- bitwarden/server: The core infrastructure backend (API, database, Docker, etc).
- bitwarden/ios: Bitwarden iOS Password Manager & Authenticator apps.
- bitwarden/android: Bitwarden Android Password Manager & Authenticator apps.
- bitwarden/directory-connector: A tool for syncing a directory (AD, LDAP, Azure, G Suite, Okta) to an organization.
We're Hiring!
Interested in contributing in a big way? Consider joining our team! We're hiring for many positions. Please take a look at our Careers page to see what opportunities are currently open as well as what it's like to work at Bitwarden.
Contribute
Code contributions are welcome! Please commit any pull requests against the main branch. Learn more about how to contribute by reading the Contributing Guidelines. Check out the Contributing Documentation for how to get started with your first contribution.
Security audits and feedback are welcome. Please open an issue or email us privately if the report is sensitive in nature. You can read our security policy in the SECURITY.md file.