bitwarden/directory-connector
1
0
Fork 0
mirror of https://github.com/bitwarden/directory-connector synced 2025-12-05 23:53:21 +00:00
Code Issues Releases Wiki Activity

[deps]: Update electron to v34 (#713)

Browse Source 
* [deps]: Update electron to v34

* fix: remove event parameter from minimize handler for Electron 34 compatibility

The minimize event in Electron 34 no longer provides an event object, requiring removal of the e.preventDefault() call.

* feat(deps): add node-abi@3.74.0 as devDependency for Electron 34 rebuild

Required for electron-rebuild to work correctly with Electron 34.
Previous transitive dependency version (3.68.0) was too old to support Electron 34.

* Bump Electron to v34.1.1

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Rui Tome <rtome@bitwarden.com>
This commit is contained in:
renovate[bot]
2025-02-14 11:32:49 +00:00
committed by GitHub
parent b35cf8e995
commit f146d41b66
3 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
jslib/electron/src/tray.main.ts
View File

@@ -60,9 +60,8 @@ export class TrayMain {
}
setupWindowListeners(win: BrowserWindow) {
win.on("minimize", async (e: Event) => {
win.on("minimize", async () => {
if (await this.stateService.getEnableMinimizeToTray()) {
e.preventDefault();
this.hideToTray();
}
});

17
package-lock.json generated
View File

@@ -67,7 +67,7 @@
"cross-env": "7.0.3",
"css-loader": "7.1.2",
"dotenv": "16.4.7",
"electron": "32.1.1",
"electron": "34.1.1",
"electron-builder": "24.13.3",
"electron-log": "5.2.4",
"electron-reload": "2.0.0-alpha.1",
@@ -89,6 +89,7 @@
"jest-preset-angular": "14.5.0",
"lint-staged": "15.4.1",
"mini-css-extract-plugin": "2.9.2",
"node-abi": "3.74.0",
"node-forge": "1.3.1",
"node-loader": "2.1.0",
"pkg": "5.8.1",
@@ -10277,12 +10278,11 @@
}
},
"node_modules/electron": {
"version": "32.1.1",
"resolved": "https://registry.npmjs.org/electron/-/electron-32.1.1.tgz",
"integrity": "sha512-NlWvG6kXOJbZbELmzP3oV7u50I3NHYbCeh+AkUQ9vGyP7b74cFMx9HdTzejODeztW1jhr3SjIBbUZzZ45zflfQ==",
"version": "34.1.1",
"resolved": "https://registry.npmjs.org/electron/-/electron-34.1.1.tgz",
"integrity": "sha512-1aDYk9Gsv1/fFeClMrxWGoVMl7uCUgl1pe26BiTnLXmAoqEXCa3f3sCKFWV+cuDzUjQGAZcpkWhGYTgWUSQrLA==",
"dev": true,
"hasInstallScript": true,
"license": "MIT",
"dependencies": {
"@electron/get": "^2.0.0",
"@types/node": "^20.9.0",
@@ -16981,10 +16981,9 @@
}
},
"node_modules/node-abi": {
"version": "3.68.0",
"resolved": "https://registry.npmjs.org/node-abi/-/node-abi-3.68.0.tgz",
"integrity": "sha512-7vbj10trelExNjFSBm5kTvZXXa7pZyKWx9RCKIyqe6I9Ev3IzGpQoqBP3a+cOdxY+pWj6VkP28n/2wWysBHD/A==",
"license": "MIT",
"version": "3.74.0",
"resolved": "https://registry.npmjs.org/node-abi/-/node-abi-3.74.0.tgz",
"integrity": "sha512-c5XK0MjkGBrQPGYG24GBADZud0NCbznxNx0ZkS+ebUTrmV1qTDxPxSL8zEAPURXSbLRWVexxmP4986BziahL5w==",
"dependencies": {
"semver": "^7.3.5"
},

7
package.json
View File

@@ -98,7 +98,7 @@
"cross-env": "7.0.3",
"css-loader": "7.1.2",
"dotenv": "16.4.7",
"electron": "32.1.1",
"electron": "34.1.1",
"electron-builder": "24.13.3",
"electron-log": "5.2.4",
"electron-reload": "2.0.0-alpha.1",
@@ -120,6 +120,7 @@
"jest-preset-angular": "14.5.0",
"lint-staged": "15.4.1",
"mini-css-extract-plugin": "2.9.2",
"node-abi": "3.74.0",
"node-forge": "1.3.1",
"node-loader": "2.1.0",
"pkg": "5.8.1",
@@ -137,8 +138,8 @@
"webpack": "5.97.1",
"webpack-cli": "6.0.1",
"webpack-merge": "6.0.1",
"zone.js": "0.14.10",
"webpack-node-externals": "3.0.0"
"webpack-node-externals": "3.0.0",
"zone.js": "0.14.10"
},
"dependencies": {
"@angular/animations": "17.3.12",