mirror of
https://github.com/bitwarden/directory-connector
synced 2025-12-05 23:53:21 +00:00
28 lines
1.0 KiB
Markdown
28 lines
1.0 KiB
Markdown
Please review this pull request with a focus on:
|
|
|
|
- Code quality and best practices
|
|
- Potential bugs or issues
|
|
- Security implications
|
|
- Performance considerations
|
|
|
|
Note: The PR branch is already checked out in the current working directory.
|
|
|
|
Provide a comprehensive review including:
|
|
|
|
- Summary of changes since last review
|
|
- Critical issues found (be thorough)
|
|
- Suggested improvements (be thorough)
|
|
- Good practices observed (be concise - list only the most notable items without elaboration)
|
|
- Action items for the author
|
|
- Leverage collapsible <details> sections where appropriate for lengthy explanations or code
|
|
snippets to enhance human readability
|
|
|
|
When reviewing subsequent commits:
|
|
|
|
- Track status of previously identified issues (fixed/unfixed/reopened)
|
|
- Identify NEW problems introduced since last review
|
|
- Note if fixes introduced new issues
|
|
|
|
IMPORTANT: Be comprehensive about issues and improvements. For good practices, be brief - just note
|
|
what was done well without explaining why or praising excessively.
|