1
0
mirror of https://github.com/bitwarden/mobile synced 2026-02-20 03:13:40 +00:00

[PM-5731] feat: implement get assertion params object

This commit is contained in:
Andreas Coroiu
2024-01-17 10:53:10 +01:00
parent ee252be634
commit f9b4e30b0b
5 changed files with 86 additions and 2 deletions

View File

@@ -0,0 +1,9 @@
using Bit.Core.Utilities.Fido2;
namespace Bit.Core.Abstractions
{
public interface IFido2AuthenticatorService
{
Task<Fido2AuthenticatorGetAssertionResult> GetAssertionAsync(Fido2AuthenticatorGetAssertionParams assertionParams);
}
}

View File

@@ -0,0 +1,18 @@
using Bit.Core.Abstractions;
using Bit.Core.Utilities.Fido2;
namespace Bit.Core.Services
{
public class Fido2AuthenticatorService : IFido2AuthenticatorService
{
public Task<Fido2AuthenticatorGetAssertionResult> GetAssertionAsync(Fido2AuthenticatorGetAssertionParams assertionParams)
{
// TODO: IMPLEMENT this
return Task.FromResult(new Fido2AuthenticatorGetAssertionResult
{
AuthenticatorData = new byte[32],
Signature = new byte[8]
});
}
}
}

View File

@@ -2,11 +2,21 @@
{
public class Fido2AuthenticatorGetAssertionParams
{
/** The callers RP ID, as determined by the user agent and the client. */
public string RpId { get; set; }
public string CredentialId { get; set; }
/** The hash of the serialized client data, provided by the client. */
public byte[] Hash {get; set;}
public string Counter { get; set; }
public PublicKeyCredentialDescriptor[] AllowCredentialDescriptorList {get; set;}
/** The effective user verification requirement for assertion, a Boolean value provided by the client. */
public bool RequireUserVerification {get; set;}
/** CTAP2 authenticators support setting this to false, but we only support the WebAuthn authenticator model which does not have that option. */
// public bool RequireUserPresence {get; set;} // Always required
public object Extensions {get; set;}
}
}

View File

@@ -0,0 +1,9 @@
namespace Bit.Core.Utilities.Fido2
{
public class PublicKeyCredentialDescriptor {
public byte[] Id {get; set;}
public string[] Transports;
public string Type;
}
}

View File

@@ -0,0 +1,38 @@
using Bit.Core.Abstractions;
using Bit.Core.Exceptions;
using Bit.Core.Services;
using Bit.Core.Test.AutoFixture;
using Bit.Test.Common.AutoFixture;
using Bit.Test.Common.AutoFixture.Attributes;
using NSubstitute;
using NSubstitute.ExceptionExtensions;
using Xunit;
namespace Bit.Core.Test.Services
{
public class Fido2AuthenticatorTests
{
[Theory]
public async Task GetAssertionAsync_Throws_InputIsMissingSupportedAlgorithm(Fido2AuthenticatorService sut)
{
await Assert.ThrowsAsync<NotFoundException>(async () => await sut.GetAssertionAsync(new Fido2AuthenticatorGetAssertionParams()));
}
// it("should throw error when input does not contain any supported algorithms", async () => {
// const result = async () =>
// await authenticator.makeCredential(invalidParams.unsupportedAlgorithm, tab);
// await expect(result).rejects.toThrowError(Fido2AuthenticatorErrorCode.NotSupported);
// });
private Fido2AuthenticatorGetAssertionParams GetAssertionParams()
{
return new Fido2AuthenticatorGetAssertionParams
{
RpId = "test",
Counter = 0,
CredentialId = new byte[32]
};
}
}
}