bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2026-01-27 14:53:21 +00:00
Code Issues Releases Wiki Activity

Use POST instead of PUT

Browse Source
This commit is contained in:
Thomas Rittson
2026-01-15 15:53:58 +10:00
parent 732659ed76
commit 146ecfce90
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Api/AdminConsole/Public/Controllers/MembersController.cs
View File

@@ -273,7 +273,7 @@ public class MembersController : Controller
/// Revoke a member's access to an organization.
/// </summary>
/// <param name="id">The ID of the member to be revoked.</param>
[HttpPut("{id}/revoke")]
[HttpPost("{id}/revoke")]
[ProducesResponseType((int)HttpStatusCode.OK)]
[ProducesResponseType(typeof(ErrorResponseModel), (int)HttpStatusCode.BadRequest)]
[ProducesResponseType((int)HttpStatusCode.NotFound)]
@@ -307,7 +307,7 @@ public class MembersController : Controller
/// Restores a previously revoked member of the organization.
/// </remarks>
/// <param name="id">The identifier of the member to be restored.</param>
[HttpPut("{id}/restore")]
[HttpPost("{id}/restore")]
[ProducesResponseType((int)HttpStatusCode.OK)]
[ProducesResponseType(typeof(ErrorResponseModel), (int)HttpStatusCode.BadRequest)]
[ProducesResponseType((int)HttpStatusCode.NotFound)]

20
test/Api.IntegrationTest/AdminConsole/Public/Controllers/MembersControllerTests.cs
View File

@@ -271,7 +271,7 @@ public class MembersControllerTests : IClassFixture<ApiApplicationFactory>, IAsy
var (_, orgUser) = await OrganizationTestHelpers.CreateNewUserWithAccountAsync(
_factory, _organization.Id, OrganizationUserType.User);
var response = await _client.PutAsync($"/public/members/{orgUser.Id}/revoke", null);
var response = await _client.PostAsync($"/public/members/{orgUser.Id}/revoke", null);
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
@@ -287,10 +287,10 @@ public class MembersControllerTests : IClassFixture<ApiApplicationFactory>, IAsy
var (_, orgUser) = await OrganizationTestHelpers.CreateNewUserWithAccountAsync(
_factory, _organization.Id, OrganizationUserType.User);
var revokeResponse = await _client.PutAsync($"/public/members/{orgUser.Id}/revoke", null);
var revokeResponse = await _client.PostAsync($"/public/members/{orgUser.Id}/revoke", null);
Assert.Equal(HttpStatusCode.OK, revokeResponse.StatusCode);
var response = await _client.PutAsync($"/public/members/{orgUser.Id}/revoke", null);
var response = await _client.PostAsync($"/public/members/{orgUser.Id}/revoke", null);
Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
var error = await response.Content.ReadFromJsonAsync<ErrorResponseModel>();
@@ -300,7 +300,7 @@ public class MembersControllerTests : IClassFixture<ApiApplicationFactory>, IAsy
[Fact]
public async Task PutRevoke_NotFound_ReturnsNotFound()
{
var response = await _client.PutAsync($"/public/members/{Guid.NewGuid()}/revoke", null);
var response = await _client.PostAsync($"/public/members/{Guid.NewGuid()}/revoke", null);
Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
}
@@ -321,7 +321,7 @@ public class MembersControllerTests : IClassFixture<ApiApplicationFactory>, IAsy
await _loginHelper.LoginWithOrganizationApiKeyAsync(_organization.Id);
// Try to revoke the user from the other organization
var response = await _client.PutAsync($"/public/members/{orgUser.Id}/revoke", null);
var response = await _client.PostAsync($"/public/members/{orgUser.Id}/revoke", null);
Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
}
@@ -332,10 +332,10 @@ public class MembersControllerTests : IClassFixture<ApiApplicationFactory>, IAsy
var (_, orgUser) = await OrganizationTestHelpers.CreateNewUserWithAccountAsync(
_factory, _organization.Id, OrganizationUserType.User);
var revokeResponse = await _client.PutAsync($"/public/members/{orgUser.Id}/revoke", null);
var revokeResponse = await _client.PostAsync($"/public/members/{orgUser.Id}/revoke", null);
Assert.Equal(HttpStatusCode.OK, revokeResponse.StatusCode);
var response = await _client.PutAsync($"/public/members/{orgUser.Id}/restore", null);
var response = await _client.PostAsync($"/public/members/{orgUser.Id}/restore", null);
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
@@ -351,7 +351,7 @@ public class MembersControllerTests : IClassFixture<ApiApplicationFactory>, IAsy
var (_, orgUser) = await OrganizationTestHelpers.CreateNewUserWithAccountAsync(
_factory, _organization.Id, OrganizationUserType.User);
var response = await _client.PutAsync($"/public/members/{orgUser.Id}/restore", null);
var response = await _client.PostAsync($"/public/members/{orgUser.Id}/restore", null);
Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
var error = await response.Content.ReadFromJsonAsync<ErrorResponseModel>();
@@ -361,7 +361,7 @@ public class MembersControllerTests : IClassFixture<ApiApplicationFactory>, IAsy
[Fact]
public async Task PutRestore_NotFound_ReturnsNotFound()
{
var response = await _client.PutAsync($"/public/members/{Guid.NewGuid()}/restore", null);
var response = await _client.PostAsync($"/public/members/{Guid.NewGuid()}/restore", null);
Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
}
@@ -382,7 +382,7 @@ public class MembersControllerTests : IClassFixture<ApiApplicationFactory>, IAsy
await _loginHelper.LoginWithOrganizationApiKeyAsync(_organization.Id);
// Try to restore the user from the other organization
var response = await _client.PutAsync($"/public/members/{orgUser.Id}/restore", null);
var response = await _client.PostAsync($"/public/members/{orgUser.Id}/restore", null);
Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
}