bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2026-02-12 22:44:00 +00:00
Code Issues Releases Wiki Activity

fix(redirect): [PM-30810] Https Redirection for Cloud Users - Fixed nullish issue.

Browse Source
This commit is contained in:
Patrick Pimentel
2026-02-10 14:18:19 -05:00
parent 0d44be620f
commit 36a5a4b2ab
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Core/Auth/Identity/TokenProviders/DuoUniversalTokenService.cs
View File

@@ -1,7 +1,4 @@
// FIXME: Update this file to be null safe and then delete the line below
#nullable disable
using System.Globalization;
using System.Globalization;
using Bit.Core.Auth.Enums;
using Bit.Core.Auth.Models;
using Bit.Core.Auth.Models.Business.Tokenables;
@@ -76,7 +73,7 @@ public interface IDuoUniversalTokenService
/// </summary>
/// <param name="provider">TwoFactorProvider Duo or OrganizationDuo</param>
/// <returns>Duo.Client object or null</returns>
Task<Duo.Client> BuildDuoTwoFactorClientAsync(TwoFactorProvider provider);
Task<Duo.Client?> BuildDuoTwoFactorClientAsync(TwoFactorProvider provider);
}
public class DuoUniversalTokenService(
@@ -181,7 +178,7 @@ public class DuoUniversalTokenService(
return null;
}
string overrideFromForm = null;
string? overrideFromForm = null;
if (httpContext.Request.HasFormContentType)
{
overrideFromForm = httpContext.Request.Form["deeplinkScheme"].FirstOrDefault();
@@ -236,7 +233,7 @@ public class DuoUniversalTokenService(
_globalSettings.BaseServiceUri.Vault, clientName);
}
public async Task<Duo.Client> BuildDuoTwoFactorClientAsync(TwoFactorProvider provider)
public async Task<Duo.Client?> BuildDuoTwoFactorClientAsync(TwoFactorProvider provider)
{
var redirectUri = BuildDuoTwoFactorRedirectUri();