bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2026-02-17 09:59:14 +00:00
Code Issues Releases Wiki Activity

fix(logging): [PM-28877] Remove Config for PII Logging - Fixed up with a better understanding of the original ask.

Browse Source
This commit is contained in:
Patrick Pimentel
2026-01-27 11:35:10 -05:00
parent 636ca8ae77
commit 4b50c62f95
3 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
bitwarden_license/src/Sso/Startup.cs
View File

@@ -90,15 +90,20 @@ public class Startup
public void Configure(
IApplicationBuilder app,
IWebHostEnvironment env,
IWebHostEnvironment environment,
IHostApplicationLifetime appLifetime,
GlobalSettings globalSettings,
ILogger<Startup> logger)
{
if (environment.IsDevelopment() || globalSettings.SelfHosted)
{
Microsoft.IdentityModel.Logging.IdentityModelEventSource.ShowPII = true;
}
// Add general security headers
app.UseMiddleware<SecurityHeadersMiddleware>();
if (!env.IsDevelopment())
if (!environment.IsDevelopment())
{
var uri = new Uri(globalSettings.BaseServiceUri.Sso);
app.Use(async (ctx, next) =>
@@ -114,7 +119,7 @@ public class Startup
app.UseForwardedHeaders(globalSettings);
}
if (env.IsDevelopment())
if (environment.IsDevelopment())
{
app.UseDeveloperExceptionPage();
app.UseCookiePolicy();

13
src/Identity/Startup.cs
View File

@@ -169,14 +169,19 @@ public class Startup
public void Configure(
IApplicationBuilder app,
IWebHostEnvironment env,
IWebHostEnvironment environment,
GlobalSettings globalSettings,
ILogger<Startup> logger)
{
if (environment.IsDevelopment() || globalSettings.SelfHosted)
{
Microsoft.IdentityModel.Logging.IdentityModelEventSource.ShowPII = true;
}
// Add general security headers
app.UseMiddleware<SecurityHeadersMiddleware>();
if (!env.IsDevelopment())
if (!environment.IsDevelopment())
{
var uri = new Uri(globalSettings.BaseServiceUri.Identity);
app.Use(async (ctx, next) =>
@@ -193,7 +198,7 @@ public class Startup
}
// Default Middleware
app.UseDefaultMiddleware(env, globalSettings);
app.UseDefaultMiddleware(environment, globalSettings);
if (!globalSettings.SelfHosted)
{
@@ -201,7 +206,7 @@ public class Startup
app.UseMiddleware<CustomIpRateLimitMiddleware>();
}
if (env.IsDevelopment())
if (environment.IsDevelopment())
{
app.UseSwagger();
app.UseDeveloperExceptionPage();

6
src/SharedWeb/Utilities/ServiceCollectionExtensions.cs
View File

@@ -471,6 +471,11 @@ public static class ServiceCollectionExtensions
addAuthorization.Invoke(config);
});
}
if (environment.IsDevelopment() || globalSettings.SelfHosted)
{
Microsoft.IdentityModel.Logging.IdentityModelEventSource.ShowPII = true;
}
}
public static void AddCustomDataProtectionServices(
@@ -660,7 +665,6 @@ public static class ServiceCollectionExtensions
Constants.BrowserExtensions.OperaId
};
}
});
}